Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unwrap method call validator errors and add tests #4808

Open
wants to merge 4 commits into
base: caip-multichain-api
Choose a base branch
from

Conversation

shanejonas
Copy link
Contributor

@shanejonas shanejonas commented Oct 17, 2024

Explanation

This removes the jsonrpc error wrapping that happens in the method call validator. Also adds a new error returned for when the parameter length is mismatched.

References

fixes this TODO item: #4784 (comment)

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@shanejonas shanejonas requested a review from a team as a code owner October 17, 2024 15:08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems a little weird to be testing against the actual schema that the multichainCallValidator is using under the hood. I understand what you're trying to get coverage on that file though. Are we still sure that we don't want to abstract the multichainCallValidator into a separate package?

@jiexi jiexi changed the base branch from caip-multichain to caip-multichain-api October 17, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants