Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NotificationController #4815

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove NotificationController #4815

wants to merge 5 commits into from

Conversation

hmalik88
Copy link
Contributor

Removes the NotificationController in favor of NotificationServicesController, see #4809

@hmalik88 hmalik88 requested review from a team as code owners October 17, 2024 21:09
@socket-security Socket Security
Copy link

socket-security bot commented Oct 17, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/utils@9.2.1

View full report↗︎

MajorLift
MajorLift approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya
Copy link
Contributor

RIP 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajorLift MajorLift MajorLift approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmalik88 @Prithpal-Sooriya @MajorLift