Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller-utils): support BigNumber as input to BNToHex #4827

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(controller-utils): support BigNumber as input to BNToHex #4827

wants to merge 3 commits into from
+25 −9

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 22, 2024 •
edited
Loading

Explanation

The API for this part is equivalent between the two libraries. Allowing both eases migrations.

References

Related

Changelog

@metamask/controller-utils

  • ADDED: Types indicate bignumber.js instances are valid input to BNToHex.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@socket-security Socket Security
Copy link

socket-security bot commented Oct 22, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@legobeat legobeat force-pushed the bignumbertohex branch 3 times, most recently from 2545fe4 to 9826643 Compare October 22, 2024 00:48
@legobeat legobeat marked this pull request as ready for review October 22, 2024 00:48
@legobeat legobeat requested review from a team as code owners October 22, 2024 00:48
@legobeat legobeat force-pushed the bignumbertohex branch 2 times, most recently from 2fef16c to fd704e0 Compare October 22, 2024 01:03
@legobeat legobeat requested a review from a team October 22, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-security team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@legobeat