Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: EarnController add resetCache arg to stakingApiService.getPooledStakes() #5334

Merged
merged 2 commits into from
Feb 14, 2025
Merged

feat: EarnController add resetCache arg to stakingApiService.getPooledStakes() #5334

merged 2 commits into from
Feb 14, 2025

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Feb 14, 2025 •
edited
Loading

Explanation

This PR adds the resetCachearg when callingstakingApiService.getPooledStakesinside theEarnController`.

Changelog

@metamask/earn-controller

  • CHANGED: Updated refreshPooledStakes internal call to stakingApiService.getPooledStakes to force cache reset

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Matt561 Matt561 marked this pull request as ready for review February 14, 2025 16:16
@Matt561 Matt561 requested a review from a team as a code owner February 14, 2025 16:16
@Matt561 Matt561 changed the title feat: updated call arguments for earn controller get pooled stakes me… feat: updated call argument for EarnController refreshPooledStakes method Feb 14, 2025
@Matt561 Matt561 changed the title feat: updated call argument for EarnController refreshPooledStakes method feat: EarnController add resetCache arg to stakingApiService.getPooledStakes() Feb 14, 2025
@Matt561 Matt561 force-pushed the feat/update-earn-controller-pooled-stakes-reset-cache-arg branch from 3a30d93 to 1eeb132 Compare February 14, 2025 18:46
amitabh94
amitabh94 previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matt561 Matt561 force-pushed the feat/update-earn-controller-pooled-stakes-reset-cache-arg branch from 1eeb132 to 44f0073 Compare February 14, 2025 19:08
@Matt561 Matt561 force-pushed the feat/update-earn-controller-pooled-stakes-reset-cache-arg branch from 44f0073 to 1da5d71 Compare February 14, 2025 19:18
@Matt561 Matt561 requested a review from amitabh94 February 14, 2025 19:18
@Matt561 Matt561 enabled auto-merge (squash) February 14, 2025 19:29
@Matt561 Matt561 merged commit b8218b6 into main Feb 14, 2025
133 checks passed
@Matt561 Matt561 deleted the feat/update-earn-controller-pooled-stakes-reset-cache-arg branch February 14, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitabh94 amitabh94 amitabh94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt561 @amitabh94