Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix broken build-test workflow #539

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

legobeat
Copy link
Contributor

Tests have not actually been running in CI since #248, which introduced an error in the workflow file. This fixes that.

Note that the package currently only supports Node.js v16; extending support to v18 will be addressed separately.

@legobeat legobeat changed the title ci: fix build-test workflow ci: fix broken build-test workflow Oct 18, 2023
@legobeat legobeat marked this pull request as ready for review October 18, 2023 08:26
@legobeat legobeat requested a review from a team as a code owner October 18, 2023 08:26
Copy link
Collaborator

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall merged commit 1d4f66a into MetaMask:main Jan 17, 2024
4 checks passed
@legobeat legobeat deleted the ci-fix-test branch January 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants