chore: updated css variables based on updated json #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianacnguyen
added
color
brianacnguyen
commented
May 29, 2024
| --color-network-localhost-default: var(--brand-colors-grey-grey200); | ||
| --color-network-localhost-inverse: var(--brand-colors-white-white010); | ||
| --color-network-sepolia-default: var(--brand-colors-violet-violet300); | ||
| --color-network-sepolia-inverse: var(--brand-colors-white-white010); |
There was a problem hiding this comment.
apparently dark theme never had these network and shadow colors to begin with. adding them to deprecated for now to be safe
brianacnguyen
commented
May 29, 2024
src/css/index.css
Outdated
| @import './typography.css'; | ||
| @import './shadow.css'; | ||
| @import './light-theme-colors.css'; |
There was a problem hiding this comment.
reordered since some [deprecated] theme colors do reference shadow
There was a problem hiding this comment.
I think these can be reverted as there is no more deprecated classnames
georgewrmarshall
requested changes
May 29, 2024
… css-tokens-update
MIGRATION.md
Outdated
Comment on lines
5
to
61
| ## From version 3.0.0 to 4.0.0 | ||
|
|
||
| ## Migration from Version 3.0.0 to 4.0.0 | ||
|
|
||
| ### Changes to Color Tokens (Breaking Changes) | ||
|
|
||
| In this version, significant updates have been made to color tokens, including modifications and removals. To upgrade to version 4, ensure that the following tokens are not present in your codebase: | ||
|
|
||
| ### Brand Colors | ||
|
|
||
| #### CSS Variables | ||
|
|
||
| ``` | ||
| --brand-colors-grey-grey030 modified to --brand-colors-grey-grey025 | ||
| --brand-colors-grey-grey040 modified to --brand-colors-grey-grey050 | ||
| --brand-colors-grey-grey750 removed | ||
| --brand-colors-blue-blue000 modified to --brand-colors-blue-blue025 | ||
| --brand-colors-green-green000 modified to --brand-colors-green-green025 | ||
| --brand-colors-red-red000 modified to --brand-colors-red-red025 | ||
| --brand-colors-yellow-yellow000 modified to --brand-colors-yellow-yellow025 | ||
| --brand-colors-orange-orange000 modified to --brand-colors-orange-orange025 | ||
| --brand-colors-violet-violet300 removed | ||
| --brand-colors-white-white000 modified to --brand-colors-white | ||
| --brand-colors-white-white010 removed | ||
| --brand-colors-black-black000 modified to --brand-colors-black | ||
| ``` | ||
|
|
||
| ### Themed Colors | ||
|
|
||
| #### CSS Variables | ||
|
|
||
| ``` | ||
| --color-primary-shadow modified to --color-shadow-primary | ||
| --color-primary-disabled removed | ||
| --color-secondary-default removed | ||
| --color-secondary-alternative removed | ||
| --color-secondary-muted removed | ||
| --color-secondary-inverse removed | ||
| --color-secondary-disabled removed | ||
| --color-error-shadow modified to --color-shadow-primary | ||
| --color-error-disabled removed | ||
| --color-warning-alternative removed | ||
| --color-warning-disabled removed | ||
| --color-success-alternative removed | ||
| --color-success-disabled removed | ||
| --color-info-alternative removed | ||
| --color-info-disabled removed | ||
| --color-network-goerli-default removed | ||
| --color-network-goerli-inverse removed | ||
| --color-network-localhost-default removed | ||
| --color-network-localhost-inverse removed | ||
| --color-network-sepolia-default removed | ||
| --color-network-sepolia-inverse removed | ||
| ``` | ||
|
|
||
| - [From version 2.1.1 to 3.0.0](#from-version-211-to-300) | ||
|
|
There was a problem hiding this comment.
What about this
Migration Guide
This guide provides detailed instructions for migrating your project from one version of the @metamask/design-tokens to another.
From version 3.0.0 to 4.0.0
Changes to Color Tokens (Breaking Changes)
In this version, significant updates have been made to color tokens, including modifications and removals. To upgrade to version 4, ensure that the following tokens have been updated in your codebase:
Removed
CSS
### Brand colors
--brand-colors-grey-grey750
--brand-colors-violet-violet300
--brand-colors-white-white010
### Theme colors
--color-primary-disabled
--color-secondary-default
--color-secondary-alternative
--color-secondary-muted
--color-secondary-inverse
--color-secondary-disabled
--color-error-disabled
--color-warning-alternative
--color-warning-disabled
--color-success-alternative
--color-success-disabled
--color-info-alternative
--color-info-disabled
--color-network-goerli-default
--color-network-goerli-inverse
--color-network-localhost-default
--color-network-localhost-inverse
--color-network-sepolia-default
--color-network-sepolia-inverse
### Component colors
--component-button-primary-shadow
--component-button-danger-shadow
JS
TBC
Changed
CSS
### Brand colors
--brand-colors-grey-grey030 modified to --brand-colors-grey-grey025
--brand-colors-grey-grey040 modified to --brand-colors-grey-grey050
--brand-colors-blue-blue000 modified to --brand-colors-blue-blue025
--brand-colors-green-green000 modified to --brand-colors-green-green025
--brand-colors-red-red000 modified to --brand-colors-red-red025
--brand-colors-yellow-yellow000 modified to --brand-colors-yellow-yellow025
--brand-colors-orange-orange000 modified to --brand-colors-orange-orange025
--brand-colors-white-white000 modified to --brand-colors-white
--brand-colors-black-black000 modified to --brand-colors-black
## Theme colors
--color-primary-shadow modified to --color-shadow-primary
--color-error-shadow modified to --color-shadow-primary
JS
TBC
src/css/index.css
Outdated
| @import './typography.css'; | ||
| @import './shadow.css'; | ||
| @import './light-theme-colors.css'; |
There was a problem hiding this comment.
I think these can be reverted as there is no more deprecated classnames
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist