Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated js variables based on updated json #709

Merged
merged 9 commits into from
May 30, 2024

Conversation

brianacnguyen
Copy link
Contributor

Description

  • This PR seeks to update the list of JS variables based on the updated JSON
  • Breaking changes were also added to the migration doc

Related issues

Fixes: N/A

Manual testing steps

  1. Go to storybook
  2. Checkout the new colors!

Screenshots/Recordings

Before

After

Screenshot 2024-05-30 at 9 27 16 AM Screenshot 2024-05-30 at 9 27 29 AM Screenshot 2024-05-30 at 9 27 37 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added color Tokens related to color team-design-system All issues relating to design system labels May 30, 2024
@brianacnguyen brianacnguyen self-assigned this May 30, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner May 30, 2024 16:28
@metamaskbot
Copy link
Collaborator

Builds ready [7463a5c]

Storybook: Storybook

Copy link
Collaborator

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as CSS PR could we structure migration docs into Added, Removed, Changed

@metamaskbot
Copy link
Collaborator

Builds ready [0d831f3]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [47b1874]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [e50c5dc]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [27621aa]

Storybook: Storybook

Copy link
Collaborator

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸🐉

@metamaskbot
Copy link
Collaborator

Builds ready [825bb32]

Storybook: Storybook

@georgewrmarshall georgewrmarshall merged commit ffc4242 into main May 30, 2024
19 checks passed
@georgewrmarshall georgewrmarshall deleted the js-tokens-update branch May 30, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Tokens related to color team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants