generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding initial spacing token #731
Draft
georgewrmarshall
wants to merge
5
commits into
main
Choose a base branch
from
feat/spacing-tokens
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
the
team-design-system
All issues relating to design system
label
Oct 11, 2024
georgewrmarshall
force-pushed
the
feat/spacing-tokens
branch
from
October 11, 2024 03:59
c51fabf
to
3bb46d9
Compare
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
@SocketSecurity ignore-all |
package.json
Outdated
Comment on lines
122
to
123
"vite>esbuild": false, | ||
"storybook>@storybook/core>esbuild": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to separate PR #734
georgewrmarshall
force-pushed
the
feat/spacing-tokens
branch
from
October 11, 2024 15:49
08caa74
to
faf9365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO DO
Description
This PR introduces spacing tokens for Figma JSON, CSS-in-JS, and CSS variables, as well as updates the Storybook documentation. It includes a new
SpacingSwatch
documentation component to visually represent the spacing tokens in Storybook. This ensures that both developers and designers can easily reference and apply consistent spacing across the design system.Related issues
Fixes: #732
Manual testing steps
SpacingSwatch
component to ensure it correctly displays the spacing tokens.Screenshots/Recordings
After
spacing1080.mov
Pre-merge author checklist
Pre-merge reviewer checklist