Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding initial spacing token #731

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Oct 11, 2024

TO DO

  • Break out into separate smaller PRs for CSS, CSSinJS and Docs
  • Create unit tests for CSS

Description

This PR introduces spacing tokens for Figma JSON, CSS-in-JS, and CSS variables, as well as updates the Storybook documentation. It includes a new SpacingSwatch documentation component to visually represent the spacing tokens in Storybook. This ensures that both developers and designers can easily reference and apply consistent spacing across the design system.

Related issues

Fixes: #732

Manual testing steps

  1. Review the generated spacing tokens in Figma JSON, CSS-in-JS, and CSS variables.
  2. Check the Storybook documentation for the SpacingSwatch component to ensure it correctly displays the spacing tokens.
  3. Ensure the documentation reflects the spacing tokens properly across different formats.
  4. Verify that the tokens are consistently applied within the design system.

Screenshots/Recordings

After

spacing1080.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues.
  • I've included manual testing steps.
  • I've included screenshots/recordings if applicable.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and/or screenshots.

@georgewrmarshall georgewrmarshall self-assigned this Oct 11, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Oct 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3bb46d9]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [ea73d57]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [fe83ff4]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [dbfd2b2]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [8daa671]

Storybook: Storybook

Copy link

socket-security bot commented Oct 11, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@georgewrmarshall
Copy link
Collaborator Author

@SocketSecurity ignore-all

@metamaskbot
Copy link
Collaborator

Builds ready [08caa74]

Storybook: Storybook

package.json Outdated
Comment on lines 122 to 123
"vite>esbuild": false,
"storybook>@storybook/core>esbuild": false
Copy link
Collaborator Author

@georgewrmarshall georgewrmarshall Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to separate PR #734

@metamaskbot
Copy link
Collaborator

Builds ready [faf9365]

Storybook: Storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create spacing tokens
2 participants