Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lavamoat/lavadome): bump to v0.0.20 #27756

Closed
wants to merge 18 commits into from
Closed

chore(lavamoat/lavadome): bump to v0.0.20 #27756

wants to merge 18 commits into from

Conversation

weizman
Copy link
Member

@weizman weizman commented Oct 10, 2024

Introduce LavaMoat/LavaDome#56 + LavaMoat/LavaDome#59

This should go with #25653

Also, bump snow version LavaMoat/snow#162 which fixes a bug that clashed with this new LavaDome version

@weizman weizman changed the title draft bump ld 0019 chore(lavadome): bump to v0.0.19 Oct 10, 2024
@weizman weizman marked this pull request as ready for review October 10, 2024 11:21
@weizman weizman requested a review from a team as a code owner October 10, 2024 11:21
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 10, 2024
@weizman weizman changed the title chore(lavadome): bump to v0.0.19 chore(lavamoat/lavadome): bump to v0.0.19 Oct 10, 2024
@weizman weizman changed the title chore(lavamoat/lavadome): bump to v0.0.19 chore(lavamoat/lavadome): bump to v0.0.20 Oct 10, 2024
@weizman weizman requested a review from a team as a code owner October 10, 2024 13:36
Copy link

@weizman
Copy link
Member Author

weizman commented Oct 27, 2024

Found the on going bug with test-e2e-firefox, it's in snow, will be fixed by LavaMoat/snow#161

@metamaskbot
Copy link
Collaborator

Builds ready [0f4450e]
Page Load Metrics (1947 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19522501711553266
domContentLoaded17462414191014670
load17902421194714168
domInteractive17189493818
backgroundConnect894392914
firstReactRender5211789199
getState46518178
initialActions01000
loadScripts12691949141214871
setupStore1268332311
uiStartup19592636214915474
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 68 Bytes (0.00%)
  • ui: 917 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@weizman weizman requested a review from a team as a code owner January 14, 2025 10:36
Copy link

socket-security bot commented Jan 14, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
High CVE npm/secp256k1@5.0.0 🚫
Native code npm/secp256k1@5.0.0 🚫
New author npm/borc@3.0.0 🚫

View full report↗︎

Next steps

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Why is native code a concern?

Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.

Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/secp256k1@5.0.0
  • @SocketSecurity ignore npm/borc@3.0.0

@metamaskbot
Copy link
Collaborator

Builds ready [4e13597]
Page Load Metrics (1633 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13711998164316077
domContentLoaded13641991160916680
load13721997163316881
domInteractive176932147
backgroundConnect783262110
firstReactRender1698523215
getState491152110
initialActions01000
loadScripts9761451117613163
setupStore671182210
uiStartup160724982000243116
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 91.26 KiB (1.60%)
  • ui: 917 Bytes (0.01%)
  • common: -3.73 KiB (-0.04%)

@weizman
Copy link
Member Author

weizman commented Jan 14, 2025

ditched in favor of #29691

@weizman weizman closed this Jan 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-lavamoat
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants