chore: remove deprecated ErrorMessage component #36872
Merged
+104
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-design-system
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (3 files, +104 -8)
|
georgewrmarshall
changed the title
georgewrmarshall
force-pushed
the
remove-error-message
branch
from
42cd6d2 to
14ffb4b
Compare
georgewrmarshall
force-pushed
the
remove-error-message
branch
from
14ffb4b to
ddfbe83
Compare
| editGasMode: EditGasModes.modifyInPlace, | ||
| balanceError: false, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Adding story for easier updates and visual regression testing
Comment on lines
-16
to
-19
| & .error-message { | ||
| margin-top: 0; | ||
| margin-bottom: 12px; | ||
| } |
There was a problem hiding this comment.
no longer using this component. this is why we shouldn't use direct CSS classnames from other components in our styles. Very easy to miss
| @@ -0,0 +1,84 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Adding story
Comment on lines
-58
to
+65
| <ErrorMessage errorKey={INSUFFICIENT_FUNDS_ERROR_KEY} /> | ||
| <BannerAlert | ||
| severity={BannerAlertSeverity.Danger} | ||
| description={t(INSUFFICIENT_FUNDS_ERROR_KEY)} | ||
| marginBottom={1} | ||
| /> |
There was a problem hiding this comment.
Replaces last instance of the ErrorMessage component with BannerAlert
georgewrmarshall
added
the
no-changelog
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [d01f9bc]
UI Startup Metrics (1251 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
georgewrmarshall
changed the title
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c4da056]
UI Startup Metrics (1225 ± 59 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brianacnguyen
approved these changes
Oct 16, 2025
OGPoyraz
approved these changes
Oct 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the deprecated
ErrorMessagecomponent from the codebase and replaces its usage with the modernBannerAlertcomponent from the component-library. This continues the effort to modernize MetaMask's UI components and remove deprecated code.Key Changes:
ErrorMessagecomponent and all related filesErrorMessageusage inEditGasFeePopoverwithBannerAlertEditGasFeePopoverComponent Migration:
ErrorMessage→BannerAlertwithseverity={BannerAlertSeverity.Danger}Changelog
CHANGELOG entry: null
Related issues
Fixes: #20394
Manual testing steps
yarn storybookyarn testScreenshots/Recordings
N/A - This is a component refactor with no visual changes to end users
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes
ErrorMessageand replaces its usage inEditGasFeePopoverwithBannerAlert, deletes related files, updates styles, and adds a Storybook story.ErrorMessagewithBannerAlert(Danger) inui/pages/confirmations/components/edit-gas-fee-popover/edit-gas-fee-popover.js(usest(INSUFFICIENT_FUNDS_ERROR_KEY)for description).BannerAlertandText.ui/components/ui/error-message/*(component, tests, stories, styles, snapshots).@import 'error-message/index';fromui/components/ui/ui-components.scss..error-messagemargin overrides fromui/pages/confirmations/components/edit-gas-fee-popover/index.scss.EditGasFeePopoverstoryedit-gas-fee-popover.stories.tsxwith mocked providers and args.Written by Cursor Bugbot for commit c4da056. This will update automatically on new commits. Configure here.