Skip to content

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Oct 14, 2025

Description

This PR removes the unused NetworkDisplay component from the codebase. The component was not being used anywhere in the application and was contributing to technical debt.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #20485

Manual testing steps

  1. Verify the application builds successfully without errors

Screenshots/Recordings

N/A - This is a code cleanup change with no UI impact

Before

NetworkDisplay component existed but was unused

After

NetworkDisplay component and all related files removed

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the unused NetworkDisplay component and cleans up all imports and references.

  • UI Cleanup:
    • Remove component: Delete ui/components/app/network-display/* (component, styles, stories).
    • Remove references:
      • Drop @import 'network-display/index' from ui/components/app/app-components.scss.
      • Remove NetworkDisplay import and entry from ui/components/app/metamask-template-renderer/safe-component-list.js.
    • Update tooling: Remove network-display entries from development/ts-migration-dashboard/files-to-convert.json.

Written by Cursor Bugbot for commit 2fcced1. This will update automatically on new commits. Configure here.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Extension label Oct 14, 2025
@georgewrmarshall georgewrmarshall self-assigned this Oct 14, 2025
@georgewrmarshall georgewrmarshall added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed size-S labels Oct 14, 2025
@georgewrmarshall georgewrmarshall requested review from a team as code owners October 14, 2025 23:19
@georgewrmarshall georgewrmarshall changed the title chore: remove unused NetworkDisplay component chore: remove deprecated NetworkDisplay component Oct 14, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +0 -2)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 metamask-template-renderer/
          • 📄 safe-component-list.js +0 -2

🫰 @MetaMask/core-platform (1 files, +0 -2)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 metamask-template-renderer/
          • 📄 safe-component-list.js +0 -2

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 2fcced1 | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.02s (±72ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 720ms (±80ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 85ms (±121ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.02s 72ms 971ms 1.33s 1.26s 1.33s
domContentLoaded 720ms 80ms 668ms 1.22s 935ms 1.22s
firstPaint 85ms 121ms 56ms 1.29s 84ms 1.29s
firstContentfulPaint 85ms 121ms 56ms 1.29s 84ms 1.29s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [2fcced1]
UI Startup Metrics (1201 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1201109615145812331311
load103695013575510621130
domContentLoaded102994213545510551124
domInteractive17135361635
firstPaint738159115739810511093
backgroundConnect25123632110254263
firstReactRender26184662942
getState1355891431
initialActions40205518
loadScripts785707110854814873
setupStore95314914
WebpackHomeuiStartup806698100359821930
load61857683452629742
domContentLoaded61157182451622736
domInteractive15115481338
firstPaint19055827183191664
backgroundConnect20104162530
firstReactRender27178693133
getState831421012
initialActions208235
loadScripts60856981449620726
setupStore84182911
FirefoxBrowserifyHomeuiStartup14801238196715615291838
load1250107716209913161430
domContentLoaded1250107716199913161430
domInteractive1013634953101229
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3219100133561
firstReactRender32266563340
getState9314216632
initialActions7020626214
loadScripts1226106215379412871398
setupStore14422130765
WebpackHomeuiStartup15311300229713715821787
load1328115316999113611488
domContentLoaded1328115316999113601487
domInteractive943036553100174
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3217126193484
firstReactRender3927102173877
getState63385512
initialActions30629213
loadScripts1304113716048413381473
setupStore1149515647
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: -1.49 KiB (-0.02%)
  • common: 10 Bytes (0%)

@georgewrmarshall georgewrmarshall added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 2b08cde Oct 17, 2025
173 checks passed
@georgewrmarshall georgewrmarshall deleted the remove-network-display branch October 17, 2025 20:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
@metamaskbot metamaskbot added the release-13.7.0 Issue or pull request that will be included in release 13.7.0 label Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.7.0 Issue or pull request that will be included in release 13.7.0 size-S team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated NetworkDisplay component with PickerNetwork from the component-library

4 participants