feat: Adding code to capture metrics for dapp swaps #36885

jpuri · 2025-10-15T10:54:11Z

Description

Capturing DAPP Swap metrics

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5974

Manual testing steps

Submit a swap
Check that metrics are captured

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Add Dapp swap comparison metrics: new hooks/utils to parse swaps, fetch quotes, compute USD values, and report telemetry; conditional banner wiring; background quotes fetch; LavaMoat policy updates; and tests.

Confirmations UI:
- Add DappSwapComparisonBanner and render it in base-transaction-info when remote flag dappSwapMetrics.enabled is true and origin is https://app.uniswap.org.
Hooks & Metrics:
- Add useDappSwapComparisonInfo to parse swap tx data, fetch quotes, compute USD values, and emit telemetry (including latency metrics via useDappSwapComparisonLatencyMetrics).
Utils:
- Add dapp-swap-comparison-utils (getDataFromSwap, getBestQuote, getTokenValueFromRecord, getBalanceChangeFromSimulationData).
- Extend token utils with fetchAllErc20Decimals and fetchAllTokenDetails; refactor useBalanceChanges to use fetchAllErc20Decimals.
Background/Controllers:
- Wire BridgeBackgroundAction.FETCH_QUOTES in metamask-controller and add store/controller-actions/bridge-controller.fetchQuotes.
Security Policy:
- Update LavaMoat policies to allow @sentry/browser and internals.
Tests:
- Add tests for banner, hooks, utils, and token helpers.

^{Written by Cursor Bugbot for commit 7e2621a. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-15T10:54:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/pages/confirmations/components/confirm/info/hooks/useUniswapShieldInfo.ts

metamaskbot · 2025-10-15T10:56:36Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (12 files, +1467 -18)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 dapp-swap-comparison-banner/
        
        📄 dapp-swap-comparison-banner.test.tsx +31 -0
        
        📄 dapp-swap-comparison-banner.tsx +12 -0
        
        📁 info/
        
        📁 base-transaction-info/
        
        📄 base-transaction-info.tsx +12 -0
      - 📁 simulation-details/
        
        📄 useBalanceChanges.ts +4 -17
    - 📁 hooks/
      - 📁 transactions/
        
        📄 useDappSwapComparisonInfo.test.ts +320 -0
        
        📄 useDappSwapComparisonInfo.ts +335 -0
        
        📄 useDappSwapComparisonLatencyMetrics.test.ts +76 -0
        
        📄 useDappSwapComparisonLatencyMetrics.ts +79 -0
    - 📁 utils/
      - 📄 dapp-swap-comparison-utils.test.ts +189 -0
      - 📄 dapp-swap-comparison-utils.ts +314 -0
      - 📄 token.test.ts +55 -1
      - 📄 token.ts +40 -0

🧩 @MetaMask/extension-devs (4 files, +692 -0)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +173 -0
  - 📁 experimental/
    - 📄 policy.json +173 -0
  - 📁 flask/
    - 📄 policy.json +173 -0
  - 📁 main/
    - 📄 policy.json +173 -0

📜 @MetaMask/policy-reviewers (4 files, +692 -0)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +173 -0
  - 📁 experimental/
    - 📄 policy.json +173 -0
  - 📁 flask/
    - 📄 policy.json +173 -0
  - 📁 main/
    - 📄 policy.json +173 -0

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🔗 @MetaMask/supply-chain (4 files, +692 -0)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +173 -0
  - 📁 experimental/
    - 📄 policy.json +173 -0
  - 📁 flask/
    - 📄 policy.json +173 -0
  - 📁 main/
    - 📄 policy.json +173 -0

ui/pages/confirmations/components/confirm/info/hooks/useUniswapShieldInfo.ts

ui/pages/confirmations/components/confirm/info/hooks/useDappSwapComparisonInfo.ts

ui/pages/confirmations/components/confirm/info/hooks/useUniswapShieldInfo.ts

metamaskbot · 2025-10-15T11:20:35Z

📊 Page Load Benchmark Results

Current Commit: c50cf29 | Date: 10/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 730ms (±69ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	71ms	1.01s	1.31s	1.29s	1.31s
domContentLoaded	730ms	69ms	696ms	994ms	953ms	994ms
firstPaint	76ms	12ms	60ms	172ms	84ms	172ms
firstContentfulPaint	76ms	12ms	60ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-15T11:20:39Z

Builds ready [c50cf29]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1137 ± 83 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1137	1001	1458	83	1178	1307
			load	964	869	1191	71	993	1098
			domContentLoaded	954	829	1181	72	987	1092
			domInteractive	18	13	49	8	17	39
			firstPaint	683	142	1272	370	969	1090
			backgroundConnect	202	187	343	19	204	230
			firstReactRender	27	16	49	8	31	45
			getState	14	5	34	7	17	28
			initialActions	6	0	46	8	6	31
			loadScripts	762	644	982	71	788	895
			setupStore	10	6	43	5	10	20
	Webpack	Home	uiStartup	857	738	1122	62	877	979
			load	645	597	941	65	648	814
			domContentLoaded	636	590	932	64	641	806
			domInteractive	16	12	60	8	15	37
			firstPaint	187	56	911	174	204	604
			backgroundConnect	22	11	45	7	27	34
			firstReactRender	27	17	40	7	33	35
			getState	9	3	21	3	11	15
			initialActions	3	0	8	2	4	7
			loadScripts	634	588	921	62	639	795
			setupStore	10	5	19	3	12	14
Firefox	Browserify	Home	uiStartup	1433	1234	2059	138	1500	1703
			load	1197	1037	1472	91	1276	1353
			domContentLoaded	1196	1037	1472	91	1276	1353
			domInteractive	100	34	323	53	97	226
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	20	71	8	38	47
			firstReactRender	29	24	47	4	30	38
			getState	9	5	85	9	8	28
			initialActions	6	1	192	19	4	12
			loadScripts	1176	1020	1446	89	1256	1331
			setupStore	13	6	147	17	10	43
	Webpack	Home	uiStartup	1522	1348	1902	99	1571	1746
			load	1305	1176	1500	79	1358	1476
			domContentLoaded	1305	1176	1500	79	1358	1476
			domInteractive	92	30	366	54	97	198
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	93	13	36	54
			firstReactRender	34	26	123	14	33	74
			getState	8	3	45	4	8	14
			initialActions	4	1	56	6	3	11
			loadScripts	1284	1160	1476	78	1337	1459
			setupStore	14	6	136	19	11	48

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.58 KiB (0.03%)
ui: 3.86 KiB (0.06%)
common: 8.17 KiB (0.1%)

matthewwalsh0 · 2025-10-15T11:21:40Z

app/scripts/metamask-controller.js

          this.controllerMessenger,
          `${BRIDGE_CONTROLLER_NAME}:${BridgeBackgroundAction.TRACK_METAMETRICS_EVENT}`,
        ),
+      [BridgeBackgroundAction.FETCH_QUOTES]: this.controllerMessenger.call.bind(


Ideally this would go in the bridge-controller-init file in the api property.

Ideally we avoid adding to the legacy MetamaskController, but for the sake of time and codeowner review, not an urgent one.

metamaskbot · 2025-10-15T12:50:15Z

📊 Page Load Benchmark Results

Current Commit: c6e3040 | Date: 10/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±74ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 752ms (±70ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	74ms	1.01s	1.36s	1.31s	1.36s
domContentLoaded	752ms	70ms	705ms	1.04s	966ms	1.04s
firstPaint	78ms	12ms	60ms	188ms	84ms	188ms
firstContentfulPaint	78ms	12ms	60ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-15T12:50:29Z

Builds ready [c6e3040]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1243 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1243	1127	1517	75	1282	1399
			load	1067	942	1248	68	1107	1235
			domContentLoaded	1060	938	1242	67	1102	1228
			domInteractive	18	14	61	9	17	38
			firstPaint	666	78	1249	440	1074	1186
			backgroundConnect	252	238	278	7	256	268
			firstReactRender	26	17	73	8	29	40
			getState	15	5	92	10	17	31
			initialActions	5	0	42	6	6	18
			loadScripts	814	691	1002	66	849	982
			setupStore	10	6	22	3	10	18
	Webpack	Home	uiStartup	842	721	1090	73	855	1007
			load	634	583	922	72	639	839
			domContentLoaded	627	578	905	70	628	832
			domInteractive	15	11	45	8	14	35
			firstPaint	166	55	925	164	181	595
			backgroundConnect	21	10	51	7	26	35
			firstReactRender	28	17	91	12	32	55
			getState	9	3	18	3	12	15
			initialActions	3	0	9	2	4	5
			loadScripts	624	576	895	68	626	822
			setupStore	10	5	15	3	12	14
Firefox	Browserify	Home	uiStartup	1430	1256	1835	137	1488	1742
			load	1194	1070	1534	95	1266	1365
			domContentLoaded	1194	1069	1533	95	1265	1365
			domInteractive	98	33	309	52	93	230
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	20	103	14	37	67
			firstReactRender	30	26	51	4	30	37
			getState	12	5	155	21	8	19
			initialActions	6	2	91	11	4	23
			loadScripts	1173	1052	1516	93	1243	1343
			setupStore	13	6	141	17	10	57
	Webpack	Home	uiStartup	1561	1367	2053	135	1591	1891
			load	1334	1192	1627	89	1389	1504
			domContentLoaded	1334	1192	1627	89	1388	1504
			domInteractive	99	31	430	59	105	184
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	19	108	17	41	83
			firstReactRender	32	26	76	8	34	41
			getState	11	4	158	19	8	43
			initialActions	4	1	35	5	3	12
			loadScripts	1309	1172	1593	86	1361	1480
			setupStore	14	5	137	20	12	48

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.81 KiB (0.04%)
ui: 6.15 KiB (0.1%)
common: 9.41 KiB (0.11%)

ui/pages/confirmations/components/confirm/info/dapp-swap-comparison-utils.ts

…ension into uni_shield

cursor · 2025-10-23T10:51:06Z

Bug: Latency Calculation Error Causes NaN

The updateQuoteRequestLatency function incorrectly calculates latency. It adds requestDetectionLatency to the elapsed time from currentConfirmation?.time, effectively double-counting the initial time. This results in an inflated quoteRequestLatency and can produce NaN if requestDetectionLatency is 'N/A'.

cursor · 2025-10-23T10:51:07Z

Bug: Latency Calculation Fails on Initial 'N/A' Value

In updateQuoteRequestLatency, parseInt(requestDetectionLatency, 10) can evaluate to NaN because requestDetectionLatency might still be its initial 'N/A' value. This causes the quoteRequestLatency calculation to become NaN, resulting in an invalid latency metric.

cursor · 2025-10-23T10:51:07Z

Bug: Case-Sensitive Address Comparison Bug

The getBalanceChangeFromSimulationData function compares change.address and tokenAddress in a case-sensitive way. Because Ethereum addresses are case-insensitive, this comparison might incorrectly miss matching token balance changes. For example, getTokenValueFromRecord in this file correctly uses a case-insensitive approach.

cursor · 2025-10-23T11:09:12Z

Bug: Latency Metric Inflated by Double Counting

The updateQuoteRequestLatency function's calculation for quoteRequestLatency double-counts time. It adds requestDetectionLatency to the elapsed time, but requestDetectionLatency is already a duration measured from the confirmation's start time, leading to an inflated metric.

cursor · 2025-10-23T11:09:13Z

Bug: Unit Mismatch in Token Amount Comparison

In getBestQuote, the comparison between quote.minDestTokenAmount and amountMinInUSD directly compares a raw token amount with a USD value. This unit mismatch results in incorrect comparison logic.

cursor · 2025-10-23T11:09:14Z

Bug: Stale Data in `useAsyncResult` Hook

The useAsyncResult hooks' dependency arrays use tokenAddresses?.length instead of tokenAddresses. This can lead to stale token details and fiat rates if the array's contents change without its length changing.

metamaskbot · 2025-10-23T11:34:14Z

📊 Page Load Benchmark Results

Current Commit: 6da443b | Date: 10/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±75ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 753ms (±72ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	75ms	1.03s	1.34s	1.33s	1.34s
domContentLoaded	753ms	72ms	714ms	1.02s	998ms	1.02s
firstPaint	79ms	13ms	60ms	192ms	92ms	192ms
firstContentfulPaint	79ms	13ms	60ms	192ms	92ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-23T11:34:21Z

Builds ready [6da443b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1250 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1250	1112	1584	70	1291	1373
			load	1074	936	1427	69	1105	1180
			domContentLoaded	1067	931	1420	69	1098	1173
			domInteractive	19	14	54	8	17	43
			firstPaint	609	88	1275	433	1090	1145
			backgroundConnect	234	222	371	15	236	246
			firstReactRender	27	18	92	9	27	44
			getState	15	5	42	7	17	31
			initialActions	6	0	68	9	6	30
			loadScripts	840	713	1188	68	869	942
			setupStore	10	6	46	5	11	16
	Browserify	Power User Home	uiStartup	2587	1843	3569	566	3105	3569
			load	1226	958	1823	259	1515	1823
			domContentLoaded	1212	951	1794	254	1510	1794
			domInteractive	33	16	77	20	57	77
			firstPaint	764	196	1835	518	1168	1835
			backgroundConnect	392	229	1755	373	344	1755
			firstReactRender	25	21	45	6	26	45
			getState	185	162	247	24	195	247
			initialActions	87	1	410	140	180	410
			loadScripts	959	727	1493	227	1230	1493
			setupStore	20	6	62	17	28	62
	Webpack	Standard Home	uiStartup	857	726	1151	77	888	1039
			load	643	591	937	66	647	805
			domContentLoaded	636	587	927	65	641	798
			domInteractive	16	11	60	9	14	38
			firstPaint	180	56	762	153	195	601
			backgroundConnect	23	11	47	7	28	37
			firstReactRender	28	17	76	11	33	59
			getState	9	4	25	3	11	14
			initialActions	3	0	14	2	4	7
			loadScripts	632	585	914	63	638	787
			setupStore	10	5	24	3	12	14
	Webpack	Power User Home	uiStartup	1568	1122	1909	263	1852	1909
			load	640	549	875	97	712	875
			domContentLoaded	615	539	835	82	684	835
			domInteractive	24	12	56	16	45	56
			firstPaint	492	71	878	268	708	878
			backgroundConnect	149	17	322	112	289	322
			firstReactRender	42	17	215	57	22	215
			getState	172	124	276	42	167	276
			initialActions	7	1	25	9	12	25
			loadScripts	611	537	828	79	674	828
			setupStore	13	6	40	10	20	40
Firefox	Browserify	Standard Home	uiStartup	1417	1207	1739	108	1467	1629
			load	1212	1054	1503	77	1268	1345
			domContentLoaded	1212	1053	1502	77	1268	1345
			domInteractive	113	32	440	53	115	233
			firstPaint	-	-	-	-	-	-
			backgroundConnect	35	20	101	14	41	58
			firstReactRender	25	20	49	6	26	39
			getState	10	4	76	11	11	38
			initialActions	4	1	25	3	3	10
			loadScripts	1188	1038	1479	75	1240	1318
			setupStore	12	5	49	9	11	33
	Browserify	Power User Home	uiStartup	2749	2349	4077	442	2973	4077
			load	1444	1266	1909	193	1641	1909
			domContentLoaded	1444	1266	1909	194	1641	1909
			domInteractive	184	79	468	103	282	468
			firstPaint	-	-	-	-	-	-
			backgroundConnect	201	24	1297	320	367	1297
			firstReactRender	40	26	59	8	44	59
			getState	176	89	225	41	220	225
			initialActions	8	1	64	15	8	64
			loadScripts	1406	1247	1853	176	1572	1853
			setupStore	17	6	46	10	26	46
	Webpack	Standard Home	uiStartup	1616	1418	2329	145	1669	1951
			load	1386	1190	1764	104	1442	1596
			domContentLoaded	1386	1190	1764	104	1442	1596
			domInteractive	109	31	388	62	118	238
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	21	293	35	43	87
			firstReactRender	29	22	77	9	30	40
			getState	9	4	102	12	9	14
			initialActions	7	1	187	20	4	26
			loadScripts	1360	1173	1725	103	1417	1570
			setupStore	12	6	56	10	11	37
	Webpack	Power User Home	uiStartup	2638	2335	3185	260	2891	3185
			load	1578	1332	1977	204	1756	1977
			domContentLoaded	1578	1331	1976	203	1755	1976
			domInteractive	158	57	421	101	206	421
			firstPaint	-	-	-	-	-	-
			backgroundConnect	125	31	394	136	287	394
			firstReactRender	37	27	55	9	49	55
			getState	143	67	259	53	188	259
			initialActions	8	1	30	8	12	30
			loadScripts	1539	1295	1903	184	1722	1903
			setupStore	27	5	115	29	36	115

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 223 Bytes (0%)
ui: 492.4 KiB (7.53%)
common: -37 Bytes (0%)

cursor · 2025-10-23T12:25:43Z

Bug: Latency Calculation Error: Double-Counting Issue

The updateQuoteRequestLatency function calculates quoteRequestLatency incorrectly. It adds requestDetectionLatency to the current elapsed time from currentConfirmation?.time. As requestDetectionLatency is already a duration from currentConfirmation?.time, this double-counts that initial period, resulting in an inflated latency metric.

cursor · 2025-10-23T12:25:44Z

Bug: Mismatched Units in Quote Comparison

In getBestQuote, quote.minDestTokenAmount (a raw token amount) is directly compared with amountMinInUSD (a USD value). This comparison of incompatible units leads to incorrect quote selection.

metamaskbot · 2025-10-23T12:50:45Z

📊 Page Load Benchmark Results

Current Commit: 7e2621a | Date: 10/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±85ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 746ms (±100ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 91ms (±149ms) 🟢 | historical mean value: 81ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	85ms	1.01s	1.61s	1.27s	1.61s
domContentLoaded	746ms	100ms	701ms	1.51s	945ms	1.51s
firstPaint	91ms	149ms	60ms	1.58s	84ms	1.58s
firstContentfulPaint	91ms	149ms	60ms	1.58s	84ms	1.58s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-23T12:51:05Z

Builds ready [7e2621a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1286 ± 84 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1286	1120	1522	84	1346	1428
			load	1108	963	1331	77	1165	1237
			domContentLoaded	1102	958	1325	76	1159	1231
			domInteractive	20	14	52	8	19	43
			firstPaint	655	80	1338	453	1116	1213
			backgroundConnect	234	221	259	8	237	251
			firstReactRender	27	19	56	7	29	40
			getState	16	6	89	10	18	34
			initialActions	6	0	85	9	6	15
			loadScripts	874	739	1103	76	933	1001
			setupStore	10	7	31	3	11	16
	Browserify	Power User Home	uiStartup	2213	1876	3200	459	2695	3200
			load	1107	930	1856	258	1331	1856
			domContentLoaded	1098	923	1823	253	1326	1823
			domInteractive	28	16	70	19	44	70
			firstPaint	678	151	1864	518	974	1864
			backgroundConnect	252	225	347	32	263	347
			firstReactRender	22	20	25	2	24	25
			getState	215	181	425	57	219	425
			initialActions	4	2	9	2	5	9
			loadScripts	857	698	1502	227	1080	1502
			setupStore	13	8	27	7	24	27
	Webpack	Standard Home	uiStartup	840	710	1524	102	855	1034
			load	645	572	1376	109	640	883
			domContentLoaded	637	566	1356	108	633	877
			domInteractive	15	11	48	8	14	35
			firstPaint	203	57	1385	220	193	722
			backgroundConnect	22	11	58	7	27	34
			firstReactRender	26	16	56	8	31	35
			getState	9	3	21	3	11	16
			initialActions	3	0	11	2	4	8
			loadScripts	634	564	1342	105	631	866
			setupStore	9	5	21	3	11	13
	Webpack	Power User Home	uiStartup	1685	1235	2324	359	2079	2324
			load	699	605	983	122	821	983
			domContentLoaded	677	592	928	109	792	928
			domInteractive	23	13	74	17	32	74
			firstPaint	530	76	932	294	796	932
			backgroundConnect	187	13	795	246	215	795
			firstReactRender	22	20	28	2	23	28
			getState	161	27	184	37	177	184
			initialActions	7	1	50	12	10	50
			loadScripts	673	590	917	105	781	917
			setupStore	12	6	25	5	14	25
Firefox	Browserify	Standard Home	uiStartup	1462	1222	1834	112	1513	1721
			load	1240	1056	1507	73	1282	1364
			domContentLoaded	1240	1056	1507	73	1282	1364
			domInteractive	122	35	394	59	130	288
			firstPaint	-	-	-	-	-	-
			backgroundConnect	36	20	112	15	41	68
			firstReactRender	25	21	61	5	26	33
			getState	11	3	148	16	11	34
			initialActions	5	1	121	12	4	13
			loadScripts	1215	1039	1480	70	1256	1345
			setupStore	18	5	314	39	11	40
	Browserify	Power User Home	uiStartup	2696	2384	3292	267	2920	3292
			load	1436	1249	1747	144	1583	1747
			domContentLoaded	1436	1248	1747	144	1583	1747
			domInteractive	154	47	346	88	223	346
			firstPaint	-	-	-	-	-	-
			backgroundConnect	175	38	459	150	395	459
			firstReactRender	39	27	65	10	45	65
			getState	150	85	216	30	164	216
			initialActions	8	1	24	8	16	24
			loadScripts	1388	1206	1704	145	1509	1704
			setupStore	30	6	75	24	53	75
	Webpack	Standard Home	uiStartup	1598	1373	1993	127	1684	1847
			load	1375	1212	1743	108	1433	1624
			domContentLoaded	1375	1212	1743	108	1433	1624
			domInteractive	109	32	400	70	107	283
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	22	173	20	44	72
			firstReactRender	28	22	76	9	30	40
			getState	8	5	19	3	11	14
			initialActions	7	1	60	11	5	45
			loadScripts	1350	1193	1719	107	1410	1594
			setupStore	15	5	154	21	11	59
	Webpack	Power User Home	uiStartup	2689	2394	3147	232	2921	3147
			load	1578	1330	1910	186	1789	1910
			domContentLoaded	1578	1330	1910	186	1789	1910
			domInteractive	137	50	305	68	206	305
			firstPaint	-	-	-	-	-	-
			backgroundConnect	112	33	387	106	172	387
			firstReactRender	41	27	95	16	46	95
			getState	170	98	236	41	218	236
			initialActions	11	2	31	9	17	31
			loadScripts	1545	1309	1840	177	1748	1840
			setupStore	36	9	131	33	69	131

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 223 Bytes (0%)
ui: 492.4 KiB (7.53%)
common: -37 Bytes (0%)

metamaskbot added the team-confirmations Push issues to confirmations team label Oct 15, 2025

jpuri commented Oct 15, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useUniswapShieldInfo.ts Outdated Show resolved Hide resolved

jpuri commented Oct 15, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useUniswapShieldInfo.ts Outdated Show resolved Hide resolved

github-actions bot added the size-M label Oct 15, 2025

jpuri commented Oct 15, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useUniswapShieldInfo.ts Outdated Show resolved Hide resolved

jpuri commented Oct 15, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useUniswapShieldInfo.ts Outdated Show resolved Hide resolved

matthewwalsh0 reviewed Oct 15, 2025

View reviewed changes

jpuri changed the title ~~feat: Adding code to capture metrics for uniswap shield~~ feat: Adding code to capture metrics for swaps Oct 15, 2025

jpuri force-pushed the uni_shield branch from 357f14f to c1f0d6d Compare October 15, 2025 12:16

jpuri changed the title ~~feat: Adding code to capture metrics for swaps~~ feat: Adding code to capture metrics for dapp swaps Oct 15, 2025

jpuri force-pushed the uni_shield branch 2 times, most recently from 02c4771 to c060e20 Compare October 15, 2025 12:22

Adding code to capture metrics for uniswap shield

c6e3040

jpuri force-pushed the uni_shield branch from c060e20 to c6e3040 Compare October 15, 2025 12:23

jpuri added 4 commits October 16, 2025 09:36

update

ac4116b

merge

6d9b5bd

update

4f5a040

Merge branch 'main' into uni_shield

df5310c

jpuri requested review from bschorchit and matthewwalsh0 October 16, 2025 10:48

jpuri commented Oct 16, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/dapp-swap-comparison-utils.ts Outdated Show resolved Hide resolved

jpuri added 2 commits October 16, 2025 16:40

updates

69bf689

Merge branch 'uni_shield' of https://github.com/MetaMask/metamask-ext…

a20fbc6

…ension into uni_shield

update

f6e7f9b

matthewwalsh0 previously approved these changes Oct 23, 2025

View reviewed changes

update

e4a630f

jpuri dismissed matthewwalsh0’s stale review via e4a630f October 23, 2025 11:05

jpuri requested a review from matthewwalsh0 October 23, 2025 11:05

Merge branch 'main' into uni_shield

6da443b

OGPoyraz approved these changes Oct 23, 2025

View reviewed changes

matthewwalsh0 approved these changes Oct 23, 2025

View reviewed changes

jpuri added this pull request to the merge queue Oct 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025

Merge branch 'main' into uni_shield

7e2621a

jpuri enabled auto-merge October 23, 2025 12:23

jpuri added this pull request to the merge queue Oct 23, 2025

Merged via the queue into main with commit 7bf54c4 Oct 23, 2025
173 of 174 checks passed

jpuri deleted the uni_shield branch October 23, 2025 13:21

github-actions bot locked and limited conversation to collaborators Oct 23, 2025

metamaskbot added the release-13.7.0 Issue or pull request that will be included in release 13.7.0 label Oct 23, 2025

feat: Adding code to capture metrics for dapp swaps #36885

feat: Adding code to capture metrics for dapp swaps #36885

Uh oh!

Conversation

jpuri commented Oct 15, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Oct 15, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 15, 2025

Uh oh!

matthewwalsh0 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

matthewwalsh0 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Oct 15, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 15, 2025

Uh oh!

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Latency Calculation Error Causes NaN

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Latency Calculation Fails on Initial 'N/A' Value

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Case-Sensitive Address Comparison Bug

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Latency Metric Inflated by Double Counting

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Unit Mismatch in Token Amount Comparison

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Stale Data in useAsyncResult Hook

Uh oh!

metamaskbot commented Oct 23, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 23, 2025

Uh oh!

Uh oh!

cursor bot commented Oct 23, 2025

jpuri commented Oct 15, 2025 •

edited by cursor bot

Loading

metamaskbot commented Oct 15, 2025 •

edited

Loading

Bug: Stale Data in `useAsyncResult` Hook