Skip to content

Conversation

XxdpavelxX
Copy link
Contributor

@XxdpavelxX XxdpavelxX commented Oct 15, 2025

Tested here: consensys-test#204, https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/18538077577
Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-2576

Added a new workflow to update or create the changelog when release PRs are created or receive new merges.

Update Release Changelog PR (update-release-changelog.yml)
When it runs:
Triggers on every push to release branches matching:
Version-v* (e.g., Version-v13.3.0)
release/[0-9]+.[0-9]+.[0-9]+ (e.g., release/999.98.0)
What it does:
Calls the github-tools update-release-changelog.yml workflow
This workflow runs the update-release-changelog.sh script
The script uses @metamask/auto-changelog to generate/update the changelog

When CHANGELOG.md Gets Created or Updated
Initial Creation:
Branch Creation: When you create a release/999.98.0 branch
Auto Create Release PR: Triggers and calls create-release-pr.yml
Create Release PR: Calls github-tools to create the release PR
Changelog Creation: The github-tools script:
Creates a changelog branch: release/999.98.0-Changelog
Runs yarn auto-changelog update --rc --autoCategorize --useChangelogEntry --useShortPrLink
Creates/updates CHANGELOG.md with commits since the last tag
Creates a PR: release: release/999.98.0-Changelog
Subsequent Updates:
New Commits: When you push new commits to release/999.98.0
Update Release Changelog PR: Triggers automatically
Changelog Update: The workflow:
Checks out the existing release/999.98.0-Changelog branch
Runs the auto-changelog script again
Updates the existing CHANGELOG.md with new commits
Commits and pushes the changes to the existing changelog PR
The auto-changelog looks for git tags to determine the commit range
Duplicate Filtering: It filters out commits that don't have PR numbers or are already in the changelog

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a GitHub Actions workflow that triggers on release/x.y.z pushes to create/update the changelog PR via the shared github-tools workflow.

  • CI/Workflows:
    • New /.github/workflows/update-release-changelog.yml:
      • Triggers on push to release/[0-9]+.[0-9]+.[0-9]+.
      • Uses reusable workflow MetaMask/github-tools/.github/workflows/update-release-changelog.yml@36dc168... with inputs: release-branch, repository-url, platform: extension, github-tools-version, previous-version-ref: null.
      • Sets permissions: contents: write, pull-requests: write; concurrency group update-release-changelog-${{ github.ref }}.
      • Uses secret github-token: secrets.PR_TOKEN.

Written by Cursor Bugbot for commit 2599f84. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Oct 15, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 7af9302 | Date: 10/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±76ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 742ms (±72ms) 🟢 | historical mean value: 739ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±15ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 76ms 1.02s 1.36s 1.30s 1.36s
domContentLoaded 742ms 72ms 704ms 1.01s 990ms 1.01s
firstPaint 78ms 15ms 60ms 204ms 92ms 204ms
firstContentfulPaint 78ms 15ms 60ms 204ms 92ms 204ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [7af9302]
UI Startup Metrics (1282 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1282114014947113181440
load109697612746311271241
domContentLoaded109097012716311191233
domInteractive19145771837
firstPaint74879125243211081196
backgroundConnect26124229410266284
firstReactRender28195783145
getState1756392135
initialActions51416617
loadScripts835726102962861972
setupStore1063041117
WebpackHomeuiStartup846716115771870980
load64457798979651827
domContentLoaded63657198078641803
domInteractive161179101441
firstPaint18853909171195604
backgroundConnect21104572633
firstReactRender26175883236
getState942031113
initialActions3018347
loadScripts63356997076639801
setupStore1062531214
FirefoxBrowserifyHomeuiStartup14641287191413115271732
load1222109215749512941379
domContentLoaded1222109115749512931378
domInteractive1013229756102256
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3523145164062
firstReactRender30254843141
getState93536920
initialActions6113514414
loadScripts1200107515529412721355
setupStore166244291152
WebpackHomeuiStartup17061517229513517831930
load14481292176810715181646
domContentLoaded14481292176710715171646
domInteractive1063346274104372
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect422598154878
firstReactRender3828106143887
getState942231015
initialActions52517416
loadScripts14221272174210614901625
setupStore146147171238
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

vpintorico
vpintorico previously approved these changes Oct 16, 2025
on:
push:
branches:
- 'Version-v*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer need to support Version-v format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

README.md Outdated
- [Change the logo that appears when your dapp connects to MetaMask.](https://docs.metamask.io/wallet/how-to/display/icon/)

[1]: http://www.nomnoml.com/#view/%5B%3Cactor%3Euser%5D%0A%0A%5Bmetamask-ui%7C%0A%20%20%20%5Btools%7C%0A%20%20%20%20%20react%0A%20%20%20%20%20redux%0A%20%20%20%20%20thunk%0A%20%20%20%20%20ethUtils%0A%20%20%20%20%20jazzicon%0A%20%20%20%5D%0A%20%20%20%5Bcomponents%7C%0A%20%20%20%20%20app%0A%20%20%20%20%20account-detail%0A%20%20%20%20%20accounts%0A%20%20%20%20%20locked-screen%0A%20%20%20%20%20restore-vault%0A%20%20%20%20%20identicon%0A%20%20%20%20%20config%0A%20%20%20%20%20info%0A%20%20%20%5D%0A%20%20%20%5Breducers%7C%0A%20%20%20%20%20app%0A%20%20%20%20%20metamask%0A%20%20%20%20%20identities%0A%20%20%20%5D%0A%20%20%20%5Bactions%7C%0A%20%20%20%20%20%5BbackgroundConnection%5D%0A%20%20%20%5D%0A%20%20%20%5Bcomponents%5D%3A-%3E%5Bactions%5D%0A%20%20%20%5Bactions%5D%3A-%3E%5Breducers%5D%0A%20%20%20%5Breducers%5D%3A-%3E%5Bcomponents%5D%0A%5D%0A%0A%5Bweb%20dapp%7C%0A%20%20%5Bui%20code%5D%0A%20%20%5Bweb3%5D%0A%20%20%5Bmetamask-inpage%5D%0A%20%20%0A%20%20%5B%3Cactor%3Eui%20developer%5D%0A%20%20%5Bui%20developer%5D-%3E%5Bui%20code%5D%0A%20%20%5Bui%20code%5D%3C-%3E%5Bweb3%5D%0A%20%20%5Bweb3%5D%3C-%3E%5Bmetamask-inpage%5D%0A%5D%0A%0A%5Bmetamask-background%7C%0A%20%20%5Bprovider-engine%5D%0A%20%20%5Bhooked%20wallet%20subprovider%5D%0A%20%20%5Bid%20store%5D%0A%20%20%0A%20%20%5Bprovider-engine%5D%3C-%3E%5Bhooked%20wallet%20subprovider%5D%0A%20%20%5Bhooked%20wallet%20subprovider%5D%3C-%3E%5Bid%20store%5D%0A%20%20%5Bconfig%20manager%7C%0A%20%20%20%20%5Brpc%20configuration%5D%0A%20%20%20%20%5Bencrypted%20keys%5D%0A%20%20%20%20%5Bwallet%20nicknames%5D%0A%20%20%5D%0A%20%20%0A%20%20%5Bprovider-engine%5D%3C-%5Bconfig%20manager%5D%0A%20%20%5Bid%20store%5D%3C-%3E%5Bconfig%20manager%5D%0A%5D%0A%0A%5Buser%5D%3C-%3E%5Bmetamask-ui%5D%0A%0A%5Buser%5D%3C%3A--%3A%3E%5Bweb%20dapp%5D%0A%0A%5Bmetamask-contentscript%7C%0A%20%20%5Bplugin%20restart%20detector%5D%0A%20%20%5Brpc%20passthrough%5D%0A%5D%0A%0A%5Brpc%20%7C%0A%20%20%5Bethereum%20blockchain%20%7C%0A%20%20%20%20%5Bcontracts%5D%0A%20%20%20%20%5Baccounts%5D%0A%20%20%5D%0A%5D%0A%0A%5Bweb%20dapp%5D%3C%3A--%3A%3E%5Bmetamask-contentscript%5D%0A%5Bmetamask-contentscript%5D%3C-%3E%5Bmetamask-background%5D%0A%5Bmetamask-background%5D%3C-%3E%5Bmetamask-ui%5D%0A%5Bmetamask-background%5D%3C-%3E%5Brpc%5D%0A

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably an error: these new lines are not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, removed

repository-url: ${{ github.server_url }}/${{ github.repository }}
platform: extension
github-tools-version: 36dc168896c1b496f35fc880ee8a3625b4b837ba
previous-version-ref: null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unnecessary Parameter in Code

The previous-version-ref: null parameter appears to be unnecessary based on reviewer feedback ("these new lines are not needed"). This parameter should likely be removed entirely rather than explicitly set to null.

Fix in Cursor Fix in Web

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 2599f84 | Date: 10/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±72ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 733ms (±84ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±41ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 72ms 998ms 1.33s 1.24s 1.33s
domContentLoaded 733ms 84ms 696ms 1.27s 926ms 1.27s
firstPaint 80ms 41ms 60ms 484ms 92ms 484ms
firstContentfulPaint 80ms 41ms 60ms 484ms 92ms 484ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [2599f84]
UI Startup Metrics (1253 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1253112214136612861377
load107296312126011071178
domContentLoaded106495512055910991171
domInteractive18135581841
firstPaint69971120242310881176
backgroundConnect25523837715259271
firstReactRender26177782742
getState1983662232
initialActions40243511
loadScripts81671696157849921
setupStore962231018
WebpackHomeuiStartup809685107668835948
load60054690472597773
domContentLoaded59254089371590755
domInteractive15114671434
firstPaint18550855182171588
backgroundConnect23114472735
firstReactRender25163773234
getState1151831316
initialActions3010247
loadScripts59053888570589753
setupStore1051631214
FirefoxBrowserifyHomeuiStartup14461245195113715011726
load1219106214619012911367
domContentLoaded1219106214619012901366
domInteractive1123529449122241
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3619100134157
firstReactRender27204672645
getState84829715
initialActions5118419312
loadScripts1197104514408712701349
setupStore156208221335
WebpackHomeuiStartup15461342199311315961781
load1328117115818913951514
domContentLoaded1327117115818913941514
domInteractive95343304697188
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect4121133174766
firstReactRender26224952735
getState74142812
initialActions3141439
loadScripts1304115515568513701475
setupStore176232271448
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -45.08 KiB (-0.99%)
  • ui: 12.87 KiB (0.2%)
  • common: 61.68 KiB (0.74%)

@XxdpavelxX XxdpavelxX enabled auto-merge October 20, 2025 18:18
@XxdpavelxX XxdpavelxX added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants