feat: for quoted swap use data from quote to populate estimated changes #37574
+270
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
changed the title
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (10 files, +270 -15)
|
Collaborator
Builds ready [ec93043]
UI Startup Metrics (1254 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...irmations/components/confirm/quote-swap-simulation-details/quote-swap-simulation-details.tsx
Show resolved
Hide resolved
...irmations/components/confirm/quote-swap-simulation-details/quote-swap-simulation-details.tsx
Outdated
Show resolved
Hide resolved
...irmations/components/confirm/quote-swap-simulation-details/quote-swap-simulation-details.tsx
Show resolved
Hide resolved
...irmations/components/confirm/quote-swap-simulation-details/quote-swap-simulation-details.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Builds ready [056ea61]
UI Startup Metrics (1131 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Collaborator
Builds ready [cacbbec]
UI Startup Metrics (1230 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
...irmations/components/confirm/quote-swap-simulation-details/quote-swap-simulation-details.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Builds ready [a049e99]
UI Startup Metrics (1187 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...ions/components/confirm/quote-swap-simulation-details/quote-swap-simulation-details.test.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Builds ready [12c0d94]
UI Startup Metrics (1242 ± 76 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…-extension into simulation_fix
Collaborator
Builds ready [25b8695]
UI Startup Metrics (1251 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [aded29b]
UI Startup Metrics (1226 ± 94 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...irmations/components/confirm/quote-swap-simulation-details/quote-swap-simulation-details.tsx
Show resolved
Hide resolved
| asset: { | ||
| ...tokenDetails[srcAsset.address as Hex], | ||
| chainId: toHex(srcAsset.chainId), | ||
| address: srcAsset.address as Hex, |
There was a problem hiding this comment.
Bug: Case-Sensitive Token Detail Lookup Mismatch Failure
The tokenDetails lookup uses srcAsset.address directly without lowercasing, but fetchAllTokenDetails returns keys normalized to lowercase. This causes the spread operation to fail silently when the address has mixed case, resulting in missing token details. The same code correctly lowercases addresses when accessing fiatRates on line 49.
| asset: { | ||
| ...tokenDetails[destAsset.address as Hex], | ||
| chainId: toHex(destAsset.chainId), | ||
| address: destAsset.address as Hex, |
There was a problem hiding this comment.
Bug: Case-Sensitive Token Detail Lookup Mismatch
The tokenDetails lookup uses destAsset.address directly without lowercasing, but fetchAllTokenDetails returns keys normalized to lowercase. This causes the spread operation to fail silently when the address has mixed case, resulting in missing token details. The same code correctly lowercases addresses when accessing fiatRates on line 64.
Collaborator
Builds ready [eaae3e6]
UI Startup Metrics (1246 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For MetaMask suggested swap estimated changes should be populated from quote data.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6192
Manual testing steps
Screenshots/Recordings
Screen.Recording.2025-11-07.at.12.16.22.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Displays estimated changes for MetaMask quoted swaps using quote/fiat data via a new simulation details component; hides batch simulation for quoted swaps; exposes fiat rates from hooks.
QuoteSwapSimulationDetailsindapp-swap-comparison-bannerwhenSwapType.Metamaskis selected.useDappSwapComparisonInfo(fiatRates,sourceTokenAmount,tokenDetails).components/confirm/quote-swap-simulation-details/quote-swap-simulation-details: renders outgoing/incoming balance changes fromQuoteResponseusing fiat rates and token metadata.SimulationDetailsLayout(nowexport const).batch-simulation-details: skip rendering forrevokeDelegation, upgrade-only, and quoted swaps viauseSwapCheck.useDappSwapUSDValues: now returnsfiatRates.useDappSwapComparisonInfo: returnsfiatRates,sourceTokenAmount,tokenDetails, and computes differences; consumes new USD values.QuoteSwapSimulationDetails.fiatRatespropagation.Written by Cursor Bugbot for commit eaae3e6. This will update automatically on new commits. Configure here.