feat: shield-confirmation-alert-update #37580
Open
+236
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (8 files, +105 -23)
|
tuna1207
changed the title
tuna1207
requested review from
chaitanyapotti,
lwin-kyaw and
pedronfigueiredo
Collaborator
Builds ready [5b4c75e]
UI Startup Metrics (1298 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [5e81934]
UI Startup Metrics (1235 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [433ed94]
UI Startup Metrics (1226 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [aade062]
UI Startup Metrics (1218 ± 79 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [e876676]
UI Startup Metrics (1243 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [5b3d867]
UI Startup Metrics (1083 ± 82 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix shield coverage status for simple send to show gray not covered
Handle shield coverage paused status
Update confirmation alert and shield coverage alert to
iinfor circle for all shield coverage iconChangelog
CHANGELOG entry: All coverage statuses show a background of a lighter text color
CHANGELOG entry: Gray status for not covered shield coverage status
CHANGELOG entry: Icon i info for all shield coverage status alert
CHANGELOG entry: Fix shield coverage status for simple send not showing
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds paused handling and simple-send fallback for Transaction Shield, introduces
Severity.Disabled, and extends inline/ modal alert APIs and visuals.useEnableShieldCoverageChecks()returnsisEnabledorisPaused.TRANSACTION_SHIELD_ROUTE.Severity.Disabledfor not covered; keep success/danger for covered/malicious.Severity.Disabled; include in sort order and styles (pill + muted background).InlineAlert: supports pill style, customiconName,iconColor, right-aligned icon, andbackgroundColor.AlertModal: supports custom header icon/color and custom acknowledge button text/onClick.useEnableShieldCoverageChecksreturns{ isEnabled, isPaused }(detects paused subscription).useShieldCoverageAlertupdated to new logic/props and paused flow.enanden_GB.Severity.Disabledexpectations, and paused/indicator behavior.Written by Cursor Bugbot for commit 5b3d867. This will update automatically on new commits. Configure here.