fix: handle non-standard semver formats in BIP-44 banner check

[fabiobozzo]

Description

Fixes a critical bug where the extension crashes on startup due to invalid semver version comparison.

See: https://consensys.slack.com/archives/CTQAGKY5V/p1762443107241399

Problem

Extension versions can be non-standard formats like 13.9.0.150 (4-part versions), which causes semver.lt() to throw:

TypeError: Invalid Version: 13.9.0.150

This crashes the extension on startup for users upgrading from these version formats.

Solution

• Use semver.coerce() to normalize versions before comparison (e.g., 13.9.0.150 → 13.9.0)
• Add try/catch error handling for graceful fallback
• Add test cases for 4-part version formats

Test Coverage

• ✅ Handles 13.9.0.150 → coerces to 13.9.0 → compares safely
• ✅ Handles 13.4.0.100 → coerces to 13.4.0 → compares safely
• ✅ Graceful fallback on unparseable versions

Changelog

CHANGELOG entry: null

Related issues

Follow-up: https://github.com/MetaMask/metamask-extension/pull/37324/files

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Coerces extension version strings before semver comparison to avoid crashes and ensure correct BIP-44 intro modal behavior, with new tests for 4-part versions.

• Hook (ui/hooks/useMultichainAccountsIntroModal.ts):
  • Use semver.coerce with try/catch to normalize lastUpdatedFromVersion before semverLt for isUpgradeFromLowerThanBip44Version.
  • Keeps modal gating logic unchanged; only improves version parsing robustness.
• Tests (ui/hooks/useMultichainAccountsIntroModal.test.ts):
  • Mirror hook logic using semver.coerce.
  • Add cases for non-standard versions like 13.9.0.150 (no banner) and 13.4.0.100 (shows banner).

^{Written by Cursor Bugbot for commit f28f155. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [8c10bf5]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1218 ± 85 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1218	1073	1425	85	1263	1388
			load	1050	922	1282	80	1110	1189
			domContentLoaded	1043	919	1276	80	1103	1179
			domInteractive	21	14	86	13	18	59
			firstPaint	578	89	1230	405	1038	1169
			backgroundConnect	231	219	348	13	233	241
			firstReactRender	25	18	47	6	28	35
			getState	22	6	62	10	26	44
			initialActions	0	0	1	0	0	1
			loadScripts	819	693	1048	79	877	957
			setupStore	10	4	28	3	11	16
			numNetworkReqs	13	6	74	19	6	71
	Browserify	Power User Home	uiStartup	1992	1747	2586	267	2180	2586
			load	1047	903	1453	196	1337	1453
			domContentLoaded	1040	896	1427	193	1328	1427
			domInteractive	28	15	69	18	47	69
			firstPaint	613	94	1472	490	967	1472
			backgroundConnect	246	227	388	38	250	388
			firstReactRender	30	25	59	8	32	59
			getState	182	163	220	16	193	220
			initialActions	0	0	1	0	1	1
			loadScripts	803	671	1129	174	1076	1129
			setupStore	14	9	32	8	14	32
			numNetworkReqs	120	73	248	60	164	248
	Webpack	Standard Home	uiStartup	867	732	1213	95	877	1113
			load	628	576	991	85	622	885
			domContentLoaded	621	571	973	81	614	859
			domInteractive	17	12	71	11	15	49
			firstPaint	198	61	976	202	175	850
			backgroundConnect	26	12	74	14	28	57
			firstReactRender	33	19	228	22	36	55
			getState	11	6	24	3	13	15
			initialActions	0	0	1	0	0	1
			loadScripts	618	569	963	79	612	848
			setupStore	13	6	37	5	14	24
			numNetworkReqs	13	6	71	19	8	69
	Webpack	Power User Home	uiStartup	1153	1068	1573	145	1291	1573
			load	568	514	771	77	659	771
			domContentLoaded	551	504	741	70	622	741
			domInteractive	22	12	78	18	38	78
			firstPaint	204	65	626	146	250	626
			backgroundConnect	70	16	240	76	173	240
			firstReactRender	25	23	27	1	26	27
			getState	131	86	146	20	142	146
			initialActions	0	0	1	0	0	1
			loadScripts	548	502	733	67	615	733
			setupStore	9	5	24	6	10	24
			numNetworkReqs	107	67	166	41	162	166
Firefox	Browserify	Standard Home	uiStartup	1527	1324	2099	141	1604	1827
			load	1292	1129	1584	102	1362	1490
			domContentLoaded	1292	1129	1584	102	1362	1490
			domInteractive	119	34	347	51	130	208
			firstPaint	-	-	-	-	-	-
			backgroundConnect	52	24	198	31	55	115
			firstReactRender	27	22	60	6	27	40
			getState	8	4	35	5	7	22
			initialActions	0	0	2	0	1	1
			loadScripts	1260	1099	1556	99	1324	1460
			setupStore	14	7	115	13	14	39
			numNetworkReqs	13	6	74	16	7	61
	Browserify	Power User Home	uiStartup	2401	2113	3006	286	2591	3006
			load	1351	1109	1692	209	1622	1692
			domContentLoaded	1350	1109	1692	209	1622	1692
			domInteractive	211	52	594	178	458	594
			firstPaint	-	-	-	-	-	-
			backgroundConnect	96	29	250	73	190	250
			firstReactRender	35	29	50	7	37	50
			getState	142	76	269	43	156	269
			initialActions	1	0	2	1	1	2
			loadScripts	1321	1092	1672	204	1582	1672
			setupStore	30	6	133	36	42	133
			numNetworkReqs	133	69	231	64	214	231
	Webpack	Standard Home	uiStartup	2150	1828	2698	180	2225	2587
			load	1830	1487	2237	146	1906	2160
			domContentLoaded	1829	1487	2236	146	1905	2159
			domInteractive	130	42	686	91	129	285
			firstPaint	-	-	-	-	-	-
			backgroundConnect	78	30	349	54	79	200
			firstReactRender	41	27	128	19	39	111
			getState	13	6	242	24	12	29
			initialActions	0	0	1	0	1	1
			loadScripts	1779	1395	2189	154	1866	2117
			setupStore	19	9	107	14	19	43
			numNetworkReqs	13	6	66	17	7	65
	Webpack	Power User Home	uiStartup	2556	2218	3218	303	2789	3218
			load	1525	1290	1934	231	1810	1934
			domContentLoaded	1524	1289	1933	231	1809	1933
			domInteractive	204	37	626	180	378	626
			firstPaint	-	-	-	-	-	-
			backgroundConnect	98	38	215	63	192	215
			firstReactRender	41	29	59	10	56	59
			getState	154	72	356	66	183	356
			initialActions	1	0	5	1	1	5
			loadScripts	1493	1269	1903	226	1749	1903
			setupStore	29	9	90	26	36	90
			numNetworkReqs	131	57	247	66	196	247

📊 Page Load Benchmark Results

Current Commit: 8c10bf5 | Date: 11/6/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
• domContentLoaded-> current mean value: 724ms (±37ms) 🟢 | historical mean value: 733ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.02s	1.33s	1.06s	1.33s
domContentLoaded	724ms	37ms	703ms	995ms	737ms	995ms
firstPaint	76ms	11ms	60ms	172ms	84ms	172ms
firstContentfulPaint	76ms	11ms	60ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: 64 Bytes (0%)
• common: 20 Bytes (0%)