fix: shield plan token approval amount incorrect when plan change #37585
+88
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| getAvailableTokenBalances(); | ||
| }, [price, productType, paymentChainTokenMap, validTokenBalances]); | ||
| return availableTokens; | ||
| }, [price, paymentChainTokenMap, validTokenBalances]); |
There was a problem hiding this comment.
Bug: Stale Data from Missing Dependency in Async Call
Missing productType in the useAsyncResult dependency array. The async function uses productType on line 125 (getSubscriptionCryptoApprovalAmount call), but it's not included in the dependency array on line 160. The old code (using useEffect) had productType in its dependencies. Without it, if productType changes, the async function won't re-execute with the new value, leading to stale data being used for approval amount calculations.
Collaborator
Builds ready [50a1e6e]
UI Startup Metrics (1205 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [f31aec5]
UI Startup Metrics (1206 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously in shield plan screen, when user change plan, the selected token approval amount didn't get updated hence user will see outdated approval amount in the confirmation screen
This PR reset the selected token when plan change to get correct latest approval amount
Changelog
CHANGELOG entry: fix incorrect token approval amount when change shield plan
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors token balance hook to return {availableTokenBalances, pending, error} and updates Shield Plan to await balances and reset selected token on plan change, ensuring approval amounts reflect the selected plan.
useAvailableTokenBalances{ availableTokenBalances, pending, error }instead of just an array.useAsyncResultfor fetching approval amounts.price/token map by returning empty results; logs when token info is absent.pendingfromuseAvailableTokenBalancesand delays token selection until ready.selectedTokenwhenselectedPlanchanges.Written by Cursor Bugbot for commit f31aec5. This will update automatically on new commits. Configure here.