refactor(556x): migrate unlock, deeplink, defi page to react-router-dom-v5-compat #37586
+371
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDDDDanica
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Migration break: use navigate instead of history.replace
The onResetWallet method references this.props.history.replace(DEFAULT_ROUTE) on line 472, but the history prop was removed and replaced with navigate in this migration. This will cause a runtime error when the method is invoked. It should be changed to this.props.navigate(DEFAULT_ROUTE, { replace: true }).
ui/pages/unlock-page/unlock-page.component.js#L467-L473
metamask-extension/ui/pages/unlock-page/unlock-page.component.js
Lines 467 to 473 in 7a79714
DDDDDanica
force-pushed
the
refactor/unlock-deep-defi-v5-compat
branch
2 times, most recently
from
e8431e9 to
ac5edda
Compare
Collaborator
Builds ready [6503e55]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| </Router>, | ||
| <UnlockPage forceUpdateMetamaskState={mockForceUpdateMetamaskState} />, | ||
| store, | ||
| { pathname }, |
There was a problem hiding this comment.
Bug: Duplicate Test Names Confuse Test Runner
Duplicate test case with identical name should show login error modal when authentication error is thrown exists at lines 258-297 and 299-335. The tests have the same name and nearly identical implementation, which will cause test runner confusion and makes one test unreachable.
DDDDDanica
force-pushed
the
refactor/unlock-deep-defi-v5-compat
branch
from
aef7c41 to
47ba5a0
Compare
| /> | ||
| )} | ||
| /> | ||
| ); |
There was a problem hiding this comment.
Bug: Nested Routes Created by Authenticated HOC Wrapping
Nested Route components created by wrapping Authenticated inside a Route render prop. The Authenticated HOC returns a Route component when authenticated, creating a Route inside a Route. This should use AuthenticatedV5Compat instead, which returns children directly without wrapping in a Route, or the outer Route render prop should be removed.
ui/pages/routes/routes.component.tsx
Outdated
| params={match.params} | ||
| /> | ||
| )} | ||
| /> |
There was a problem hiding this comment.
Bug: Nested Routes Created by Authenticated Wrapper
Nested Route components created by wrapping Authenticated inside a Route render prop. The Authenticated HOC returns a Route component when authenticated, creating a Route inside a Route. This should use AuthenticatedV5Compat instead, which returns children directly without wrapping in a Route, or the outer Route render prop should be removed.
Collaborator
Builds ready [47ba5a0]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [33daab7]
UI Startup Metrics (1166 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/unlock-deep-defi-v5-compat
branch
from
d68edca to
0f8e39b
Compare
Collaborator
Builds ready [0f8e39b]
UI Startup Metrics (1265 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate migrate unlock, deeplink, defi page and MetaMetricsContext to
react-router-dom-v5-compatChangelog
CHANGELOG entry: null
Related issues
Fixes: part of https://github.com/MetaMask/MetaMask-planning/issues/3261
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Migrates multiple pages to react-router-dom-v5-compat, adds InitializedV5Compat, adapts routing to pass navigate/params, updates MetaMetrics page matching, and refreshes tests/stories accordingly.
react-router-dom-v5-compatacross pages; useNavigateinstead ofRedirect.ui/pages/routes/routes.component.tsx, bridge v5historyto v5-compatnavigateviacreateV5CompatNavigate, render components via Route children, and passnavigate/params/locationas needed. RenderToastMasterwith explicitlocationprop.InitializedV5CompatHOC to guard routes needing onboarding completion.ui/contexts/metametrics.js, switch toreact-router-dom-v5-compatand loopgetPaths()withmatchPath(v6-style signature) to find the first match for page tracking.ui/pages/unlock-page/*: Replacehistorywithnavigate; read redirect fromlocation.state.fromornavState.from; containers usewithRouterHooksanduseNavState; docs/stories updated.ui/pages/deep-link/deep-link.tsx: Acceptlocationvia props (from Route) instead ofuseLocation.ui/pages/defi/components/defi-details-page.tsx: Acceptnavigate/params; replaceRedirect/history.pushwithNavigate/navigate.ui/pages/keychains/reveal-seed.js: Acceptnavigate/keyringId; replacehistory.goBackwithnavigate(-1); add PropTypes.ui/pages/lock/*: Usenavigate(+withRouterHooks) in component/container.render-helpers-navigate, mockreact-router-dom-v5-compathooks, pass new props (navigate,params,location), and adjust snapshots/behaviors accordingly.Written by Cursor Bugbot for commit 0f8e39b. This will update automatically on new commits. Configure here.