Skip to content

Conversation

@lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Nov 6, 2025

Description

Add fullscreen view for shield entry modal

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-web3auth Web3Auth team label Nov 6, 2025
@github-actions github-actions bot added the size-M label Nov 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [618c948]
UI Startup Metrics (1229 ± 103 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12291056171310312771407
load105991814939611151220
domContentLoaded105291214839511091215
domInteractive221481132060
firstPaint662152151241910521194
backgroundConnect23121434214234244
firstReactRender27205572943
getState2075682339
initialActions001001
loadScripts829699123492883988
setupStore1173541218
numNetworkReqs1367620672
BrowserifyPower User HomeuiStartup19931779290929321492909
load1054916162420712891624
domContentLoaded1046910161120512781611
domInteractive301577205577
firstPaint6019516184799611618
backgroundConnect24322631219244312
firstReactRender28244142841
getState18115921118205211
initialActions001011
loadScripts813681131019310491310
setupStore1492861628
numNetworkReqs1197524765167247
WebpackStandard HomeuiStartup7706451083837751020
load55450586677545797
domContentLoaded54649984774539782
domInteractive15115581438
firstPaint21853858210179771
backgroundConnect251074132855
firstReactRender27173873235
getState1051731215
initialActions001001
loadScripts54449784073537774
setupStore1152941216
numNetworkReqs1467820874
WebpackPower User HomeuiStartup12441132170813612981708
load643559930115789930
domContentLoaded623550899103722899
domInteractive261270214970
firstPaint314119905216563905
backgroundConnect58172305892230
firstReactRender26242812728
getState14310416219153162
initialActions001001
loadScripts619548889100712889
setupStore96265926
numNetworkReqs1077016939164169
FirefoxBrowserifyStandard HomeuiStartup14851292199112815291791
load1256110815808813081426
domContentLoaded1256110815808813071426
domInteractive1173532455119238
firstPaint------
backgroundConnect4627146205188
firstReactRender26214742735
getState10419020717
initialActions001001
loadScripts1227108315598312821374
setupStore157196201435
numNetworkReqs1266915758
BrowserifyPower User HomeuiStartup24472052302729226873027
load13691183187124115981871
domContentLoaded13691183187024115981870
domInteractive20973610185432610
firstPaint------
backgroundConnect14037523143206523
firstReactRender453185155585
getState1336919534160195
initialActions106116
loadScripts13061158182120715421821
setupStore24777193677
numNetworkReqs1316922059189220
WebpackStandard HomeuiStartup16181394218714516661930
load13851209166210314661605
domContentLoaded13851209166210314661604
domInteractive1033135044112186
firstPaint------
backgroundConnect49262543057111
firstReactRender302280113149
getState10318620732
initialActions001001
loadScripts1354119016159914381553
setupStore15680141455
numNetworkReqs1366817766
WebpackPower User HomeuiStartup26062191355340528173553
load15331281203623817912036
domContentLoaded15321281203623817902036
domInteractive19837711197393711
firstPaint------
backgroundConnect904220952138209
firstReactRender39295384853
getState1448522342191223
initialActions101011
loadScripts15011245200023517462000
setupStore37101633956163
numNetworkReqs1336430979228309
📊 Page Load Benchmark Results

Current Commit: 618c948 | Date: 11/6/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±45ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±40ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 45ms 1.02s 1.35s 1.09s 1.35s
domContentLoaded 737ms 40ms 704ms 1.00s 776ms 1.00s
firstPaint 79ms 13ms 60ms 188ms 92ms 188ms
firstContentfulPaint 79ms 13ms 60ms 188ms 92ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 70 Bytes (0%)
  • common: -39 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants