feat: claims-controller integration #37597
Draft
+532
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (5 files, +35 -0)
📜 @MetaMask/policy-reviewers (5 files, +35 -0)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +35 -0)
|
Collaborator
Builds ready [e9c3d5d]
UI Startup Metrics (1223 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| (claim: Claim) => { | ||
| // add leading zero to claim number if it is less than 1000 | ||
| const claimNumber = claim.claimNumber.toString().padStart(3, '0'); | ||
| const claimNumber = claim.id.toString().padStart(3, '0'); |
Contributor
There was a problem hiding this comment.
did you change the id to be a counter on claims ctrl? because the id is too long to show on UI eg. 05fa245a-1a4d-427a-b4bb-c8d409c05c38
we want to show it like Claims #1... on UI.
Contributor
Author
There was a problem hiding this comment.
okie. Then we can use shortId I guess.
…on' into feat/claims-controller-integration
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
Builds ready [de391d5]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [5fb972b]
UI Startup Metrics (1230 ± 109 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Builds ready [bf156d9]
UI Startup Metrics (1250 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hieu-w
reviewed
Nov 7, 2025
| headers: { | ||
| Authorization: `Bearer ${accessToken}`, | ||
| }, | ||
| headers, |
There was a problem hiding this comment.
@lwin-kyaw : for multipart request, manually setting Content-Type: multipart/form-data without including boundary led to error "missing boundary" when fetch. You must remove "Content-Type: multipart/form-data" at controller or override it here and let browser add it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates
@metamask/claims-controllerinto extension and added SIWE signature generation for the claim.Changelog
CHANGELOG entry: Added
@metamask/claims-controllerfor shield claimsCHANGELOG entry: Added Claim Signature Generation.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist