release(runway): cherry-pick fix: stop reloading of animation & browser back option cp-13.9.0 #37603
+68
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er back option cp-13.9.0 (#37581) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> In this PR, we have added the logic to stop the animation once completed. Also added a browser back logic for login options. Jira Link: https://consensyssoftware.atlassian.net/browse/SL-278 [](https://codespaces.new/MetaMask/metamask-extension/pull/37581?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: stopped reloading of animation once completed ## **Related issues** Fixes: ## **Manual testing steps** 1. Open Extension 2. validate animation reloading 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/7c01d5bc-2aeb-4591-84e6-c359e73a71c1 https://github.com/user-attachments/assets/1ccacae4-1aec-4fbd-b170-e879e54970b5 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Persists Rive animation completion to skip replays, switches welcome flow to context-based skipping, and syncs login option visibility via the `?login` query param; updates navigation and tests. > > - **Onboarding animations**: > - Add `animationCompleted` map and `setIsAnimationCompleted` to `RiveWasmContext` (`ui/contexts/rive-wasm/index.tsx`). > - `MetamaskWordMarkAnimation` sets completion on unmount and consumes the new setter; updates effect deps (`ui/pages/onboarding-flow/welcome/metamask-wordmark-animation.tsx`). > - `welcome` uses `animationCompleted.MetamaskWordMarkAnimation` to decide `shouldSkipAnimation` (replaces URL-based check) (`ui/pages/onboarding-flow/welcome/welcome.js`). > - **Login flow URL syncing**: > - `WelcomeLogin` reads `?login=` to control option view and writes it on selection via `navigate` (`ui/pages/onboarding-flow/welcome/welcome-login.tsx`). > - **Navigation adjustments**: > - `AccountExist` returns to `ONBOARDING_WELCOME_ROUTE` without `?from=...`; tests updated accordingly (`ui/pages/onboarding-flow/account-exist/*`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 709317b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (5 files, +37 -15)
|
Collaborator
Builds ready [d90dcf6]
UI Startup Metrics (1204 ± 81 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
gauthierpetetin
approved these changes
Nov 7, 2025
Contributor
|
@metamaskbot update-attributions |
Collaborator
|
No attributions changes |
gauthierpetetin
approved these changes
Nov 7, 2025
Collaborator
Builds ready [29c4558]
UI Startup Metrics (1213 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
metamaskbot
added
the
release-13.9.0
Collaborator
|
No release label on PR. Adding release label release-13.9.0 on PR, as PR was cherry-picked in branch 13.9.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/37581?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we have added the logic to stop the animation once
completed. Also added a browser back logic for login options.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-278
Changelog
CHANGELOG entry: stopped reloading of animation once completed
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-11-06.at.8.16.37.PM.mov
Screen.Recording.2025-11-06.at.11.00.34.PM.mov
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Persist animation completion in shared context to prevent replay, and use URL params for login option state to support browser back; update navigation and tests accordingly.
ui/contexts/rive-wasmwithanimationCompletedmap andsetIsAnimationCompleted(...)to persist completion state across views.metamask-wordmark-animation.tsxto mark completion on unmount and consume the new context API.welcome.js: deriveshouldSkipAnimationfromanimationCompleted.MetamaskWordMarkAnimation(replacing priorfromquery logic) to avoid replaying the wordmark animation.welcome-login.tsx: read/write?login=<option>to controlLoginOptionsvisibility/selection and navigate viaONBOARDING_WELCOME_ROUTEto enable browser back restoring state.ONBOARDING_WELCOME_ROUTE(remove?from=account-exist).account-exist.test.tsxexpectations to match new welcome route navigation without query params.Written by Cursor Bugbot for commit 29c4558. This will update automatically on new commits. Configure here.
4e1f85a