feat: show shield entry modal on settings #37606
Open
+43
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (key === TRANSACTION_SHIELD_ROUTE && !hasShieldSubscription) { | ||
| this.setState({ showShieldEntryModal: true }); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Bug: Shield Subscription Status Blocks Access Modal
The condition !hasShieldSubscription prevents the modal from showing for users with paused, cancelled, or past_due subscriptions. Since getHasShieldSubscription returns true for any subscription regardless of status, users with inactive subscriptions won't see the entry modal but also can't access the Transaction Shield page, leaving them unable to manage their subscription.
Contributor
Author
There was a problem hiding this comment.
User with existing shield subscription should redirect to Transaction Shield page. We have different UI inside Transaction Shield page to show those states
Collaborator
Builds ready [7a1fc95]
UI Startup Metrics (1223 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
approved these changes
Nov 7, 2025
| } | ||
|
|
||
| export function getHasShieldSubscription(state: SubscriptionState): boolean { | ||
| const shieldSubscription = getShieldSubscription( |
Member
There was a problem hiding this comment.
is this logic right @tuna1207 @lwin-kyaw
we don't wanna show the modal if the user has subscribed to shield atleast once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If user has no shield subscription and click on Settings > Transaction Shield, show
Shield entry modalinstead of redirecting toShield planpage.On this case, Shield entry modal is just a normal modal and does not affect existing conditions on showing the entry modal.
Changelog
CHANGELOG entry: Add Shield entry modal to settings page
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
User without Shield subscription
settings-shield-modal.mov
Subscribed user
settings-shield-has-subs.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Cursor Bugbot is generating a summary for commit 7a1fc95. Configure here.