-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: Fix send flow design defects #37613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OGPoyraz
wants to merge
3
commits into
main
Choose a base branch
from
ogp/6057
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+30
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (9 files, +30 -10)
|
Collaborator
Builds ready [6e82ef9]
UI Startup Metrics (1256 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [3a317a0]
UI Startup Metrics (1227 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address multiple design defects in send flow.
Changelog
CHANGELOG entry: Fix design defects and show all native assets regardless of balance in send flow
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6057
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6059
Fixes: #36195
Fixes: #36201
Fixes: #37609
Manual testing steps
See individual tasks
Screenshots/Recordings
Before
After
Sticky header

Long account / contact name

Removed space from fiat

Include all native assets regardless of the balance

Pre-merge author checklist
Pre-merge reviewer checklist
Note
Makes the send header sticky, truncates long recipient names, removes the space between currency symbol and amount, and shows native assets even with zero balance.
.redesigned__send__sticky-header) and scrollable content wrapper (.redesigned__send__content-wrapper).style: height: '100%') inamount-recipient.tsxandasset.tsx.send-recipient__contentwith flex/min-width and applyellipsisto name to prevent overflow.useCurrencyConversionsand update test expectations.useSendTokens.Written by Cursor Bugbot for commit 3a317a0. This will update automatically on new commits. Configure here.