Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 7, 2025

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@FrederikBolding FrederikBolding added the DO-NOT-MERGE Pull requests that should not be merged label Nov 7, 2025
@metamaskbot metamaskbot added the team-core-platform Core Platform team label Nov 7, 2025
@github-actions github-actions bot added the size-M label Nov 7, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 7, 2025

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (2 files, +30 -1)
  • 📁 app/
    • 📁 scripts/
      • 📁 controller-init/
        • 📁 messengers/
          • 📁 snaps/
            • 📄 snap-controller-messenger.ts +6 -1
        • 📁 snaps/
          • 📄 snap-controller-init.ts +24 -0

@metamaskbot
Copy link
Collaborator

Builds ready [938a6ef]
UI Startup Metrics (1239 ± 96 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1239106714859613041429
load106592413148611281215
domContentLoaded105891513038611171210
domInteractive221578141960
firstPaint654152131942610961187
backgroundConnect2232072609230240
firstReactRender25184572939
getState2285782541
initialActions004001
loadScripts841710108184898984
setupStore1173041221
numNetworkReqs1367620674
BrowserifyPower User HomeuiStartup19111732236021621742360
load1009904132715311811327
domContentLoaded1002897132015211721320
domInteractive281474215074
firstPaint60417313163859321316
backgroundConnect2322192456235245
firstReactRender29255773157
getState17115522217187222
initialActions001011
loadScripts77866810911509451091
setupStore171045102645
numNetworkReqs1187124563173245
WebpackStandard HomeuiStartup82970215711098311022
load6085551359100598791
domContentLoaded601550134697592764
domInteractive16125981438
firstPaint19458912190187725
backgroundConnect241169142655
firstReactRender3017182173441
getState1162731216
initialActions001001
loadScripts598548133595590754
setupStore1254661327
numNetworkReqs1367319871
WebpackPower User HomeuiStartup12781146179619312711796
load651574916115748916
domContentLoaded635561875106710875
domInteractive241365174665
firstPaint43475879274592879
backgroundConnect591021968139219
firstReactRender26252812728
getState1429517024156170
initialActions001001
loadScripts630559865103700865
setupStore106276827
numNetworkReqs1117122447165224
FirefoxBrowserifyStandard HomeuiStartup14541289202012815171683
load1235109214708313051386
domContentLoaded1235109114708313051386
domInteractive1193438258119284
firstPaint------
backgroundConnect4425239255282
firstReactRender25214642628
getState74608713
initialActions002001
loadScripts1210107514427912701359
setupStore1274871228
numNetworkReqs1266114752
BrowserifyPower User HomeuiStartup23772090310428524423104
load13701144189921715761899
domContentLoaded13701143189821615761898
domInteractive20162697178310697
firstPaint------
backgroundConnect953620055159200
firstReactRender403176114176
getState1267818732160187
initialActions001011
loadScripts13401116185621215511856
setupStore2951203443120
numNetworkReqs1317123961207239
WebpackStandard HomeuiStartup15811392221414616301936
load13521196167410013991559
domContentLoaded13521195167410013981558
domInteractive1042939146110190
firstPaint------
backgroundConnect4422128214985
firstReactRender292278102946
getState74658713
initialActions001001
loadScripts1325117916229113801496
setupStore155144181356
numNetworkReqs1366616764
WebpackPower User HomeuiStartup25902187322730027263227
load15711278197123118411971
domContentLoaded15711277197023118411970
domInteractive20437710199379710
firstPaint------
backgroundConnect913022157140221
firstReactRender43325874958
getState1487834268172342
initialActions101011
loadScripts15331259194122117821941
setupStore22454173754
numNetworkReqs1336932482197324
📊 Page Load Benchmark Results

Current Commit: 938a6ef | Date: 11/7/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±51ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±49ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 51ms 1.00s 1.30s 1.08s 1.30s
domContentLoaded 719ms 49ms 691ms 989ms 742ms 989ms
firstPaint 76ms 11ms 56ms 160ms 88ms 160ms
firstContentfulPaint 76ms 11ms 56ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 469 Bytes (0.01%)
  • ui: 0 Bytes (0%)
  • common: 131 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE Pull requests that should not be merged size-M team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants