Skip to content

Conversation

@ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Nov 7, 2025

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Nov 7, 2025
@github-actions github-actions bot added the size-M label Nov 7, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 7, 2025

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (8 files, +227 -16)
  • 📁 ui/
    • 📁 ducks/
      • 📁 bridge/
        • 📄 selectors.test.ts +2 -2
        • 📄 selectors.ts +109 -1
    • 📁 pages/
      • 📁 bridge/
        • 📁 hooks/
          • 📄 useExternalAccountResolution.ts +13 -1
          • 📄 useSubmitBridgeTransaction.ts +17 -2
        • 📁 prepare/
          • 📁 components/
            • 📄 destination-account-list-item.tsx +22 -3
            • 📄 destination-account-picker-modal.tsx +20 -0
            • 📄 prepare-bridge-page.tsx +21 -4
          • 📄 index.tsx +23 -3

@metamaskbot
Copy link
Collaborator

Builds ready [21ee864]
UI Startup Metrics (1248 ± 93 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1248109516319313121394
load107694413608511331212
domContentLoaded106993913548511261206
domInteractive221483141869
firstPaint69190128742210791178
backgroundConnect2342222729238251
firstReactRender27184982847
getState2284992645
initialActions002001
loadScripts842714111885900988
setupStore1172841222
numNetworkReqs1367719670
BrowserifyPower User HomeuiStartup18781717233420520192334
load1003894127114912501271
domContentLoaded996887125714712441257
domInteractive281581204181
firstPaint4809912993649241299
backgroundConnect2342222579240257
firstReactRender26252912829
getState17615621516188215
initialActions001011
loadScripts76966410261439941026
setupStore1192641126
numNetworkReqs1207025469171254
WebpackStandard HomeuiStartup8257071137868311054
load60455991573604814
domContentLoaded59755390071599803
domInteractive16125391437
firstPaint19360903191176609
backgroundConnect231172132357
firstReactRender2918114113437
getState1152741316
initialActions001001
loadScripts59455088969597793
setupStore1143351318
numNetworkReqs1367319669
WebpackPower User HomeuiStartup12621146169316313151693
load667582974134820974
domContentLoaded643569881108795881
domInteractive251289223889
firstPaint39175885283579885
backgroundConnect59102776973277
firstReactRender27232912829
getState1419716221156162
initialActions001011
loadScripts638567871104785871
setupStore1062861028
numNetworkReqs1096722546159225
FirefoxBrowserifyStandard HomeuiStartup15231295187610615711753
load1282112014967913371451
domContentLoaded1282112014957913361451
domInteractive1113639558111231
firstPaint------
backgroundConnect4526113165473
firstReactRender28226262944
getState10411614822
initialActions001001
loadScripts1256110214637613021423
setupStore1486671430
numNetworkReqs1267015856
BrowserifyPower User HomeuiStartup24832162315331226853153
load13901164191125515591911
domContentLoaded13891164191025515591910
domInteractive18782633166339633
firstPaint------
backgroundConnect11832396114150396
firstReactRender463279115079
getState1238216827160168
initialActions102112
loadScripts13531145186324815141863
setupStore28779224879
numNetworkReqs1326921359207213
WebpackStandard HomeuiStartup16731479244715717191987
load14151215178510414591632
domContentLoaded14151215178510414581632
domInteractive1003436340115162
firstPaint------
backgroundConnect52261592556117
firstReactRender3524118163377
getState12419624827
initialActions002001
loadScripts1380119616969514251592
setupStore15875101436
numNetworkReqs1367318765
WebpackPower User HomeuiStartup24582165306229427333062
load14721253180018416231800
domContentLoaded14711253180018516231800
domInteractive17472481119271481
firstPaint------
backgroundConnect1022932379173323
firstReactRender402973114873
getState1127017630126176
initialActions001011
loadScripts14341232176417916001764
setupStore4151854767185
numNetworkReqs1235631979162319
📊 Page Load Benchmark Results

Current Commit: 21ee864 | Date: 11/7/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±54ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±51ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±17ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 54ms 1.01s 1.38s 1.07s 1.38s
domContentLoaded 727ms 51ms 700ms 1.03s 747ms 1.03s
firstPaint 77ms 17ms 60ms 232ms 88ms 232ms
firstContentfulPaint 77ms 17ms 60ms 232ms 88ms 232ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-M team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants