chore: Improve Mock Segment Server to Print Event Properties #37635

owencraston · 2025-11-07T22:44:55Z

Description

What is the reason for the change?

Properties within segment events are just as important as the events themselves these days. Properties are used to deduplicate events with more details and are often more difficult to test than the mere event.
Printing the properties by default will make event testing much easier to debug.
This server also did not support logging Identify events which are fired when updating the user properties, logging these make it easier to debug when these properties are updated.

What is the improvement/solution?

Pretty print event properties that are fired with the events.
This is a developer facing change and will have no impact on users.
Add support for event type === identify

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

checkout this branch
follow these exact steps: https://github.com/MetaMask/metamask-extension/blob/main/development/README.md#segment
Notice that there are now properties being logged with each event.

Screenshots/Recordings

Before

// Identify event (not supported)

[mock-segment]: Events received: [Unrecognized event type: identify]
[mock-segment]: POST /v1/batch

[mock-segment]: Events received: Account Menu Opened
[mock-segment]: POST /v1/batch
[mock-segment]: Events received: Account List Page
[mock-segment]: POST /v1/batch
[mock-segment]: Events received: Import Secret Recovery Phrase Page
[mock-segment]: POST /v1/batch
[mock-segment]: Events received: Home
[mock-segment]: POST /v1/batch
[mock-segment]: Events received: DeFi Stats
[mock-segment]: POST /v1/batch
[mock-segment]: Events received: [Unrecognized event type: identify]
...

[mock-segment]: Events received: [Unrecognized event type: identify]
[mock-segment]: POST /v1/batch
[mock-segment]: Events received: Port Stream Chunked
[mock-segment]: POST /v1/batch
[mock-segment]: Events received: Import Secret Recovery Phrase Completed

After

// Identify event

[mock-segment]: Identify event received: 0x51c51cdfc644de86d3df8f612e349787cfd279e485ba472bc59c6a50d18b11f0
{
  "address_book_entries": 12,
  "number_of_accounts": 36,
  "petname_addresses_count": 12
}

// Importing a new wallet

[mock-segment]: Track event received: Account Menu Opened
{
  "location": "Home",
  "category": "Navigation",
  "locale": "en",
  "chain_id": "0xaa36a7",
  "environment_type": "popup"
}
[mock-segment]: Page event received: Account List Page
{
  "params": {},
  "locale": "en",
  "chain_id": "0xaa36a7",
  "environment_type": "popup"
}
[mock-segment]: Page event received: Import Secret Recovery Phrase Page
{
  "params": {},
  "locale": "en",
  "chain_id": "0xaa36a7",
  "environment_type": "popup"
}
[mock-segment]: Page event received: Home
{
  "params": {},
  "locale": "en",
  "chain_id": "0xaa36a7",
  "environment_type": "popup"
}
[mock-segment]: Identify event received: 0x51c51cdfc644de86d3df8f612e349787cfd279e485ba472bc59c6a50d18b11f0
{
  "address_book_entries": 2,
  "number_of_accounts": 4,
  "number_of_hd_entropies": 2,
  "petname_addresses_count": 2
}
[mock-segment]: Track event received: DeFi Stats
{
  "totalMarketValueUSD": 0,
  "totalPositions": 0,
  "breakdown": [],
  "category": "DeFi",
  "locale": "en",
  "chain_id": "0xaa36a7",
  "environment_type": "background"
}
[mock-segment]: Track event received: Profile Activity Updated
{
  "event": {
    "feature_name": "Multichain Account Syncing",
    "action": "group_added",
    "profile_id": "4796375c-f5f1-4868-a761-6ff84eab8bad"
  },
  "category": "Backup And Sync",
  "locale": "en",
  "chain_id": "0xaa36a7",
  "environment_type": "background"
}

.....

[mock-segment]: Track event received: Import Secret Recovery Phrase Completed
{
  "hd_entropy_index": 1,
  "number_of_solana_accounts_discovered": 0,
  "number_of_bitcoin_accounts_discovered": 0,
  "locale": "en",
  "chain_id": "0xaa36a7",
  "environment_type": "background"
}

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Improves development/mock-segment.js to log each Segment event with type, name/id, and pretty-printed properties, adding support for identify events.

Mock Segment Server (development/mock-segment.js):
- Logs each event individually with type labels (Track, Page, Identify) and name/id.
- Pretty-prints event data: uses event.properties for non-identify and event.traits for identify.
- Adds support for identify events and handles unknown types gracefully.
- Simplifies output by removing request URL/method and aggregate "Events received" summary.

^{Written by Cursor Bugbot for commit a3d1061. This will update automatically on new commits. Configure here.}

github-actions · 2025-11-07T22:45:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

development/mock-segment.js

metamaskbot · 2025-11-07T23:44:56Z

Builds ready [a5f0a5a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 89 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1209	1059	1418	89	1281	1363
			load	1041	927	1222	80	1101	1187
			domContentLoaded	1035	921	1208	79	1096	1181
			domInteractive	21	14	75	12	18	59
			firstPaint	615	88	1249	407	1009	1187
			backgroundConnect	229	215	256	7	232	242
			firstReactRender	27	17	47	7	29	43
			getState	21	6	55	10	27	42
			initialActions	0	0	1	0	0	1
			loadScripts	812	703	983	79	876	957
			setupStore	11	6	31	4	13	18
			numNetworkReqs	13	6	76	20	6	71
	Browserify	Power User Home	uiStartup	1959	1739	2594	295	2234	2594
			load	1035	900	1468	186	1308	1468
			domContentLoaded	1025	893	1453	183	1286	1453
			domInteractive	28	16	70	18	48	70
			firstPaint	597	153	1323	407	933	1323
			backgroundConnect	248	224	370	33	251	370
			firstReactRender	28	26	34	2	28	34
			getState	177	151	250	23	185	250
			initialActions	0	0	1	0	0	1
			loadScripts	789	676	1097	162	1052	1097
			setupStore	11	10	16	2	11	16
			numNetworkReqs	119	74	250	65	159	250
	Webpack	Standard Home	uiStartup	827	709	1194	90	832	1079
			load	607	554	954	83	603	845
			domContentLoaded	600	550	937	80	598	834
			domInteractive	16	12	57	10	14	40
			firstPaint	219	58	930	210	206	606
			backgroundConnect	24	12	73	13	25	56
			firstReactRender	29	18	98	10	34	37
			getState	11	6	31	4	12	16
			initialActions	0	0	1	0	0	1
			loadScripts	597	548	927	78	596	824
			setupStore	11	6	29	4	12	19
			numNetworkReqs	13	6	74	19	8	70
	Webpack	Power User Home	uiStartup	1295	1158	1773	166	1394	1773
			load	670	581	936	119	737	936
			domContentLoaded	650	571	898	106	701	898
			domInteractive	24	13	62	16	41	62
			firstPaint	345	71	934	266	597	934
			backgroundConnect	70	12	263	79	169	263
			firstReactRender	27	24	30	2	29	30
			getState	144	94	185	24	159	185
			initialActions	0	0	1	0	1	1
			loadScripts	645	569	888	102	691	888
			setupStore	10	6	27	6	11	27
			numNetworkReqs	109	69	167	39	165	167
Firefox	Browserify	Standard Home	uiStartup	1465	1277	1875	125	1523	1720
			load	1239	1099	1483	92	1289	1422
			domContentLoaded	1239	1098	1482	92	1288	1422
			domInteractive	107	35	265	44	114	203
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	26	186	25	48	96
			firstReactRender	26	21	63	6	27	42
			getState	7	4	34	4	7	14
			initialActions	0	0	2	0	0	1
			loadScripts	1211	1078	1465	88	1267	1381
			setupStore	14	7	55	8	14	31
			numNetworkReqs	12	6	67	16	7	60
	Browserify	Power User Home	uiStartup	2483	2144	3299	301	2677	3299
			load	1384	1167	1816	220	1623	1816
			domContentLoaded	1384	1167	1815	220	1623	1815
			domInteractive	205	92	586	178	314	586
			firstPaint	-	-	-	-	-	-
			backgroundConnect	88	30	208	62	142	208
			firstReactRender	44	32	65	8	50	65
			getState	153	102	351	74	171	351
			initialActions	1	0	2	1	1	2
			loadScripts	1353	1148	1744	208	1581	1744
			setupStore	32	5	121	33	62	121
			numNetworkReqs	132	68	313	72	190	313
	Webpack	Standard Home	uiStartup	1669	1456	2345	152	1727	1984
			load	1416	1235	1767	111	1462	1640
			domContentLoaded	1416	1235	1767	111	1461	1640
			domInteractive	105	33	349	47	119	182
			firstPaint	-	-	-	-	-	-
			backgroundConnect	52	23	137	24	60	112
			firstReactRender	32	23	89	11	32	48
			getState	8	4	56	7	8	16
			initialActions	0	0	2	0	1	1
			loadScripts	1382	1217	1729	105	1418	1603
			setupStore	17	7	103	16	15	47
			numNetworkReqs	13	6	69	18	7	66
	Webpack	Power User Home	uiStartup	2531	2205	3138	303	2820	3138
			load	1517	1301	1804	180	1712	1804
			domContentLoaded	1517	1301	1804	180	1711	1804
			domInteractive	162	42	393	123	336	393
			firstPaint	-	-	-	-	-	-
			backgroundConnect	88	34	309	71	113	309
			firstReactRender	44	30	72	10	52	72
			getState	118	85	182	25	134	182
			initialActions	1	0	1	1	1	1
			loadScripts	1483	1274	1753	173	1688	1753
			setupStore	49	6	200	69	63	200
			numNetworkReqs	129	59	309	84	200	309

📊 Page Load Benchmark Results

Current Commit: a5f0a5a | Date: 11/7/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 986ms (±38ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 682ms (±36ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	986ms	38ms	965ms	1.26s	1.01s	1.26s
domContentLoaded	682ms	36ms	663ms	935ms	711ms	935ms
firstPaint	74ms	11ms	64ms	176ms	80ms	176ms
firstContentfulPaint	74ms	11ms	64ms	176ms	80ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

fabiobozzo

LGTM

development/mock-segment.js

Gudahtt

LGTM!

metamaskbot · 2025-11-10T19:27:49Z

Builds ready [a3d1061]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 105 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1205	1036	1553	105	1263	1411
			load	1034	873	1338	96	1091	1236
			domContentLoaded	1027	867	1331	95	1086	1228
			domInteractive	21	14	75	11	19	51
			firstPaint	708	158	1341	403	1044	1155
			backgroundConnect	202	190	245	9	205	216
			firstReactRender	23	17	47	5	23	36
			getState	21	8	68	9	25	38
			initialActions	0	0	1	0	0	1
			loadScripts	832	682	1136	93	893	1023
			setupStore	10	7	21	2	11	14
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	1900	1750	2363	199	1952	2363
			load	1021	889	1367	163	1238	1367
			domContentLoaded	1013	883	1358	163	1232	1358
			domInteractive	29	15	80	21	49	80
			firstPaint	564	187	1393	402	927	1393
			backgroundConnect	237	226	256	10	246	256
			firstReactRender	27	24	33	2	27	33
			getState	172	155	195	14	192	195
			initialActions	0	0	1	0	0	1
			loadScripts	789	661	1135	160	1006	1135
			setupStore	12	9	27	4	13	27
			numNetworkReqs	144	73	249	71	238	249
	Webpack	Standard Home	uiStartup	827	698	1217	85	843	1034
			load	606	547	1003	74	600	776
			domContentLoaded	599	543	976	70	595	761
			domInteractive	16	12	61	9	14	41
			firstPaint	195	55	1004	202	194	732
			backgroundConnect	24	11	66	13	27	57
			firstReactRender	29	18	67	9	34	42
			getState	12	6	30	4	14	20
			initialActions	0	0	1	0	0	1
			loadScripts	596	541	965	68	593	751
			setupStore	12	6	34	5	14	26
			numNetworkReqs	14	6	75	20	8	72
	Webpack	Power User Home	uiStartup	1275	1163	1658	139	1350	1658
			load	667	575	1038	139	711	1038
			domContentLoaded	643	564	957	116	682	957
			domInteractive	23	13	67	16	36	67
			firstPaint	302	65	921	239	567	921
			backgroundConnect	65	11	223	76	162	223
			firstReactRender	26	24	29	1	27	29
			getState	143	96	167	23	156	167
			initialActions	0	0	1	0	0	1
			loadScripts	639	562	947	113	672	947
			setupStore	11	6	27	7	12	27
			numNetworkReqs	109	67	170	40	162	170
Firefox	Browserify	Standard Home	uiStartup	1543	1361	2099	133	1575	1833
			load	1297	1151	1655	98	1342	1514
			domContentLoaded	1296	1150	1655	99	1342	1514
			domInteractive	110	35	495	61	116	220
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	30	146	19	52	85
			firstReactRender	28	23	53	4	28	31
			getState	9	5	48	6	9	17
			initialActions	0	0	1	0	1	1
			loadScripts	1270	1126	1575	94	1320	1481
			setupStore	14	7	51	8	15	34
			numNetworkReqs	12	6	67	16	7	62
	Browserify	Power User Home	uiStartup	2541	2170	3550	389	2688	3550
			load	1432	1175	1956	251	1666	1956
			domContentLoaded	1432	1175	1956	251	1666	1956
			domInteractive	212	82	684	184	367	684
			firstPaint	-	-	-	-	-	-
			backgroundConnect	139	39	748	170	168	748
			firstReactRender	50	32	79	14	56	79
			getState	132	78	263	49	182	263
			initialActions	1	0	7	2	1	7
			loadScripts	1380	1153	1929	222	1560	1929
			setupStore	34	6	105	28	60	105
			numNetworkReqs	187	65	327	82	240	327
	Webpack	Standard Home	uiStartup	1680	1455	2113	140	1705	1996
			load	1432	1251	1903	108	1499	1646
			domContentLoaded	1432	1250	1903	108	1498	1646
			domInteractive	100	32	404	46	109	188
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	27	117	20	54	106
			firstReactRender	31	23	88	11	31	44
			getState	7	4	23	3	8	15
			initialActions	0	0	1	0	0	1
			loadScripts	1399	1228	1868	103	1478	1570
			setupStore	16	7	85	12	15	41
			numNetworkReqs	13	6	68	17	8	65
	Webpack	Power User Home	uiStartup	2604	2295	3071	217	2755	3071
			load	1577	1409	1856	132	1680	1856
			domContentLoaded	1577	1408	1855	132	1680	1855
			domInteractive	179	50	446	128	359	446
			firstPaint	-	-	-	-	-	-
			backgroundConnect	111	44	244	63	167	244
			firstReactRender	46	31	96	15	48	96
			getState	133	88	288	59	140	288
			initialActions	1	0	6	1	1	6
			loadScripts	1529	1305	1824	138	1654	1824
			setupStore	32	5	77	25	56	77
			numNetworkReqs	156	68	319	83	237	319

📊 Page Load Benchmark Results

Current Commit: a3d1061 | Date: 11/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±57ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 742ms (±54ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±14ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	57ms	1.03s	1.40s	1.09s	1.40s
domContentLoaded	742ms	54ms	717ms	1.06s	759ms	1.06s
firstPaint	80ms	14ms	60ms	208ms	96ms	208ms
firstContentfulPaint	80ms	14ms	60ms	208ms	96ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 9.76 KiB (0.21%)
ui: 7.08 KiB (0.1%)
common: 12.75 KiB (0.15%)

print event properties

de50b51

metamaskbot added the team-accounts-framework Accounts Framework team label Nov 7, 2025

github-actions bot added the size-S label Nov 7, 2025

support identify event types

235a5ab

cursor bot reviewed Nov 7, 2025

View reviewed changes

development/mock-segment.js Outdated Show resolved Hide resolved

always print

a5f0a5a

cursor bot reviewed Nov 7, 2025

View reviewed changes

development/mock-segment.js Outdated Show resolved Hide resolved

fabiobozzo previously approved these changes Nov 10, 2025

View reviewed changes

Gudahtt reviewed Nov 10, 2025

View reviewed changes

development/mock-segment.js Outdated Show resolved Hide resolved

address feedback

a3d1061

owencraston dismissed fabiobozzo’s stale review via a3d1061 November 10, 2025 19:03

Gudahtt approved these changes Nov 10, 2025

View reviewed changes

gantunesr approved these changes Nov 10, 2025

View reviewed changes

owencraston added this pull request to the merge queue Nov 10, 2025

Merged via the queue into main with commit 6462cf0 Nov 10, 2025
173 checks passed

owencraston deleted the chore/improve-mock-segment-server branch November 10, 2025 20:11

github-actions bot locked and limited conversation to collaborators Nov 10, 2025

metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Improve Mock Segment Server to Print Event Properties #37635

chore: Improve Mock Segment Server to Print Event Properties #37635

owencraston commented Nov 7, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 7, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

fabiobozzo left a comment

Uh oh!

Uh oh!

Gudahtt left a comment

Uh oh!

metamaskbot commented Nov 10, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chore: Improve Mock Segment Server to Print Event Properties #37635

chore: Improve Mock Segment Server to Print Event Properties #37635

Conversation

owencraston commented Nov 7, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 7, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

fabiobozzo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Nov 10, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

owencraston commented Nov 7, 2025 •

edited by cursor bot

Loading