feat: adding flag for dapp swap origins #38398

jpuri · 2025-11-28T13:22:28Z

Description

Adding remote flag for dapp swap origins to make it configurable.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6347

Manual testing steps

submit swap requests
check that dapp swap feature work as expected

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a configurable origin allowlist to dapp-swap and enforces it in middleware and UI rendering, replacing hardcoded origins and updating related context, hooks, and tests.

Dapp Swap middleware/util:
- Extend dappSwapMetricsFlag to include origins: string[] and check origin membership before fetching quotes.
- Remove hardcoded origins; pass flag through createDappSwapMiddleware/getQuotesForConfirmation.
- Tests: add cases ensuring no fetch when origin not allowed; adjust existing tests to include origins.
UI hooks/components:
- useDappSwapCheck: read dappSwapMetrics.enabled and origins from remote flags; require allowed origin and compatible type; remove hardcoded origins; add tests for enabled/origin/type cases.
- DappSwapComparisonBanner: rely solely on useDappSwapCheck to render (remove separate flag check).
- DappSwapContext: add isQuotedSwapPresent.
- useDappSwapComparisonMetrics: use isQuotedSwapPresent to guard submit capture.
- Tests updated to mock new hook/context behavior and expectations.

^{Written by Cursor Bugbot for commit dbf1ec0. This will update automatically on new commits. Configure here.}

github-actions · 2025-11-28T13:22:37Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-11-28T13:23:05Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (8 files, +81 -26)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 dapp-swap-comparison-banner/
        
        📄 dapp-swap-comparison-banner.test.tsx +17 -8
        
        📄 dapp-swap-comparison-banner.tsx +1 -6
        
        📁 info/
        
        📁 base-transaction-info/
        
        📄 base-transaction-info.test.tsx +1 -0
        
        📁 hooks/
        
        📄 useFeeCalculations.test.ts +1 -0
    - 📁 context/
      - 📁 dapp-swap/
        
        📄 index.tsx +2 -0
    - 📁 hooks/
      - 📁 transactions/
        
        📁 dapp-swap-comparison/
        
        📄 useDappSwapCheck.test.ts +44 -4
        
        📄 useDappSwapCheck.ts +11 -5
        
        📄 useDappSwapComparisonMetrics.ts +4 -3

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapCheck.ts

…k-extension into dapp_swap_fixes

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapCheck.test.ts

metamaskbot · 2025-11-28T14:19:17Z

Builds ready [670b23f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1246 ± 92 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1246	1049	1439	92	1319	1383
			load	1038	876	1251	83	1089	1188
			domContentLoaded	1033	870	1240	82	1085	1179
			domInteractive	26	15	92	19	22	77
			firstPaint	517	84	1269	413	1036	1163
			backgroundConnect	219	195	266	15	225	255
			firstReactRender	33	20	63	10	37	56
			getState	43	18	148	25	47	121
			initialActions	1	0	14	2	1	3
			loadScripts	819	659	1035	82	867	975
			setupStore	12	6	29	4	14	21
			numNetworkReqs	12	5	75	20	5	71
	Browserify	Power User Home	uiStartup	2097	1731	2874	281	2329	2734
			load	1021	876	1516	142	1013	1443
			domContentLoaded	1007	867	1505	142	996	1433
			domInteractive	37	17	149	30	35	132
			firstPaint	492	102	1538	368	925	1021
			backgroundConnect	240	202	716	79	229	446
			firstReactRender	56	41	111	11	60	79
			getState	193	139	696	58	207	246
			initialActions	1	0	3	1	1	2
			loadScripts	799	670	1295	142	787	1221
			setupStore	20	8	61	9	23	42
			numNetworkReqs	170	70	412	77	212	339
	Webpack	Standard Home	uiStartup	870	723	1262	101	914	1076
			load	675	585	1105	92	716	832
			domContentLoaded	670	579	1098	91	710	826
			domInteractive	29	16	198	27	24	96
			firstPaint	257	82	842	198	223	766
			backgroundConnect	11	6	80	9	11	27
			firstReactRender	28	20	55	7	33	41
			getState	25	13	57	9	31	44
			initialActions	1	0	5	1	1	2
			loadScripts	667	576	1087	90	707	816
			setupStore	11	6	30	5	13	22
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1651	1266	2390	284	1954	2107
			load	670	578	1226	107	680	932
			domContentLoaded	659	572	1218	108	673	924
			domInteractive	37	17	157	32	34	133
			firstPaint	302	97	1229	222	369	696
			backgroundConnect	53	7	633	130	19	478
			firstReactRender	60	41	91	11	66	82
			getState	175	127	743	59	177	195
			initialActions	1	0	3	1	1	2
			loadScripts	657	570	1210	106	670	915
			setupStore	21	8	88	13	22	47
			numNetworkReqs	170	67	430	85	218	412
Firefox	Browserify	Standard Home	uiStartup	1285	1052	1669	145	1371	1591
			load	1062	904	1445	108	1121	1281
			domContentLoaded	1062	904	1445	108	1121	1281
			domInteractive	58	30	117	27	83	107
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	23	147	27	48	102
			firstReactRender	24	18	59	8	23	45
			getState	10	6	45	5	10	21
			initialActions	1	0	3	1	1	2
			loadScripts	1036	888	1370	96	1097	1246
			setupStore	12	6	95	15	9	35
			numNetworkReqs	11	5	69	16	6	62
	Browserify	Power User Home	uiStartup	2684	1903	4688	664	2837	4275
			load	1247	969	2655	382	1268	2472
			domContentLoaded	1247	969	2654	382	1267	2472
			domInteractive	117	34	472	103	110	407
			firstPaint	-	-	-	-	-	-
			backgroundConnect	166	22	1141	248	122	1004
			firstReactRender	61	36	142	22	61	126
			getState	279	61	1027	228	394	769
			initialActions	2	0	4	1	2	3
			loadScripts	1172	954	2590	279	1215	1577
			setupStore	132	6	799	177	132	601
			numNetworkReqs	101	52	272	61	81	240
	Webpack	Standard Home	uiStartup	1501	1260	2026	135	1572	1759
			load	1243	1067	1560	94	1294	1404
			domContentLoaded	1243	1067	1559	94	1294	1403
			domInteractive	62	21	173	32	83	112
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	21	181	30	51	114
			firstReactRender	28	21	72	8	30	38
			getState	13	5	113	15	13	27
			initialActions	1	0	3	1	2	2
			loadScripts	1215	1052	1528	87	1272	1366
			setupStore	14	6	91	13	13	41
			numNetworkReqs	12	5	66	16	7	64
	Webpack	Power User Home	uiStartup	2916	2092	5160	747	2854	4883
			load	1483	1180	3007	452	1574	2749
			domContentLoaded	1483	1180	3007	452	1574	2749
			domInteractive	129	34	1071	168	98	468
			firstPaint	-	-	-	-	-	-
			backgroundConnect	188	29	1462	280	158	1140
			firstReactRender	62	42	143	18	64	105
			getState	301	79	937	233	416	794
			initialActions	2	0	38	4	2	5
			loadScripts	1384	1116	2989	328	1419	2339
			setupStore	112	6	605	154	105	575
			numNetworkReqs	100	63	255	60	79	250

📊 Page Load Benchmark Results

Current Commit: 670b23f | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±35ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±14ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	38ms	1000ms	1.32s	1.05s	1.32s
domContentLoaded	717ms	35ms	692ms	983ms	728ms	983ms
firstPaint	75ms	14ms	60ms	196ms	88ms	196ms
firstContentfulPaint	75ms	14ms	60ms	196ms	88ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 13 Bytes (0%)
ui: 397 Bytes (0.01%)
common: 20 Bytes (0%)

app/scripts/lib/dapp-swap/dapp-swap-util.ts

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapCheck.ts

…k-extension into dapp_swap_fixes

metamaskbot · 2025-11-28T16:32:12Z

Builds ready [77c2686]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1225 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1225	1046	1548	96	1286	1372
			load	1030	866	1375	90	1076	1187
			domContentLoaded	1024	861	1362	88	1072	1183
			domInteractive	26	14	98	20	21	85
			firstPaint	500	89	1250	382	987	1100
			backgroundConnect	216	193	260	12	222	241
			firstReactRender	31	21	67	10	37	52
			getState	35	16	135	19	40	64
			initialActions	1	0	4	1	1	3
			loadScripts	815	659	1141	86	854	964
			setupStore	11	7	32	4	13	19
			numNetworkReqs	12	5	74	20	5	72
	Browserify	Power User Home	uiStartup	1988	1619	2760	284	2229	2619
			load	955	826	1458	143	939	1365
			domContentLoaded	940	820	1438	143	923	1352
			domInteractive	31	16	124	25	29	103
			firstPaint	674	92	1466	379	914	1321
			backgroundConnect	225	180	725	99	205	498
			firstReactRender	58	38	125	17	62	104
			getState	213	137	684	116	208	625
			initialActions	1	0	4	1	1	2
			loadScripts	758	638	1241	138	739	1159
			setupStore	18	9	55	8	19	39
			numNetworkReqs	156	65	419	78	197	342
	Webpack	Standard Home	uiStartup	819	692	1043	76	857	990
			load	632	555	818	69	650	796
			domContentLoaded	627	551	814	69	646	791
			domInteractive	25	14	91	20	21	87
			firstPaint	202	79	790	127	194	576
			backgroundConnect	10	5	33	6	10	26
			firstReactRender	28	20	107	10	30	38
			getState	25	14	62	10	34	41
			initialActions	1	0	4	1	1	1
			loadScripts	625	549	805	68	643	782
			setupStore	11	6	34	5	12	20
			numNetworkReqs	12	5	77	20	5	72
	Webpack	Power User Home	uiStartup	1688	1302	2503	278	1985	2138
			load	679	589	1240	103	673	927
			domContentLoaded	669	584	1234	104	662	919
			domInteractive	36	18	134	30	33	127
			firstPaint	287	100	948	186	323	660
			backgroundConnect	76	8	629	166	18	577
			firstReactRender	63	45	107	10	67	83
			getState	184	131	702	73	185	217
			initialActions	1	0	5	1	1	2
			loadScripts	666	582	1224	102	660	910
			setupStore	23	10	73	14	25	54
			numNetworkReqs	174	65	421	82	216	408
Firefox	Browserify	Standard Home	uiStartup	1363	1113	1981	153	1456	1656
			load	1118	957	1392	90	1190	1272
			domContentLoaded	1117	956	1386	90	1189	1271
			domInteractive	65	32	154	31	86	117
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	24	238	39	70	162
			firstReactRender	24	19	68	7	24	36
			getState	12	6	59	8	12	26
			initialActions	1	0	2	0	2	2
			loadScripts	1086	941	1365	82	1147	1216
			setupStore	16	5	184	24	11	60
			numNetworkReqs	12	5	68	17	6	64
	Browserify	Power User Home	uiStartup	2630	2048	4599	558	2642	4113
			load	1188	913	2696	300	1187	1722
			domContentLoaded	1188	913	2696	300	1187	1720
			domInteractive	111	32	631	111	105	381
			firstPaint	-	-	-	-	-	-
			backgroundConnect	133	26	1087	181	120	347
			firstReactRender	56	37	115	14	60	93
			getState	315	35	1042	223	440	780
			initialActions	2	0	7	1	2	3
			loadScripts	1131	899	2604	221	1138	1527
			setupStore	136	9	728	176	124	644
			numNetworkReqs	100	60	262	55	114	244
	Webpack	Standard Home	uiStartup	1474	1258	1881	139	1546	1766
			load	1212	1057	1407	89	1280	1384
			domContentLoaded	1211	1057	1406	89	1279	1384
			domInteractive	59	25	172	33	83	118
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	17	185	28	45	112
			firstReactRender	27	20	87	9	29	40
			getState	16	7	191	25	14	45
			initialActions	1	0	3	1	2	2
			loadScripts	1187	1038	1376	85	1256	1334
			setupStore	14	6	170	21	11	52
			numNetworkReqs	11	5	74	16	7	59
	Webpack	Power User Home	uiStartup	2891	2121	5245	668	2982	4318
			load	1456	1169	2809	392	1476	2457
			domContentLoaded	1456	1169	2809	392	1476	2457
			domInteractive	113	31	940	128	100	379
			firstPaint	-	-	-	-	-	-
			backgroundConnect	155	26	1036	208	132	910
			firstReactRender	61	41	190	27	62	112
			getState	238	79	855	186	278	700
			initialActions	4	0	102	11	2	4
			loadScripts	1393	1151	2663	322	1444	2333
			setupStore	135	7	919	185	132	593
			numNetworkReqs	100	59	260	55	114	239

📊 Page Load Benchmark Results

Current Commit: 77c2686 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±37ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	40ms	1.03s	1.34s	1.07s	1.34s
domContentLoaded	733ms	37ms	715ms	1.01s	752ms	1.01s
firstPaint	79ms	10ms	60ms	160ms	84ms	160ms
firstContentfulPaint	79ms	10ms	60ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 13 Bytes (0%)
ui: 397 Bytes (0%)
common: 20 Bytes (0%)

app/scripts/lib/dapp-swap/dapp-swap-util.ts

metamaskbot · 2025-12-03T06:09:44Z

Builds ready [dbf1ec0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1285 ± 114 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1285	1073	1518	114	1359	1473
			load	1071	897	1311	103	1148	1258
			domContentLoaded	1064	894	1291	101	1143	1247
			domInteractive	26	16	97	20	22	82
			firstPaint	499	100	1280	394	999	1177
			backgroundConnect	223	200	279	15	231	252
			firstReactRender	32	19	109	13	37	58
			getState	44	16	138	28	49	124
			initialActions	1	0	4	1	1	3
			loadScripts	850	681	1077	97	914	1030
			setupStore	13	6	39	6	14	26
			numNetworkReqs	12	5	76	20	5	70
	Browserify	Power User Home	uiStartup	2092	1768	2782	190	2152	2464
			load	1040	907	1716	130	1029	1361
			domContentLoaded	1025	898	1668	130	1020	1351
			domInteractive	35	18	136	24	33	104
			firstPaint	514	124	1699	407	982	1361
			backgroundConnect	252	207	759	94	235	514
			firstReactRender	61	39	116	17	65	104
			getState	188	136	281	31	208	249
			initialActions	1	0	9	1	1	4
			loadScripts	811	690	1449	128	800	1142
			setupStore	20	11	50	7	24	34
			numNetworkReqs	149	70	332	60	205	244
	Webpack	Standard Home	uiStartup	800	695	968	67	831	953
			load	624	561	792	60	646	777
			domContentLoaded	619	553	787	60	634	772
			domInteractive	25	15	108	21	22	90
			firstPaint	210	93	780	150	198	639
			backgroundConnect	9	5	27	4	11	16
			firstReactRender	28	19	133	12	31	37
			getState	25	13	55	10	32	44
			initialActions	1	0	4	1	1	2
			loadScripts	616	551	778	58	632	762
			setupStore	10	5	42	5	12	16
			numNetworkReqs	12	5	75	19	5	69
	Webpack	Power User Home	uiStartup	1616	1297	2308	221	1711	2071
			load	686	587	1246	106	698	913
			domContentLoaded	675	580	1240	106	685	906
			domInteractive	37	18	210	30	35	117
			firstPaint	319	117	950	203	367	697
			backgroundConnect	62	9	642	156	17	593
			firstReactRender	60	42	95	10	64	80
			getState	190	151	244	20	199	228
			initialActions	1	0	5	1	1	2
			loadScripts	672	578	1231	105	682	898
			setupStore	19	10	63	11	20	48
			numNetworkReqs	163	71	395	64	212	303
Firefox	Browserify	Standard Home	uiStartup	1327	1039	1895	158	1431	1581
			load	1096	891	1462	112	1173	1298
			domContentLoaded	1096	891	1461	112	1173	1298
			domInteractive	60	31	255	38	84	111
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	22	183	34	57	124
			firstReactRender	23	18	38	5	24	35
			getState	12	7	92	11	11	23
			initialActions	1	0	3	1	2	2
			loadScripts	1068	878	1443	103	1139	1265
			setupStore	12	5	91	10	11	32
			numNetworkReqs	12	5	70	17	6	62
	Browserify	Power User Home	uiStartup	2665	1927	5063	592	2726	4252
			load	1205	997	2884	308	1199	1589
			domContentLoaded	1204	996	2883	308	1198	1589
			domInteractive	115	35	674	98	111	358
			firstPaint	-	-	-	-	-	-
			backgroundConnect	140	25	1021	159	132	485
			firstReactRender	59	36	280	31	58	104
			getState	287	49	1214	235	347	799
			initialActions	2	1	39	5	2	3
			loadScripts	1157	965	2696	259	1168	1478
			setupStore	144	6	782	190	142	681
			numNetworkReqs	94	59	326	53	83	240
	Webpack	Standard Home	uiStartup	1481	1259	1884	127	1537	1809
			load	1229	1064	1506	91	1285	1421
			domContentLoaded	1229	1064	1506	91	1285	1420
			domInteractive	58	27	180	33	81	126
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	20	131	25	44	107
			firstReactRender	25	19	81	8	28	37
			getState	12	6	127	13	11	25
			initialActions	2	0	5	1	2	3
			loadScripts	1202	1048	1485	84	1255	1367
			setupStore	15	6	99	16	14	51
			numNetworkReqs	12	5	66	17	7	64
	Webpack	Power User Home	uiStartup	3042	2158	6393	896	2933	4834
			load	1531	1153	3117	489	1542	2889
			domContentLoaded	1531	1153	3117	489	1542	2889
			domInteractive	116	31	967	122	107	379
			firstPaint	-	-	-	-	-	-
			backgroundConnect	164	25	1168	203	151	732
			firstReactRender	63	39	241	29	61	121
			getState	286	68	1228	251	364	841
			initialActions	2	1	52	5	2	3
			loadScripts	1460	1095	2976	435	1492	2656
			setupStore	131	5	1002	192	113	613
			numNetworkReqs	92	59	335	47	84	220

📊 Page Load Benchmark Results

Current Commit: dbf1ec0 | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 737ms (±36ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±11ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	40ms	1.02s	1.34s	1.09s	1.34s
domContentLoaded	737ms	36ms	707ms	999ms	760ms	999ms
firstPaint	80ms	11ms	60ms	168ms	92ms	168ms
firstContentfulPaint	80ms	11ms	60ms	168ms	92ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 13 Bytes (0%)
ui: 397 Bytes (0%)
common: 20 Bytes (0%)

Adding flag for dapp swap origins

ff77acf

jpuri requested a review from a team as a code owner November 28, 2025 13:22

jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Nov 28, 2025

Merge branch 'main' into dapp_swap_fixes

6f98e6d

github-actions bot added the size-M label Nov 28, 2025

cursor bot reviewed Nov 28, 2025

View reviewed changes

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapCheck.ts Show resolved Hide resolved

jpuri added 2 commits November 28, 2025 19:00

test

e375d83

Merge branch 'dapp_swap_fixes' of https://github.com/MetaMask/metamas…

fb465b0

…k-extension into dapp_swap_fixes

cursor bot reviewed Nov 28, 2025

View reviewed changes

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapCheck.test.ts Show resolved Hide resolved

test

670b23f

jpuri enabled auto-merge November 28, 2025 13:46

test

12a3ebe

cursor bot reviewed Nov 28, 2025

View reviewed changes

app/scripts/lib/dapp-swap/dapp-swap-util.ts Show resolved Hide resolved

jpuri added 3 commits November 28, 2025 20:09

test

e54c742

test

8f1e444

Merge branch 'main' into dapp_swap_fixes

b755c62

cursor bot reviewed Nov 28, 2025

View reviewed changes

ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapCheck.ts Show resolved Hide resolved

jpuri added 3 commits November 28, 2025 21:14

update

18cd566

Merge branch 'dapp_swap_fixes' of https://github.com/MetaMask/metamas…

7be7374

…k-extension into dapp_swap_fixes

Merge branch 'main' into dapp_swap_fixes

77c2686

OGPoyraz approved these changes Dec 2, 2025

View reviewed changes

Merge branch 'main' into dapp_swap_fixes

dbf1ec0

vinistevam approved these changes Dec 3, 2025

View reviewed changes

cursor bot reviewed Dec 3, 2025

View reviewed changes

app/scripts/lib/dapp-swap/dapp-swap-util.ts Show resolved Hide resolved

jpuri added this pull request to the merge queue Dec 3, 2025

Merged via the queue into main with commit 292f3c1 Dec 3, 2025
336 of 338 checks passed

jpuri deleted the dapp_swap_fixes branch December 3, 2025 08:55

github-actions bot locked and limited conversation to collaborators Dec 3, 2025

metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: adding flag for dapp swap origins #38398

feat: adding flag for dapp swap origins #38398

jpuri commented Nov 28, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Dec 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: adding flag for dapp swap origins #38398

feat: adding flag for dapp swap origins #38398

Conversation

jpuri commented Nov 28, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Dec 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jpuri commented Nov 28, 2025 •

edited by cursor bot

Loading

metamaskbot commented Nov 28, 2025 •

edited

Loading