Skip to content

fix: layout inconsistencies cp-13.12.0 #38410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: layout inconsistencies cp-13.12.0 #38410

wants to merge 5 commits into from
+10 −35

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Nov 28, 2025 •
edited by cursor bot
Loading

Description

Fix layout inconsistencies in sidepanel and fullscreen modes

Also aligns "Fund your wallet"

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: confirmation layout in sidepanel

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-740

Manual testing steps

In sidepanel and fullscreen

  • Confirmations
  • Accounts list
  • Import SRP
  • Import PK

Screenshots/Recordings

Before

Confirmations Accounts
image image

After

Confirmations Accounts
image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Switches confirmations and Import SRP to RootLayout and removes fixed widths/padding across multichain pages to align sidepanel/fullscreen layouts.

  • Routing/Layout:
    • Move CONFIRM_TRANSACTION_ROUTE and CONFIRMATION_V_NEXT_ROUTE to RootLayout.
    • Move IMPORT_SRP_ROUTE to RootLayout.
    • Remove MultichainMetaFoxLogo rendering on confirm routes and related isConfirmTransactionRoute import.
  • Multichain Account Pages:
    • Drop fixed max-w-[600px] on Page wrappers in add-wallet-page, multichain-account-address-list-page, multichain-account-private-key-list-page, and smart-account-page.
    • Remove account-list stylesheet and its import.
  • Styles:
    • Remove extra padding rule for .multichain-page when not using app header.
    • Import SRP: remove fixed max-width/height; keep responsive layout.
    • Wallet overview: widen and center BalanceEmptyState (max-w[460px], self-center).

Written by Cursor Bugbot for commit 1a5118e. This will update automatically on new commits. Configure here.

@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Nov 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@n3ps n3ps enabled auto-merge November 28, 2025 18:00
@n3ps n3ps changed the title fix: confirmations layout in sidepanel fix: confirmations layout in sidepanel cp-13.12.0 Nov 28, 2025
@n3ps n3ps requested a review from a team November 28, 2025 18:01
NidhiKJha
NidhiKJha previously approved these changes Nov 28, 2025
View reviewed changes
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 28, 2025

Builds ready [3bafeeb]
UI Startup Metrics (1216 ± 110 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12161015151111012871405
load102284312569710771208
domContentLoaded101683812539710691203
domInteractive261688192381
firstPaint4338211953639101164
backgroundConnect21119025312216240
firstReactRender301981103251
getState3516132194066
initialActions1026312
loadScripts811646103194870990
setupStore1172641119
numNetworkReqs1257720573
BrowserifyPower User HomeuiStartup20621739347527422632559
load1023884184415010191362
domContentLoaded1009873183015010041344
domInteractive36181743132128
firstPaint57512013843879551275
backgroundConnect253200749104226531
firstReactRender5939106166299
getState18713071361203244
initialActions108112
loadScripts80367716121487971141
setupStore20104582537
numNetworkReqs103632825495271
WebpackStandard HomeuiStartup8457041210918761019
load64857297678665829
domContentLoaded64256897178658823
domInteractive2915146262298
firstPaint23583785165238625
backgroundConnect1063661026
firstReactRender28204563239
getState271361113548
initialActions102111
loadScripts64056696076656814
setupStore1162231218
numNetworkReqs1257720572
WebpackPower User HomeuiStartup16121265240926518902107
load666580102888677897
domContentLoaded656575102488667891
domInteractive36171542935122
firstPaint28594923194320695
backgroundConnect63765014718542
firstReactRender6146104106783
getState194129740107183304
initialActions104112
loadScripts654572101387665881
setupStore211061112646
numNetworkReqs1696742681215386
FirefoxBrowserifyStandard HomeuiStartup12811076182114613681566
load105692614319211021260
domContentLoaded105692614319211021260
domInteractive57322313275118
firstPaint------
backgroundConnect44212033145105
firstReactRender22185952432
getState137159191035
initialActions103112
loadScripts103290214048810781182
setupStore1167291028
numNetworkReqs1156815660
BrowserifyPower User HomeuiStartup26421925534854227064003
load1194956248426612141621
domContentLoaded1194956248426612141620
domInteractive12033598114113411
firstPaint------
backgroundConnect1052647574116247
firstReactRender6138371356194
getState267501018217286722
initialActions2134326
loadScripts1158915232424511871577
setupStore2028853244268786
numNetworkReqs975930051116233
WebpackStandard HomeuiStartup14661279200714015251790
load1217108115089412601421
domContentLoaded1217108115089412601420
domInteractive61281643083112
firstPaint------
backgroundConnect45212383247118
firstReactRender26204152838
getState156177231334
initialActions103122
loadScripts1191106214598612401379
setupStore165193241344
numNetworkReqs1257018764
WebpackPower User HomeuiStartup29462176494772130514595
load14851170316448114712821
domContentLoaded14851170316448114712821
domInteractive12631104516598448
firstPaint------
backgroundConnect150251307224126380
firstReactRender67421912868139
getState317831887284414803
initialActions2129323
loadScripts14041147299641314342667
setupStore1285719170128590
numNetworkReqs99612565879242
📊 Page Load Benchmark Results

Current Commit: 3bafeeb | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.02s (±35ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 712ms (±33ms) 🟢 | historical mean value: 719ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.02s 35ms 1.00s 1.28s 1.03s 1.28s
domContentLoaded 712ms 33ms 695ms 963ms 722ms 963ms
firstPaint 75ms 11ms 56ms 168ms 88ms 168ms
firstContentfulPaint 75ms 11ms 56ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: -294 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps requested a review from a team November 28, 2025 23:06
@n3ps n3ps changed the title fix: confirmations layout in sidepanel cp-13.12.0 fix: layout inconsistencies 1 cp-13.12.0 Nov 29, 2025
@n3ps n3ps changed the title fix: layout inconsistencies 1 cp-13.12.0 fix: layout inconsistencies cp-13.12.0 Nov 29, 2025
@n3ps n3ps requested a review from a team as a code owner November 29, 2025 02:34
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 29, 2025 •
edited
Loading

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (5 files, +4 -11)
  • 📁 ui/
    • 📁 pages/
      • 📁 multichain-accounts/
        • 📁 account-list/
          • 📄 account-list.scss +0 -7
        • 📁 add-wallet-page/
          • 📄 add-wallet-page.tsx +1 -1
        • 📁 multichain-account-address-list-page/
          • 📄 multichain-account-address-list-page.tsx +1 -1
        • 📁 multichain-account-private-key-list-page/
          • 📄 multichain-account-private-key-list-page.tsx +1 -1
        • 📁 smart-account-page/
          • 📄 smart-account-page.tsx +1 -1
👨‍🔧 @MetaMask/core-extension-ux (1 files, +0 -7)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 pages/
          • 📁 page/
            • 📄 index.scss +0 -7

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 29, 2025

Builds ready [1a5118e]
UI Startup Metrics (1242 ± 113 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12421007155211313101416
load1048867130210211111250
domContentLoaded1041862129710111051241
domInteractive251696192183
firstPaint52982129741510051170
backgroundConnect21519525412221241
firstReactRender30186493549
getState351693154069
initialActions1010113
loadScripts8336641093978831016
setupStore1162941224
numNetworkReqs1257720571
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup8407081157918891028
load65556892886695827
domContentLoaded65056492385689822
domInteractive2716109232298
firstPaint23383911166217630
backgroundConnect1054461126
firstReactRender28206573341
getState261363103442
initialActions103111
loadScripts64756292184687813
setupStore1162631218
numNetworkReqs1257620572
WebpackPower User HomeuiStartup15951283225622918092030
load678588100388697895
domContentLoaded66858399688685887
domInteractive36171552936122
firstPaint22984724121234634
backgroundConnect85761217020547
firstReactRender60477986577
getState1709428921178208
initialActions104112
loadScripts66558198787683878
setupStore20649102346
numNetworkReqs1296441971131337
FirefoxBrowserifyStandard HomeuiStartup12931077180213713771539
load107293214369611141259
domContentLoaded107193214369611141259
domInteractive59311362683110
firstPaint------
backgroundConnect44213203840115
firstReactRender24185872439
getState126127131119
initialActions103012
loadScripts104591914139010831218
setupStore135135171138
numNetworkReqs1256516663
BrowserifyPower User HomeuiStartup27542200464541928693583
load12501037176116112871610
domContentLoaded12491037176116112861609
domInteractive12837499104125447
firstPaint------
backgroundConnect143351082139143409
firstReactRender6545128157199
getState26563907188324684
initialActions208133
loadScripts1210997165515312501574
setupStore17610847209181708
numNetworkReqs100593236679239
WebpackStandard HomeuiStartup14681229198415215491777
load1207105314859412791394
domContentLoaded1206105314859412791394
domInteractive58262263580123
firstPaint------
backgroundConnect47202143344128
firstReactRender27208492835
getState136201201127
initialActions102112
loadScripts1181103714228712571331
setupStore165191271147
numNetworkReqs1157416762
WebpackPower User HomeuiStartup30142237527580331574822
load14531172305140813932632
domContentLoaded14521172305140813922631
domInteractive1072949110496425
firstPaint------
backgroundConnect142311280186130504
firstReactRender68403533866144
getState268671144223317842
initialActions204123
loadScripts13851136289833113312512
setupStore16851103228171716
numNetworkReqs102612996280250
📊 Page Load Benchmark Results

Current Commit: 1a5118e | Date: 11/29/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±36ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.01s 1.31s 1.07s 1.31s
domContentLoaded 719ms 36ms 698ms 982ms 745ms 982ms
firstPaint 76ms 12ms 60ms 176ms 84ms 176ms
firstContentfulPaint 76ms 12ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 18 Bytes (0%)
  • common: 55 Bytes (0%)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 29, 2025

Builds ready [1a5118e]
UI Startup Metrics (1242 ± 113 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12421007155211313101416
load1048867130210211111250
domContentLoaded1041862129710111051241
domInteractive251696192183
firstPaint52982129741510051170
backgroundConnect21519525412221241
firstReactRender30186493549
getState351693154069
initialActions1010113
loadScripts8336641093978831016
setupStore1162941224
numNetworkReqs1257720571
BrowserifyPower User HomeuiStartup20291648273125122052561
load1008882143512810411349
domContentLoaded995876142712910171342
domInteractive34171562834118
firstPaint5129914413939321300
backgroundConnect23819962583223519
firstReactRender5740109136187
getState18814070258200244
initialActions106112
loadScripts79267812341288141143
setupStore2077292341
numNetworkReqs102632815695276
WebpackStandard HomeuiStartup8407081157918891028
load65556892886695827
domContentLoaded65056492385689822
domInteractive2716109232298
firstPaint23383911166217630
backgroundConnect1054461126
firstReactRender28206573341
getState261363103442
initialActions103111
loadScripts64756292184687813
setupStore1162631218
numNetworkReqs1257620572
WebpackPower User HomeuiStartup15951283225622918092030
load678588100388697895
domContentLoaded66858399688685887
domInteractive36171552936122
firstPaint22984724121234634
backgroundConnect85761217020547
firstReactRender60477986577
getState1709428921178208
initialActions104112
loadScripts66558198787683878
setupStore20649102346
numNetworkReqs1296441971131337
FirefoxBrowserifyStandard HomeuiStartup12931077180213713771539
load107293214369611141259
domContentLoaded107193214369611141259
domInteractive59311362683110
firstPaint------
backgroundConnect44213203840115
firstReactRender24185872439
getState126127131119
initialActions103012
loadScripts104591914139010831218
setupStore135135171138
numNetworkReqs1256516663
BrowserifyPower User HomeuiStartup27542200464541928693583
load12501037176116112871610
domContentLoaded12491037176116112861609
domInteractive12837499104125447
firstPaint------
backgroundConnect143351082139143409
firstReactRender6545128157199
getState26563907188324684
initialActions208133
loadScripts1210997165515312501574
setupStore17610847209181708
numNetworkReqs100593236679239
WebpackStandard HomeuiStartup14681229198415215491777
load1207105314859412791394
domContentLoaded1206105314859412791394
domInteractive58262263580123
firstPaint------
backgroundConnect47202143344128
firstReactRender27208492835
getState136201201127
initialActions102112
loadScripts1181103714228712571331
setupStore165191271147
numNetworkReqs1157416762
WebpackPower User HomeuiStartup30142237527580331574822
load14531172305140813932632
domContentLoaded14521172305140813922631
domInteractive1072949110496425
firstPaint------
backgroundConnect142311280186130504
firstReactRender68403533866144
getState268671144223317842
initialActions204123
loadScripts13851136289833113312512
setupStore16851103228171716
numNetworkReqs102612996280250
📊 Page Load Benchmark Results

Current Commit: 1a5118e | Date: 11/29/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±36ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.01s 1.31s 1.07s 1.31s
domContentLoaded 719ms 36ms 698ms 982ms 745ms 982ms
firstPaint 76ms 12ms 60ms 176ms 84ms 176ms
firstContentfulPaint 76ms 12ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 18 Bytes (0%)
  • common: 55 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@n3ps @metamaskbot @NidhiKJha