refactor: remove unused swap selectors and fix selector types #38413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨🕵️ @MetaMask/extension-privacy-reviewers (1 files, +0 -2)
🧪 @MetaMask/qa (1 files, +0 -2)
🔄 @MetaMask/swaps-engineers (26 files, +354 -1605)
|
Collaborator
Builds ready [31288a4]
UI Startup Metrics (1248 ± 120 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bd81e44]
UI Startup Metrics (1452 ± 153 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [a51b7d8]
UI Startup Metrics (1227 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [ae45132]
UI Startup Metrics (1277 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [de91a29]
UI Startup Metrics (1313 ± 126 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [b4a84dc]
UI Startup Metrics (1247 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [d884a21]
UI Startup Metrics (1250 ± 123 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [e4d03e8]
UI Startup Metrics (1283 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [ecbf219]
UI Startup Metrics (1260 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [ecbf219]
UI Startup Metrics (1260 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [1450d09]
UI Startup Metrics (1277 ± 120 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
SteP-n-s
reviewed
Dec 2, 2025
| */ | ||
| export type BridgeNetwork = { | ||
| name: string; | ||
| nativeCurrency: string; |
Contributor
There was a problem hiding this comment.
is the value of nativeCurrency the ticker of the gas token of the network?
Member
Author
There was a problem hiding this comment.
Yea, it's the gas token ticker
ui/hooks/useMultichainBalances.ts
Outdated
| symbol: assetMetadataById[caipAssetId]?.symbol ?? '', | ||
| assetId: caipAssetId, | ||
| address: assetReference, | ||
| isNative: assetNamespace === 'slip44', |
Contributor
There was a problem hiding this comment.
Is it worth saving slip44 in a variable in case we need to use it in other places as well?
Collaborator
Builds ready [92155e9]
UI Startup Metrics (1390 ± 138 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
SteP-n-s
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleans up
bridgeredux state, selectors and actions to prepare for the AssetPicker refactortoTokenExchangeRateandtoTokenUsdExchangeRatefrom stateuseBridgeExchangeRatesto only fetch source exchange ratesgetAllBridgeableNetworks,getToTokenConversionRate,getIsBridgeTxNetworkConfigurationtype references withBridgeNetwork(minimal network object required by swaps) for better type safetyChangelog
CHANGELOG entry: refactor: remove unused swap selectors and fix types
Related issues
Fixes: N/A
Manual testing steps
No user-facing changes
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Cleans up bridge state and selectors by dropping destination exchange-rate handling, tightening types (incl. BridgeNetwork), simplifying actions/hooks, and updating tests/stories accordingly.
toTokenExchangeRateandtoTokenUsdExchangeRatefrombridgestate and related actions/thunks.setFromChainto acceptchainId(Hex/CAIP) and derive network client id; auto-select native token for non‑EVM.setSrcTokenExchangeRates.getAllBridgeableNetworkswith record-based lookup frommultichainNetworkConfigurationsByChainId.getToTokenConversionRate,getIsBridgeTx).BridgeNetworktype; refine balances and validation logic; expose price impact thresholds and no-fee assets via feature flags.useBridgeExchangeRatesnow fetches only source token rates and uses cache.useBridgeQueryParamsupdated to work with new types and chain selection flow.useSolanaBridgeTransactionMappinghook.isQuoteExpiredOrInvalid,isNetworkAdded, and image/balance handling; addsafeAmountForCalc.featureFlagOverrides: { bridgeConfig }andBridgeControllerStatefields; adjust snapshots and fixtures to new shapes.ALLOWED_BRIDGE_CHAIN_IDSasconst; addSLIP44_ASSET_NAMESPACE.Written by Cursor Bugbot for commit 92155e9. This will update automatically on new commits. Configure here.