Skip to content

Commit

Permalink
chore: Upgrade react-native-svg to 15.3 (#9658)
Browse files Browse the repository at this point in the history
## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:
https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=61547905

## **Manual testing steps**

1. Go to https://app.poolside.party with the in-app browser and connect
the wallet
2. Once you connect, you would see an `Root Error: Text strings must be
rendered within a <Text> component.` error message, but **now** you
should not see that error message... the wallet should connect just
fine.

## **Screenshots/Recordings**

### **Before**

https://github.com/MetaMask/metamask-mobile/assets/6249205/6a58eca9-e9a0-4240-acdd-f7fb3b52f033

### **After**

https://github.com/MetaMask/metamask-mobile/assets/6249205/d9e68e1f-6aff-42bb-9b3f-80eae8ef2e2d


## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [X] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [X] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
kylanhurt authored May 20, 2024
1 parent 42a3a53 commit 11ff42e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ PODS:
- Sentry/HybridSDK (= 8.21.0)
- RNShare (7.3.7):
- React-Core
- RNSVG (15.2.0):
- RNSVG (15.3.0):
- React-Core
- RNVectorIcons (6.4.2):
- React
Expand Down Expand Up @@ -1141,7 +1141,7 @@ SPEC CHECKSUMS:
RNSensors: c363d486c879e181905dea84a2535e49af1c2d25
RNSentry: 98e170b6eedc5c54e3ac88b6140fffb8b496deb4
RNShare: f116bbb04f310c665ca483d0bd1e88cf59b3b334
RNSVG: 43b64ed39c14ce830d840903774154ca0c1f27ec
RNSVG: a48668fd382115bc89761ce291a81c4ca5f2fd2e
RNVectorIcons: 6607bd3a30291d0edb56f9bbe7ae411ee2b928b0
segment-analytics-react-native: dbdd08d96fec78132e96bda092562e41c2ce0ce0
Sentry: ebc12276bd17613a114ab359074096b6b3725203
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@
"react-native-size-matters": "0.4.0",
"react-native-skeleton-placeholder": "^5.0.0",
"react-native-step-indicator": "^1.0.3",
"react-native-svg": "^15.2.0",
"react-native-svg": "^15.3.0",
"react-native-svg-charts": "^5.4.0",
"react-native-swipe-gestures": "1.0.3",
"react-native-tcp": "aprock/react-native-tcp#11/head",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -24632,10 +24632,10 @@ react-native-svg-transformer@^1.0.0:
"@svgr/plugin-svgo" "^6.1.2"
path-dirname "^1.0.2"

react-native-svg@^15.2.0:
version "15.2.0"
resolved "https://registry.yarnpkg.com/react-native-svg/-/react-native-svg-15.2.0.tgz#9561a6b3bd6b44689f437ba13182afee33bd5557"
integrity sha512-R0E6IhcJfVLsL0lRmnUSm72QO+mTqcAOM5Jb8FVGxJqX3NfJMlMP0YyvcajZiaRR8CqQUpEoqrY25eyZb006kw==
react-native-svg@^15.3.0:
version "15.3.0"
resolved "https://registry.yarnpkg.com/react-native-svg/-/react-native-svg-15.3.0.tgz#e24b833fe330714c99f1dd894bb0da52ad859a4c"
integrity sha512-mBHu/fdlzUbpGX8SZFxgbKvK/sgqLfDLP8uh8G7Us+zJgdjO8OSEeqHQs+kPRdQmdLJQiqPJX2WXgCl7ToTWqw==
dependencies:
css-select "^5.1.0"
css-tree "^1.1.3"
Expand Down

0 comments on commit 11ff42e

Please sign in to comment.