Skip to content

Commit

Permalink
fix: update Delete MetaMetrics Data copy to 30 days (#9674)
Browse files Browse the repository at this point in the history
## **Description**

- Update copy from 60 to 30 days
- Update initial text to remove part two and add a link on Metametrics
(requires to split text in 3 parts) See [change request
comment](#9674 (comment))
- The text change required to reorganise keys.
- New more explicit names used to clarify code and ease translation

## **Related issues**

fixes MetaMask/mobile-planning#1797

## **Manual testing steps**

1. Go to settings / Security & Privacy.
2. scroll to "delete metametrics data" section.
3. check description matches [@hesterbruikman
comment](#9674 (comment)):
> This will delete historical
[MetaMetrics](https://support.metamask.io/privacy-and-security/how-to-manage-your-metametrics-settings/)
data associated with your use on this device. Your wallet and accounts
will remain exactly as they are now after this data has been deleted.
This process may take up to 30 days. View our [Privacy
Policy](https://consensys.io/privacy-policy).
5. Check "MetaMetrics" and "Privacy Policy" links.
6. Touch "Delete MetaMetrics Data" button.
7. Touch "CLEAR" in the confirmation popup.
8. Check the confirmation message says "30 days".
9. Check "Privacy Policy" link.

## **Screenshots/Recordings**


https://github.com/MetaMask/metamask-mobile/assets/4677568/5402c2bf-f203-4d71-9818-7abdec3b860c

### **Before**

### **After**


![image](https://github.com/MetaMask/metamask-mobile/assets/4677568/f89d685a-c4a3-4807-9e1b-a2298c78224e)


![image](https://github.com/MetaMask/metamask-mobile/assets/4677568/fa72f009-9a47-4bd7-a899-12ad163b699a)

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>
  • Loading branch information
NicolasMassart and sethkfman authored May 31, 2024
1 parent 762eb0c commit cd796ce
Show file tree
Hide file tree
Showing 18 changed files with 75 additions and 107 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ import {
import { useMetrics } from '../../../../hooks/useMetrics';
import SettingsButtonSection from '../../../../UI/SettingsButtonSection';
import { strings } from '../../../../../../locales/i18n';
import { CONSENSYS_PRIVACY_POLICY } from '../../../../../constants/urls';
import {
CONSENSYS_PRIVACY_POLICY,
HOWTO_MANAGE_METAMETRICS,
} from '../../../../../constants/urls';
import Logger from '../../../../../util/Logger';
import { getBrand, getDeviceId } from 'react-native-device-info';
import Text, {
Expand Down Expand Up @@ -161,6 +164,7 @@ const DeleteMetaMetricsData = (props: DeleteMetaMetricsDataProps) => {
}, [metricsOptin, checkInitialStatus, setDataTrackedSinceLastDeletion]);

const openPrivacyPolicy = () => Linking.openURL(CONSENSYS_PRIVACY_POLICY);
const openMetametricsHowto = () => Linking.openURL(HOWTO_MANAGE_METAMETRICS);

return (
<SettingsButtonSection
Expand All @@ -174,38 +178,51 @@ const DeleteMetaMetricsData = (props: DeleteMetaMetricsDataProps) => {
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
{strings('app_settings.delete_metrics_description_part_one')}
</Text>{' '}
<Text
variant={TextVariant.BodyMDBold}
color={TextColor.Alternative}
>
{strings('app_settings.delete_metrics_description_part_two')}
</Text>{' '}
<Button
variant={ButtonVariants.Link}
size={ButtonSize.Auto}
onPress={openMetametricsHowto}
label={strings(
'app_settings.delete_metrics_description_part_two',
)}
/>{' '}
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
{strings('app_settings.delete_metrics_description_part_three')}
</Text>{' '}
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
{strings('app_settings.delete_metrics_description_before_delete')}
</Text>{' '}
<Button
variant={ButtonVariants.Link}
size={ButtonSize.Auto}
onPress={openPrivacyPolicy}
label={strings('app_settings.consensys_privacy_policy')}
label={strings(
'app_settings.delete_metrics_description_privacy_policy',
)}
/>
</>
) : (
<>
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
{strings('app_settings.delete_metrics_description_part_four')}
{strings(
'app_settings.delete_metrics_description_after_delete_part_one',
)}
</Text>{' '}
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
{deletionTaskDate}
</Text>
<Text variant={TextVariant.BodyMD} color={TextColor.Alternative}>
{strings('app_settings.delete_metrics_description_part_five')}
{strings(
'app_settings.delete_metrics_description_after_delete_part_two',
)}
</Text>{' '}
<Button
variant={ButtonVariants.Link}
size={ButtonSize.Auto}
onPress={openPrivacyPolicy}
label={strings('app_settings.consensys_privacy_policy')}
label={strings(
'app_settings.delete_metrics_description_privacy_policy',
)}
/>
</>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2414,7 +2414,38 @@ exports[`SecuritySettings should render correctly 1`] = `
}
}
>
This will delete historical MetaMetrics data associated with your wallet.
This will delete historical
</Text>
<Text
accessibilityRole="link"
accessible={true}
onPress={[Function]}
onPressIn={[Function]}
onPressOut={[Function]}
style={
{
"backgroundColor": "transparent",
"color": "#24272A",
}
}
suppressHighlighting={true}
>
<Text
accessibilityRole="text"
style={
{
"color": "#0376C9",
"fontFamily": "Euclid Circular B",
"fontSize": 14,
"fontWeight": "400",
"letterSpacing": 0,
"lineHeight": 22,
}
}
>
MetaMetrics
</Text>
</Text>
<Text
Expand All @@ -2424,13 +2455,13 @@ exports[`SecuritySettings should render correctly 1`] = `
"color": "#535A61",
"fontFamily": "Euclid Circular B",
"fontSize": 14,
"fontWeight": "700",
"fontWeight": "400",
"letterSpacing": 0,
"lineHeight": 22,
}
}
>
MetaMetrics data is anonymized usage and diagnostic data.
data associated with your wallet.
</Text>
<Text
Expand All @@ -2446,7 +2477,7 @@ exports[`SecuritySettings should render correctly 1`] = `
}
}
>
Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 60 days. View the
Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 30 days. View our
</Text>
<Text
Expand Down Expand Up @@ -2476,7 +2507,7 @@ exports[`SecuritySettings should render correctly 1`] = `
}
}
>
ConsenSys Privacy Policy.
Privacy Policy.
</Text>
</Text>
</Text>
Expand Down
3 changes: 3 additions & 0 deletions app/constants/urls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ export const CONNECTING_TO_A_DECEPTIVE_SITE =
export const CONNECTING_TO_DEPRECATED_NETWORK =
'https://support.metamask.io/hc/en-us/articles/360059213492-ETH-on-Sepolia-and-Goerli-networks-testnets';

export const HOWTO_MANAGE_METAMETRICS =
'https://support.metamask.io/privacy-and-security/how-to-manage-your-metametrics-settings/';

// Policies
export const CONSENSYS_PRIVACY_POLICY = 'https://consensys.net/privacy-policy/';

Expand Down
6 changes: 0 additions & 6 deletions locales/languages/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "Löschen",
"network_exists": "Dieses Netzwerk wurde bereits hinzugefügt.",
"delete_metrics_title": "MetaMetrics-Daten löschen",
"delete_metrics_description_part_one": "Dadurch werden alle historischen MetaMetrics-Daten in Verbindung mit Ihrer Wallet gelöscht.",
"delete_metrics_description_part_two": "MetaMetrics-Daten sind anonymisierte Nutzungs-und Diagnostikdaten.",
"delete_metrics_description_part_three": "Ihre Wallet und Ihre Konten bleiben nach der Löschung dieser Daten genau wie sie jetzt sind. Dieser Prozess kann bis zu 60 Tage in Anspruch nehmen. Lesen Sie die",
"delete_metrics_description_part_four": "Sie haben diese Aktion eingeleitet am",
"delete_metrics_description_part_five": ". Dieser Prozess kann bis zu 60 Tage in Anspruch nehmen. Lesen Sie die",
"consensys_privacy_policy": "ConsenSys-Datenschutzerklärung.",
"delete_metrics_button": "MetaMetrics-Daten löschen",
"check_status_button": "Status überprüfen",
"delete_metrics_confirm_modal_title": "MetaMetrics-Daten löschen?",
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/el.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "Διαγραφή",
"network_exists": "Αυτό το δίκτυο έχει ήδη προστεθεί.",
"delete_metrics_title": "Διαγραφή δεδομένων MetaMetrics",
"delete_metrics_description_part_one": "Αυτό θα διαγράψει το ιστορικό δεδομένων MetaMetrics που σχετίζεται με το πορτοφόλι σας.",
"delete_metrics_description_part_two": "Τα MetaMetrics είναι ανώνυμα δεδομένα χρήσης και διαγνωστικών.",
"delete_metrics_description_part_three": "Το πορτοφόλι και οι λογαριασμοί σας θα παραμείνουν ακριβώς όπως είναι τώρα μετά τη διαγραφή αυτών των δεδομένων. Αυτή η διαδικασία μπορεί να διαρκέσει έως και 60 ημέρες. Δείτε το",
"delete_metrics_description_part_four": "Ξεκινήσατε αυτή την ενέργεια στις",
"delete_metrics_description_part_five": ". Η διαδικασία αυτή μπορεί να διαρκέσει έως και 60 ημέρες. Δείτε το",
"consensys_privacy_policy": "Πολιτική Απορρήτου ConsenSys.",
"delete_metrics_button": "Διαγραφή δεδομένων MetaMetrics",
"check_status_button": "Έλεγχος Κατάστασης",
"delete_metrics_confirm_modal_title": "Διαγραφή δεδομένων MetaMetrics;",
Expand Down
15 changes: 8 additions & 7 deletions locales/languages/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,13 @@
"delete": "Delete",
"network_exists": "This network has already been added.",
"delete_metrics_title": "Delete MetaMetrics data",
"delete_metrics_description_part_one": "This will delete historical MetaMetrics data associated with your wallet.",
"delete_metrics_description_part_two": "MetaMetrics data is anonymized usage and diagnostic data.",
"delete_metrics_description_part_three": "Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 60 days. View the",
"delete_metrics_description_part_four": "You initiated this action on",
"delete_metrics_description_part_five": ". This process can take up to 60 days. View the",
"consensys_privacy_policy": "ConsenSys Privacy Policy.",
"delete_metrics_description_part_one": "This will delete historical",
"delete_metrics_description_part_two": "MetaMetrics",
"delete_metrics_description_part_three": "data associated with your wallet.",
"delete_metrics_description_before_delete": "Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 30 days. View our",
"delete_metrics_description_after_delete_part_one": "You initiated this action on",
"delete_metrics_description_after_delete_part_two": ". This process can take up to 30 days. View our",
"delete_metrics_description_privacy_policy": "Privacy Policy.",
"delete_metrics_button": "Delete MetaMetrics data",
"check_status_button": "Check Status",
"delete_metrics_confirm_modal_title": "Delete MetaMetrics data?",
Expand Down Expand Up @@ -1443,7 +1444,7 @@
"yes": "Yes",
"undefined_account": "Undefined account",
"close_tab": "Close tab",
"switch_tab": "Switch tab",
"switch_tab": "Switch tab",
"protocol_alert_options": {
"ignore": "Ignore",
"allow": "Allow"
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "Eliminar",
"network_exists": "La red ya ha sido instalada",
"delete_metrics_title": "Eliminar datos de MetaMetrics",
"delete_metrics_description_part_one": "Esto eliminará los datos históricos de MetaMetrics asociados a su monedero.",
"delete_metrics_description_part_two": "Los datos de MetaMetrics son datos anónimos de uso y diagnóstico.",
"delete_metrics_description_part_three": "Su monedero y cuentas permanecerán exactamente como están ahora después de que se hayan eliminado estos datos. Este proceso puede demorar hasta 60 días. Ver el",
"delete_metrics_description_part_four": "Inició esta acción el",
"delete_metrics_description_part_five": ". Este proceso puede tardar hasta 60 días. Ver el",
"consensys_privacy_policy": "Política de privacidad de ConsenSys.",
"delete_metrics_button": "Eliminar datos de MetaMetrics",
"check_status_button": "Comprobar estado",
"delete_metrics_confirm_modal_title": "¿Eliminar datos de MetaMetrics?",
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "Supprimer",
"network_exists": "Ce réseau a déjà été ajouté.",
"delete_metrics_title": "Supprimer les données MetaMetrics",
"delete_metrics_description_part_one": "Cela supprimera toutes les données MetaMetrics associées à votre portefeuille.",
"delete_metrics_description_part_two": "Les données MetaMetrics sont des données d’utilisation et de diagnostic anonymisées.",
"delete_metrics_description_part_three": "Votre portefeuille et vos comptes resteront exactement tels qu’ils sont maintenant après la suppression de ces données. Ce processus peut prendre jusqu’à 60 jours. Veuillez consulter la",
"delete_metrics_description_part_four": "Vous avez entrepris cette action le",
"delete_metrics_description_part_five": ". Ce processus peut prendre jusqu’à 60 jours. Veuillez consulter la",
"consensys_privacy_policy": "Politique de confidentialité de ConsenSys.",
"delete_metrics_button": "Supprimer les données MetaMetrics",
"check_status_button": "Vérifier l’état",
"delete_metrics_confirm_modal_title": "Voulez-vous supprimer les données MetaMetrics ?",
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/hi.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "हटाएँ",
"network_exists": "यह नेटवर्क पहले से ही जोड़ा जा चुका है।",
"delete_metrics_title": "मेटामेट्रिक्स डेटा हटाएं",
"delete_metrics_description_part_one": "यह आपके वॉलेट से जुड़े ऐतिहासिक मेटामेट्रिक्स डेटा को हटा देगा।",
"delete_metrics_description_part_two": "मेटामेट्रिक्स डेटा अनाम उपयोग और नैदानिक डेटा है।",
"delete_metrics_description_part_three": "इस डेटा को हटा दिए जाने के बाद आपका वॉलेटऔर अकाउंट ठीक वैसे ही रहेंगे जैसे वे अभी हैं। इस प्रक्रिया में 60 दिन तक लग सकते हैं। देखें",
"delete_metrics_description_part_four": "आपने द्वारा यह कार्रवाई शुरू करने की तिथि",
"delete_metrics_description_part_five": ". इस प्रक्रिया में 60 दिन तक लग सकते हैं। देखें",
"consensys_privacy_policy": "ConsenSys गोपनीयता नीति।",
"delete_metrics_button": "मेटामेट्रिक्स डेटा हटाएं",
"check_status_button": "स्थिति जांचें",
"delete_metrics_confirm_modal_title": "मेटामेट्रिक्स डेटा हटाएं?",
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/id.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "Hapus",
"network_exists": "Jaringan ini telah ditambahkan.",
"delete_metrics_title": "Hapus data MetaMetrics",
"delete_metrics_description_part_one": "Tindakan ini akan menghapus data MetaMetrics historis yang terkait dengan dompet Anda.",
"delete_metrics_description_part_two": "Data MetaMetrics merupakan data penggunaan dan diagnostik yang dianonimkan.",
"delete_metrics_description_part_three": "Dompet dan akun Anda akan tetap sama seperti sekarang setelah data ini dihapus. Proses ini mungkin memerlukan waktu hingga 60 hari. Lihat",
"delete_metrics_description_part_four": "Anda memulai tindakan ini pada",
"delete_metrics_description_part_five": ". Proses ini bisa memerlukan waktu hingga 60 hari. Lihat",
"consensys_privacy_policy": "Kebijakan Privasi Consensys.",
"delete_metrics_button": "Hapus data MetaMetrics",
"check_status_button": "Periksa Status",
"delete_metrics_confirm_modal_title": "Hapus data MetaMetrics?",
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "削除",
"network_exists": "このネットワークはすでに追加されています。",
"delete_metrics_title": "MetaMetricsデータを削除",
"delete_metrics_description_part_one": "これにより、ウォレットに関連付けられた過去のMetaMetricsデータが削除されます。",
"delete_metrics_description_part_two": "MetaMetricsデータは、匿名化された使用および診断データです。",
"delete_metrics_description_part_three": "このデータが削除されてもウォレットとアカウントに変化はありません。このプロセスには最長60日かかる場合があります。こちらをご覧ください:",
"delete_metrics_description_part_four": "このアクションは次の日に開始されました:",
"delete_metrics_description_part_five": "。このプロセスには最長60日かかる場合があります。こちらをご覧ください:",
"consensys_privacy_policy": "Consensysプライバシーポリシー",
"delete_metrics_button": "MetaMetricsデータを削除",
"check_status_button": "ステータスを確認",
"delete_metrics_confirm_modal_title": "MetaMetricsデータを削除しますか?",
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "삭제",
"network_exists": "이 네트워크는 이미 추가되었습니다.",
"delete_metrics_title": "MetaMetrics 데이터 삭제",
"delete_metrics_description_part_one": "지갑에 연결된 MetaMetrics 데이터 기록이 삭제됩니다.",
"delete_metrics_description_part_two": "MetaMetrics는 익명 처리된 사용 데이터와 진단 데이터입니다.",
"delete_metrics_description_part_three": "이 데이터를 삭제해도 지갑과 계정에는 아무런 영향이 없습니다. 삭제에는 약 60일 정도 소요됩니다. 다음을 참조하십시오:",
"delete_metrics_description_part_four": "다음에서 이 행동을 시작했습니다:",
"delete_metrics_description_part_five": "이 과정에는 약 60일 정도 소요됩니다. 다음을 참조하십시오:",
"consensys_privacy_policy": "ConsenSys 개인정보 보호방침.",
"delete_metrics_button": "MetaMetrics 데이터 삭제",
"check_status_button": "상태 확인",
"delete_metrics_confirm_modal_title": "MetaMetrics 데이터를 삭제할까요?",
Expand Down
6 changes: 0 additions & 6 deletions locales/languages/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@
"delete": "Excluir",
"network_exists": "Essa rede já foi adicionada.",
"delete_metrics_title": "Excluir dados do MetaMetrics",
"delete_metrics_description_part_one": "Isso excluirá os dados históricos do MetaMetrics associados à sua carteira.",
"delete_metrics_description_part_two": "Os dados do MetaMetrics compreendem utilização anonimizada e dados de diagnóstico.",
"delete_metrics_description_part_three": "Após a exclusão desses dados, sua carteira e contas permanecerão exatamente como estão agora. Esse processo pode levar até 60 dias. Veja o",
"delete_metrics_description_part_four": "Você iniciou essa ação em",
"delete_metrics_description_part_five": ". Esse processo pode levar até 60 dias. Veja o",
"consensys_privacy_policy": "Política de Privacidade da Consensys.",
"delete_metrics_button": "Excluir dados do MetaMetrics",
"check_status_button": "Verificar status",
"delete_metrics_confirm_modal_title": "Excluir dados do MetaMetrics?",
Expand Down
Loading

0 comments on commit cd796ce

Please sign in to comment.