Skip to content

Commit

Permalink
fix: Fix/ruby install (#9772)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixes e2e build failures caused by a failed ruby install on
Bitrise. This failure was a result of ruby being bumped from 3.1.4 ->
3.1.5 from Bitrise's changelog -
https://stacks.bitrise.io/changelogs/osx-xcode-15.0.x/#stack-update-v2024-05-24-released-on-2024-05-27


## **Related issues**

Fixes:

## **Manual testing steps**

1. Recommend to use rbenv to manage ruby. If you need rbenv - `brew
install rbenv`
2. Install new version of ruby - rbenv install 3.1.5
3. Set global version of ruby - rbenv global 3.1.5
4. Set local version of ruby - rbenv local 3.1.5
5. Re-run `yarn setup`
6. Should be able to compile apps as usual

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
Cal-L authored May 28, 2024
1 parent 7fa75b3 commit f4380de
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.1.4
3.1.5
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
source 'https://rubygems.org'

# Recommended to use http://rbenv.org/ to install and use this version
ruby '>= 3.1.4'
ruby '>= 3.1.5'

# Allow minor version updates up to but excluding 2.0.0
gem 'cocoapods', '~> 1.12'
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ DEPENDENCIES
cocoapods (~> 1.12)

RUBY VERSION
ruby 3.1.4p223
ruby 3.1.5p252

BUNDLED WITH
2.5.8

0 comments on commit f4380de

Please sign in to comment.