Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add team label to pr #10086

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat: Add team label to pr #10086

merged 1 commit into from
Jun 25, 2024

Conversation

itsyoboieltr
Copy link
Contributor

Description

This PR adds the add-team-label GitHub workflow and the accompanying add-team-label-to-pr script. Most of the implementation follows the add-release-label GitHub workflow and the add-release-label-to-pr-and-linked-issues script. To make the implementation easier, a new helper function, addLabelByIdToLabelable was also added, and the previously non-exported retrieveLabel function was exported.

When a new PR is opened, it will automatically add the author's team to the labels.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2447

Manual testing steps

  1. Open PR, and see that the correct label is added.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Jun 24, 2024
@itsyoboieltr itsyoboieltr requested a review from a team as a code owner June 24, 2024 14:09
Copy link
Contributor

github-actions bot commented Jun 24, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@itsyoboieltr
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

sonarcloud bot commented Jun 24, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@gauthierpetetin gauthierpetetin merged commit 789846e into main Jun 25, 2024
36 of 37 checks passed
@gauthierpetetin gauthierpetetin deleted the add-team-label-to-pr branch June 25, 2024 04:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
@metamaskbot metamaskbot added the release-7.27.0 Issue or pull request that will be included in release 7.27.0 label Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.27.0 Issue or pull request that will be included in release 7.27.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants