-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for svg uris without viewbox #10247
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: c620aef Note
|
c620aef
to
e6191a1
Compare
…upport-svg-uri-without-viewbox
Bitrise✅✅✅ Commit hash: a0581b4 Note
|
organize hooks into separate file inside the /hooks folder
5434249
to
f91517e
Compare
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: f91517e Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Well done!
Description
We have ran into some SVG rendering issues with SVG URIs. This is due to some SVGs do not contain a view-box, thus can be much larger or smaller than the container it is trying to fit in.
For example:
See Example Screenshot
This adds an effect to use the SVG width/height for setting a view box if not set in the SVG.
Related issues
Known issue and temporary fix in
react-native-svg
:software-mansion/react-native-svg#1202 (comment)
Manual testing steps
Screenshots/Recordings
Before
Before
After
After
Pre-merge author checklist
Pre-merge reviewer checklist