Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flag Snaps Webview load dependency #10250

Closed

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR has the only purpose to avoid Snap's Webview to be loaded/accessible when Basic Functionality is off.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Jul 4, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner July 4, 2024 14:51
Copy link
Contributor

github-actions bot commented Jul 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Aug 12, 2024

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NicolasMassart NicolasMassart added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 008614d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/67ad5a79-156c-4c97-8bc1-99e0b1827e5d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer
Copy link
Contributor Author

I'll drop this PR since the changes are included in another PR.

@Jonathansoufer Jonathansoufer deleted the feat/SnapsExecutionWebView-load-conditional branch August 21, 2024 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants