Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add ui pieces for the notification modals #10254

Conversation

Prithpal-Sooriya
Copy link
Contributor

this includes all the unique headers, fields, and footers

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

this includes all the unique headers, fields, and footers
Copy link
Contributor

github-actions bot commented Jul 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications Notifications team label Jul 5, 2024
all notifications are now handled in their respective file, and connected to the UI via generic components
rather than hardcoded values, we are now using flex for a more dynamic UI.
@Jonathansoufer Jonathansoufer marked this pull request as ready for review July 7, 2024 20:40
@Jonathansoufer Jonathansoufer requested review from a team as code owners July 7, 2024 20:40
@Jonathansoufer Jonathansoufer merged commit 23899c8 into feat/notifications-integration-sdk Jul 7, 2024
7 of 8 checks passed
@Jonathansoufer Jonathansoufer deleted the temp/notification-integration-sdk-fixes branch July 7, 2024 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants