Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip blockaid validations for users internal accounts #10264

Merged
merged 9 commits into from
Jul 12, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 8, 2024

Description

Skip blockaid validation for users internal accounts

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2633

Manual testing steps

  1. Make a send transaction to user's own account
  2. Check that blockaid validation is not done

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jul 8, 2024
@jpuri jpuri requested review from a team as code owners July 8, 2024 06:40
Copy link
Contributor

github-actions bot commented Jul 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 79ea9c5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ad446b6d-b753-4975-9646-addfa43c39a0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri requested a review from a team as a code owner July 8, 2024 10:16
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f31edca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8a70c7a-e137-4bb2-9716-0e701a49a932

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri changed the title fix: skip blockaid validations for users internal accounts #25695 fix: skip blockaid validations for users internal accounts Jul 9, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 9, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Jul 11, 2024
app/lib/ppom/ppom-util.ts Show resolved Hide resolved
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting minor update to test before merge

app/lib/ppom/ppom-util.test.ts Outdated Show resolved Hide resolved
app/lib/ppom/ppom-util.ts Show resolved Hide resolved
@jpuri jpuri requested a review from digiwand July 12, 2024 07:32
@jpuri jpuri requested a review from matthewwalsh0 July 12, 2024 14:50
matthewwalsh0
matthewwalsh0 previously approved these changes Jul 12, 2024
@jpuri jpuri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 12, 2024
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 12, 2024
Copy link
Contributor

github-actions bot commented Jul 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 41a66bf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e5397ee-2e34-46ce-850a-59529d2c1d0e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini previously approved these changes Jul 12, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Jul 12, 2024
Copy link

sonarcloud bot commented Jul 12, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.70%. Comparing base (b2cce87) to head (91810c3).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10264      +/-   ##
==========================================
+ Coverage   49.67%   49.70%   +0.03%     
==========================================
  Files        1450     1451       +1     
  Lines       34888    34919      +31     
  Branches     3950     3955       +5     
==========================================
+ Hits        17330    17356      +26     
- Misses      16456    16459       +3     
- Partials     1102     1104       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 4867f0b into main Jul 12, 2024
31 of 32 checks passed
@jpuri jpuri deleted the blockaid_skip_internal_accounts branch July 12, 2024 23:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.28.0 Issue or pull request that will be included in release 7.28.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants