Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: e2e Reveal Secret Recovery Phrase Quiz answer confirmation #10273

Merged
merged 20 commits into from
Jul 19, 2024
Merged

test: e2e Reveal Secret Recovery Phrase Quiz answer confirmation #10273

merged 20 commits into from
Jul 19, 2024

Conversation

plasmacorral
Copy link
Contributor

@plasmacorral plasmacorral commented Jul 9, 2024 •
edited by gantunesr
Loading

Description

This pull request introduces a new test that navigates through the Secret Recovery Phrase reveal quiz, up to the password entry prompt. It verifies that the flow can be successfully completed when incorrect answers are provided and then resubmitted with the correct answer chosen.

Related issues

Fixes: 492

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@plasmacorral plasmacorral added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4a97f94
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f984ec9-7135-42c8-b078-c89e1da912bd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@plasmacorral plasmacorral added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6032082
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c29b0f2-15d4-4dd6-ade9-af226cb9db9c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@plasmacorral plasmacorral changed the title SRP reveal quiz test setup test: Reveal Secret Recovery Phrase Quiz answer confirmation Jul 17, 2024
@plasmacorral plasmacorral changed the title test: Reveal Secret Recovery Phrase Quiz answer confirmation test: e2e Reveal Secret Recovery Phrase Quiz answer confirmation Jul 17, 2024
@chrisleewilcox
Copy link
Contributor

chrisleewilcox commented Jul 17, 2024 •
edited
Loading

@plasmacorral you can look at swaps use of fixtures and see it that works for your tests.

./e2e/specs/swaps/swap-action-smoke.spec.js

@plasmacorral plasmacorral added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9a909e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcd970d5-5f7e-463f-8eaa-5d41188a95f2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@plasmacorral plasmacorral added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1d2a877
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e67cd441-488c-49d5-916b-1573288b6bf0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cortisiko
cortisiko requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this 👏, I have left some feedback

e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js Outdated Show resolved Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js Outdated Show resolved Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js Outdated Show resolved Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js Outdated Show resolved Hide resolved
e2e/specs/accounts/secret_recovery_phrase_quiz.spec.js Outdated Show resolved Hide resolved
e2e/specs/accounts/secret_recovery_phrase_quiz.spec.js Outdated Show resolved Hide resolved
e2e/specs/accounts/secret_recovery_phrase_quiz.spec.js Outdated Show resolved Hide resolved
e2e/pages/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js Outdated Show resolved Hide resolved
e2e/selectors/Settings/SecurityAndPrivacy/RevealSeedView.selectors.js Outdated Show resolved Hide resolved
e2e/specs/accounts/secret_recovery_phrase_quiz.spec.js Outdated Show resolved Hide resolved
@plasmacorral plasmacorral added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 608c1ab
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6bbb8abc-2eb6-4b56-a5e4-1e46afc9f1e6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@plasmacorral plasmacorral added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 39a459e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/37885571-54ab-483f-9b04-5d795f8dde31

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@plasmacorral plasmacorral added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 19, 2024
@plasmacorral plasmacorral marked this pull request as ready for review July 19, 2024 06:49
@plasmacorral plasmacorral requested a review from a team as a code owner July 19, 2024 06:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a411acc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2698e328-0734-4b5f-bc4b-0a5eab686ce7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cortisiko
cortisiko approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@plasmacorral plasmacorral merged commit a0c9b95 into main Jul 19, 2024
40 checks passed
@plasmacorral plasmacorral deleted the e2e/SRP-reveal-quiz branch July 19, 2024 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-7.28.0 Issue or pull request that will be included in release 7.28.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@plasmacorral @chrisleewilcox @cortisiko @gantunesr @metamaskbot