-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add dark mode to storybook #10286
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left one question regarding where the ThemeProvider lives
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10286 +/- ##
==========================================
- Coverage 49.78% 49.62% -0.17%
==========================================
Files 1437 1463 +26
Lines 34762 35376 +614
Branches 3921 4030 +109
==========================================
+ Hits 17307 17554 +247
- Misses 16354 16713 +359
- Partials 1101 1109 +8 ☔ View full report in Codecov by Sentry. |
…to theming-fix
Quality Gate passedIssues Measures |
Description
This PR adds dark mode OS toggle on storybook
Related issues
Fixes: #8683
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-11.at.10.48.52.mp4
Pre-merge author checklist
Pre-merge reviewer checklist