Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate Tests to use RNTL from Enzyme #10296

Closed
wants to merge 9 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Description

The changes include updates to unit tests and other improvements as part of ongoing development for the files

app/component-library/components/Badges/Badge/foundation/BadgeBase/BadgeBase.test.tsx
app/component-library/components/Sheet/SheetBottom/SheetBottom.test.tsx
app/component-library/components/Accordions/Accordion/foundation/AccordionHeader/AccordionHeader.test.tsx
app/component-library/components/Sheet/SheetHeader/SheetHeader.test.tsx

Reason for change: To update the testing framework from Enzyme to React Native Testing Library for better testing practices and to align with current standards.

Improvement/solution: Consolidated changes from three separate branches, enhancing unit tests by migrating to React Native Testing Library and updating snapshot files accordingly.

Related issues

Manual testing steps

  1. Build and run the application.
  2. Navigate to the components affected by the changes (AccordionHeader, BadgeBase, SheetHeader, SheetBottom) and ensure they render correctly.
  3. Run the updated unit tests to verify that they pass with the new testing framework.

Screenshots/Recordings

Pre-merge author checklist

  • I've followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot added team-ai AI team (for the Devin AI bot) No QA Needed Apply this label when your PR does not need any QA effort. labels Jul 13, 2024
@devin-ai-integration devin-ai-integration bot changed the title chore: Merge unit test updates chore:Migrate Tests to use RNTL from Enzyme Jul 13, 2024
@devin-ai-integration devin-ai-integration bot changed the title chore:Migrate Tests to use RNTL from Enzyme chore: Migrate Tests to use RNTL from Enzyme Jul 13, 2024
Copy link

sonarcloud bot commented Jul 13, 2024

@NicolasMassart
Copy link
Contributor

This PR from Devin is not good enough

@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-ai AI team (for the Devin AI bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant