Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove details and list references - 2/7 #10301

Merged
merged 2 commits into from
Jul 15, 2024
Merged

chore: remove details and list references - 2/7 #10301

merged 2 commits into from
Jul 15, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Jul 15, 2024 •
edited
Loading

Description

This PR removes Notifications UI in order to allow an implementation based on multiple smaller PRs with minimal interdependency.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Jul 15, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners July 15, 2024 08:39
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jul 15, 2024
@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform team-notifications Notifications team labels Jul 15, 2024
@Jonathansoufer Jonathansoufer changed the title chore: remove details and list references chore: remove details and list references - 2/7 Jul 15, 2024
Prithpal-Sooriya
Prithpal-Sooriya approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in, and then the subsequent PRs to add back the correct components and screens.

@tommasini
Copy link
Contributor

This is removing a big chunk of data, can we please run e2e tests and also do a recording? Making sure nothing stays broken while we break the work on smaller chunks

@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7af3daa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/71e1d589-d72e-41ab-b70c-803a2bc5052d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise team-snaps-platform Snaps Platform team labels Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8d517b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b9730d5-979d-4bee-bf13-3c2e1c526a99

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 15, 2024
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 15, 2024
@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 15, 2024
@Jonathansoufer Jonathansoufer added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 15, 2024
@Jonathansoufer Jonathansoufer merged commit d6ac920 into main Jul 15, 2024
59 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/remove-deprecated-notifications-ui branch July 15, 2024 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 15, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

@Jonathansoufer Jonathansoufer

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 team-notifications Notifications team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jonathansoufer @tommasini @Prithpal-Sooriya @metamaskbot