Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Views directory ts coverage - part 1 #10665

Merged
merged 11 commits into from
Aug 16, 2024
Merged

Conversation

joaoloureirop
Copy link
Contributor

Description

This PR aims to solve part of Views directory issues, so we can enable tsc on it

Files with issues solved

     3  app/components/Views/AccountConnect/AccountConnect.tsx:98
     2  app/components/Views/AccountPermissions/AccountPermissions.tsx:135
     1  app/components/Views/AccountPermissions/AccountPermissionsConnected/AccountPermissionsConnected.tsx:80
     2  app/components/Views/AccountPermissions/AccountPermissionsRevoke/AccountPermissionsRevoke.tsx:169
     3  app/components/Views/AddAsset/AddAsset.tsx:86
     3  app/components/Views/AssetDetails/index.tsx:273
     2  app/components/Views/BrowserUrlModal/BrowserUrlModal.tsx:105

Before:
Found 698 errors in 187 files.

After:
Found 685 errors in 182 files.

Related issues

Fixes: #10206

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

tommasini
tommasini previously approved these changes Aug 15, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 16, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 16, 2024

@tommasini tommasini merged commit 0d1e815 into main Aug 16, 2024
35 of 36 checks passed
@tommasini tommasini deleted the chore/ts-coverage-views-1 branch August 16, 2024 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.30.0 Issue or pull request that will be included in release 7.30.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Typescript type coverage Views Folder part 1
4 participants