Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.0 #11114

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Sep 9, 2024

Description

### Changed

- **BREAKING:** Bump `@metamask/ppom-validator` from `0.32.0` to `0.34.0` ([#11114](https://github.com/MetaMask/metamask-mobile/pull/11114))

To fully align the dependencies, a new release of ppom-validator will need to be released with version bumps for @metamask/{base-controller,controller-utils,network-controller,utils}.

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift MajorLift added DO-NOT-MERGE Pull requests that should not be merged team-wallet-framework labels Sep 9, 2024
@MajorLift MajorLift self-assigned this Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Sep 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/ppom-validator@0.35.1 None 0 122 kB metamaskbot
npm/@metamask/rpc-errors@6.4.0 None 0 165 kB metamaskbot

🚮 Removed packages: npm/@metamask/ppom-validator@0.32.0, npm/@metamask/rpc-errors@6.3.1

View full report↗︎

@MajorLift MajorLift force-pushed the jongsun/chore/bump/ppom-validator-0.33.0 branch 3 times, most recently from 17f1231 to 40dc590 Compare September 9, 2024 17:09
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from bb07086 to 172b0a0 Compare September 9, 2024 17:19
@MajorLift MajorLift force-pushed the jongsun/chore/bump/ppom-validator-0.33.0 branch from 40dc590 to 2ac8944 Compare September 9, 2024 17:21
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from 172b0a0 to cef95c9 Compare September 9, 2024 17:28
@MajorLift MajorLift force-pushed the jongsun/chore/bump/ppom-validator-0.33.0 branch from 2ac8944 to c9eee83 Compare September 9, 2024 17:31
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from cef95c9 to 6e69e1c Compare September 9, 2024 17:35
@MajorLift MajorLift force-pushed the jongsun/chore/bump/ppom-validator-0.33.0 branch from c9eee83 to 55f13d8 Compare September 9, 2024 17:43
@MajorLift MajorLift marked this pull request as ready for review September 9, 2024 17:59
@MajorLift MajorLift requested review from a team as code owners September 9, 2024 17:59
@MajorLift MajorLift requested a review from a team September 9, 2024 18:04
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from 470a124 to a332749 Compare September 10, 2024 07:58
@MajorLift MajorLift force-pushed the jongsun/chore/bump/ppom-validator-0.33.0 branch from 6c27f25 to 839317e Compare September 10, 2024 08:06
@MajorLift MajorLift marked this pull request as draft September 10, 2024 11:59
@MajorLift MajorLift requested a review from a team September 10, 2024 16:48
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from 39bcf98 to 5f0eec9 Compare September 11, 2024 19:40
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch 3 times, most recently from 058687b to b4bfd59 Compare September 12, 2024 06:48
@MajorLift MajorLift force-pushed the jongsun/fix-composable-controller branch from b4bfd59 to 69970ad Compare September 12, 2024 07:02
@MajorLift MajorLift force-pushed the jongsun/chore/bump/ppom-validator-0.33.0 branch from ae70aa6 to bc8db54 Compare September 20, 2024 20:44
…ApprovalControllerMessenger`"

This reverts commit 6e69e1c.
- `getNetworkClientById` unneeded as `PPOMController` utilizes the action
- Code for extracting `chainId` using `selectedNetworkClient` pushed upstream
@MajorLift MajorLift force-pushed the jongsun/chore/bump/ppom-validator-0.33.0 branch from bc8db54 to b6d9b0c Compare September 20, 2024 20:45
- Reverts `approval-controller`resolution from `7.0.3` to `7.0.2`
@MajorLift MajorLift added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise DO-NOT-MERGE Pull requests that should not be merged labels Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: eeddb08
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2280079e-4baf-4616-a6e4-4fdaa9e3a8e0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@mikesposito mikesposito self-assigned this Oct 14, 2024
@mikesposito mikesposito changed the title chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.34.0 chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.0 Oct 17, 2024
package.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.64%. Comparing base (b0ef1a7) to head (ea3eb0c).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11114      +/-   ##
==========================================
+ Coverage   54.27%   54.64%   +0.37%     
==========================================
  Files        1711     1743      +32     
  Lines       38712    39355     +643     
  Branches     4738     4879     +141     
==========================================
+ Hits        21010    21505     +495     
- Misses      16253    16356     +103     
- Partials     1449     1494      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 21, 2024

@mikesposito
Copy link
Member

We currently have four different @metamask/network-controller major versions in the dependency tree:

v21

=> Found "@metamask/network-controller@21.0.1"
info Has been hoisted to "@metamask/network-controller"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "5.07MB"
info Disk size with unique dependencies: "17.91MB"
info Disk size with transitive dependencies: "39.14MB"
info Number of shared dependencies: 60

v20

=> Found "@metamask/smart-transactions-controller#@metamask/network-controller@20.1.0"
info This module exists because "@metamask#smart-transactions-controller" depends on it.
info Disk size without dependencies: "3.17MB"
info Disk size with unique dependencies: "15.18MB"
info Disk size with transitive dependencies: "36.98MB"
info Number of shared dependencies: 59

v19

=> Found "@metamask/polling-controller#@metamask/network-controller@19.0.0"
info This module exists because "@metamask#polling-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/assets-controllers#@metamask/network-controller@19.0.0"
info This module exists because "@metamask#assets-controllers" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/gas-fee-controller#@metamask/network-controller@19.0.0"
info This module exists because "@metamask#gas-fee-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/selected-network-controller#@metamask/network-controller@19.0.0"
info This module exists because "@metamask#selected-network-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

=> Found "@metamask/smart-transactions-controller#@metamask/transaction-controller#@metamask/network-controller@19.0.0"
info This module exists because "@metamask#smart-transactions-controller#@metamask#transaction-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58

v17

=> Found "@metamask/swaps-controller#@metamask/network-controller@17.2.1"
info Reasons this module exists
   - "@metamask#swaps-controller#@metamask#gas-fee-controller" depends on it
   - Hoisted from "@metamask#swaps-controller#@metamask#gas-fee-controller#@metamask#network-controller"
   - Hoisted from "@metamask#swaps-controller#@metamask#gas-fee-controller#@metamask#polling-controller#@metamask#network-controller"
info Disk size without dependencies: "452KB"
info Disk size with unique dependencies: "11.67MB"
info Disk size with transitive dependencies: "35.82MB"
info Number of shared dependencies: 59

This version mismatch is visible through TS errors, but it is hard to say if some functionality is broken as well, and very hard to tell by looking at Changelogs since a lot of things changed between these NetworkController major versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.0
4 participants