Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/component-library/components/Icons/Icon/scripts/generate-assets.js to TypeScript #11594

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 3, 2024

This PR converts the generate-assets.js file to TypeScript.

This Devin run was requested by naveen.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested review from a team as code owners October 3, 2024 10:00
@devin-ai-integration devin-ai-integration bot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5421f0f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0b0a3244-5d42-4995-89c1-e5edadb34592

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

Copy link
Contributor

@kylanhurt kylanhurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and bypassing Sonar Cloud

@kylanhurt kylanhurt added this pull request to the merge queue Oct 3, 2024
@devin-ai-integration devin-ai-integration bot removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 3, 2024
Merged via the queue into main with commit 1943b37 Oct 3, 2024
56 of 58 checks passed
@kylanhurt kylanhurt deleted the devin/convert-ts-generate-assets-23367 branch October 3, 2024 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 3, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants