Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix signature requested analytics #11595

Merged
merged 4 commits into from
Oct 7, 2024
Merged

fix: fix signature requested analytics #11595

merged 4 commits into from
Oct 7, 2024

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Oct 3, 2024

Description

This PR fixes an issue where the Signature Requested mobile analytics event was not being sent when a dapp sends a sign request. Only the Signature Approved analytics where being sent.

Examples:
From MetaMask SDK Wagmi test dapp (mobile browser):

{"event": "Signature Requested", "properties": {"account_type": "MetaMask", "chain_id": "11155111", "dapp_host_name": "wagmi.io", "request_platform": "web-mobile", "request_source": "MetaMask-SDK-Remote-Conn", "signature_type": "personal_sign", "version": "N/A"}, "type": "track"}

From WalletConnect test dapp (mobile browser):

{"event": "Signature Requested", "properties": {"account_type": "MetaMask", "chain_id": "11155111", "dapp_host_name": "appkit-lab.reown.com", "request_platform": undefined, "request_source": "WalletConnect", "signature_type": "eth_signTypedData_v4", "version": "N/A"}, "type": "track"}

From iOS SDK test dapp:

{"event": "Signature Requested", "properties": {"account_type": "MetaMask", "chain_id": "11155111", "dapp_host_name": "dubdapp.com", "request_platform": "ios", "request_source": "MetaMask-SDK-Remote-Conn", "signature_type": "eth_signTypedData_v4", "version": "N/A"}, "type": "track"}

Related issues

Fixes: SDK-65

Manual testing steps

  1. Go to this mmsdk-wagmi-test-dapp on mobile device
  2. Connect to MetaMask
  3. Sign message
  4. Check the logs that Signature Requested is being logged to analytics and also check Segment that the event is being received.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@elefantel elefantel requested a review from a team as a code owner October 3, 2024 10:22
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-sdk SDK team label Oct 3, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 3, 2024
@elefantel elefantel added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 3, 2024
@elefantel elefantel requested review from Cal-L and removed request for Cal-L October 3, 2024 10:23
@elefantel elefantel added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 3, 2024
@elefantel elefantel self-assigned this Oct 3, 2024
@elefantel elefantel requested review from a team as code owners October 4, 2024 19:30
Copy link

sonarcloud bot commented Oct 4, 2024

@elefantel elefantel added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 8b5e4cc Oct 7, 2024
37 checks passed
@elefantel elefantel deleted the signature-requested branch October 7, 2024 11:20
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-sdk SDK team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants