Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: await for detect origin before logging analytics #11603

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Oct 3, 2024

Description

This PR fixes an issue where the request_source was defaulting to WalletConnect even when transaction is done in the in app browser because the detectOrigin function is async but it was not being awaited.

Fixes SDK-78

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@elefantel elefantel requested a review from a team as a code owner October 3, 2024 15:15
@github-actions github-actions bot added the team-sdk SDK team label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@elefantel elefantel self-assigned this Oct 3, 2024
@elefantel elefantel added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 3, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 3, 2024
@darkwing darkwing requested review from a team and removed request for a team October 4, 2024 18:02
@elefantel elefantel requested a review from a team as a code owner October 4, 2024 19:29
Copy link

sonarcloud bot commented Oct 4, 2024

@elefantel elefantel removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 7, 2024
@elefantel elefantel added this pull request to the merge queue Oct 7, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 7, 2024
Merged via the queue into main with commit bec2c8e Oct 7, 2024
47 checks passed
@elefantel elefantel deleted the duplicate-dapp-transaction-analytics branch October 7, 2024 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-sdk SDK team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants