-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAKE-841 build unstake review confirmation screen #11611
base: main
Are you sure you want to change the base?
feat: STAKE-841 build unstake review confirmation screen #11611
Conversation
…input-review-bottom-sheet-component
…input-review-bottom-sheet-component
…racting with section to match latest designs
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
…unstake-review-confirmation-screen
…unstake-review-confirmation-screen
Bitrise✅✅✅ Commit hash: 08fa379 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes required due to updated components and hooks .
import CurrencyToggle from '../../components/CurrencySwitch'; | ||
import QuickAmounts from '../../components/QuickAmounts'; | ||
import useBalance from '../../hooks/useBalance'; | ||
import styleSheet from './StakeInputView.styles'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing error here for import path.
} from '../../../../../util/number'; | ||
import Keypad from '../../../../Base/Keypad'; | ||
import { useStyles } from '../../../../hooks/useStyles'; | ||
import { getStakeInputNavbar } from '../../../Navbar'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing error here for import paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need gas components for confirmation screens now ?
|
||
const [amount, setAmount] = useState('0'); | ||
const [amountBN, setAmountBN] = useState<BN>(new BN(0)); | ||
const { balance, balanceBN, balanceFiatNumber } = useBalance(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix error on renamed properties from the hook .
Description
Adds the unstaking confirmation screen. The screen is temporarily using mock data for certain elements.
Related issues
Manual testing steps
export MM_POOLED_STAKING_UI_ENABLED=true
to your.js.env
file.Note: Attaching the unstaking confirmation screen to the "Staked Ethereum" asset row is temporary in order to view the screen. The unstaking confirmation screen will be added to the unstaking flow when it's dependent screen(s) have been completed.
Screenshots/Recordings
Before
N/A - This is a new screen
After
stake-841-build-unstake-review-confirmation-screen-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist