chore: rename isprivateConnection to isPrivateConnection

[cryptodev-2s]

Description

This PR corrects a typo in isPrivateConnection, which was previously named isprivateConnection.

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Daniel-Cross]

Approved!

[NicolasMassart]

Looks good to me.

[NicolasMassart]

I initially approved but then realised that there's no unit test update for this change... Because there's no unit test. Not your fault, this funciton was not tested before.
But if you are annoyed by a case issue in the function name so much that you create a PR to update it, I would imagine that the lack of tests on this function is even more an issue for you. At least it is for me.
So ideally, given how simple this function is, and the fact we already have a test file for this utils file, you only have to add a very simple test, even AI generated, and I would approve the name change.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Gudahtt]

LGTM!

[Gudahtt]

For the PR title, I'd recommend that it be changed to "chore" even though this is fixing something, because "fix" typically means bug fix, which this is not. "chore" would be better because it would communicate to the author of the changelog that this can be omitted.

Also could you please update the PR description checklist?

[NicolasMassart]

Thank you!

[EtherWizard33]

LGTM