Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ReactNode support for KeyValueRow tooltip and label #11660

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Oct 7, 2024

Description

Iterates on the <KeyValueRow /> component by adding ReactNode support for tooltip content and label. This should allow for greater flexibility using <KeyValueRow />.

Related issues

These are prerequisite changes needed in mobile native staking tickets. (e.g. STAKE-824: [FE] Build staking input confirmation screen)

Manual testing steps

  1. Open the storybook
  2. Select <KeyValueRow /> inside of components-temp directory

Screenshots/Recordings

Before

Missing bottom example using ReactNode (Button Link)
image

After

Has bottom example that's using ReactNode (Button Link)
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 force-pushed the feat/key-value-row-component-improvements branch 2 times, most recently from 8f5170a to e378716 Compare October 7, 2024 17:16
@Matt561 Matt561 force-pushed the feat/key-value-row-component-improvements branch from e378716 to da8b99a Compare October 7, 2024 17:17
@Matt561 Matt561 marked this pull request as ready for review October 7, 2024 17:19
@Matt561 Matt561 requested review from a team as code owners October 7, 2024 17:19
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approving to unblock but @brianacnguyen may be a better resource for review.

Copy link

sonarcloud bot commented Oct 7, 2024

@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 7, 2024
@Matt561 Matt561 added this pull request to the merge queue Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b126022
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d7bff9eb-24ca-4458-b195-18c61b2d2221

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Merged via the queue into main with commit f845029 Oct 7, 2024
39 of 43 checks passed
@Matt561 Matt561 deleted the feat/key-value-row-component-improvements branch October 7, 2024 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants