Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/components/Base/HorizontalSelector/index.js to TypeScript #11661

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 7, 2024

Description

This PR converts the HorizontalSelector component from JavaScript to TypeScript.

Motivation and Context

This change is part of the ongoing effort to migrate the codebase to TypeScript, improving type safety and developer experience.

Changes

  • Renamed index.js to index.tsx
  • Added TypeScript interfaces for component props and styles
  • Removed PropTypes and replaced with TypeScript types
  • Updated imports to include necessary TypeScript types
  • Refactored createStyles function for better type inference

Testing Instructions

  1. Run yarn lint:tsc to ensure no TypeScript errors
  2. Test the HorizontalSelector component in various scenarios to ensure functionality remains unchanged

Screenshots/Recordings

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Link to Devin run

https://preview.devin.ai/devin/8bb5194eef49468e8d7c4fea51faaa3b

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 7, 2024 16:33
@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d1b3771
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d181b049-b20d-4109-88e9-5469e8503538

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link
Contributor

@kylanhurt kylanhurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylanhurt kylanhurt added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit a35d7bd Oct 10, 2024
54 of 55 checks passed
@kylanhurt kylanhurt deleted the devin/convert-ts-app-components-Base-HorizontalSelector-index.js-10751 branch October 10, 2024 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants